Skip to content

Commit a3fe260

Browse files
authored
fix(deps): vitest 4.1.11 (security) + skipLibCheck (#368)
Closes #337. ## What was blocking the security update The vitest advisory fix (Renovate PR #337, `vitest@4.1.0`) has been failing CI since it opened. The failure is not in this repo's code: ``` ../../node_modules/.pnpm/@vitest+runner@4.1.0/node_modules/@vitest/runner/dist/tasks.d-D2GKpdwQ.d.ts(1407,11): error TS2430: Interface 'FailureScreenshotArtifactAttachment' incorrectly extends interface 'TestAttachment'. Type 'FailureScreenshotArtifactAttachment' is not assignable to type 'TestAttachment' with 'exactOptionalPropertyTypes: true'. ``` `@repobuddy/typescript` enables `exactOptionalPropertyTypes`, and no config in the chain sets `skipLibCheck`, so `tsc` was type-checking a dependency's shipped declarations. A dependency we cannot edit therefore gates our build. `skipLibCheck: true` is added to the three package tsconfigs. It does not relax any check on this repo's own sources. ## Changes - `vitest` and `@vitest/coverage-v8` → `^4.1.11` in all three packages (advisory fixed in 4.1.0). - `skipLibCheck: true` in `packages/*/tsconfig.json`. `pnpm verify` (knip + lint + build + coverage + size, all three packages) passes locally. No changeset: dev dependencies and a compiler option — nothing reaches the published packages.
2 parents a02cf1e + cbde4d9 commit a3fe260

7 files changed

Lines changed: 169 additions & 262 deletions

File tree

packages/async-context/package.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -68,14 +68,14 @@
6868
"@repobuddy/typescript": "^2.0.0",
6969
"@size-limit/preset-small-lib": "^13.0.0",
7070
"@types/setimmediate": "^1.0.2",
71-
"@vitest/coverage-v8": "^4.0.8",
71+
"@vitest/coverage-v8": "^4.1.11",
7272
"assertron": "^11.0.1",
7373
"npm-run-all2": "^9.0.0",
7474
"repobuddy": "^1.0.2",
7575
"rimraf": "^6.0.0",
7676
"setimmediate": "^1.0.5",
7777
"size-limit": "^13.0.0",
78-
"vitest": "^4.0.8"
78+
"vitest": "^4.1.11"
7979
},
8080
"engines": {
8181
"node": ">= 14.16"

packages/async-context/tsconfig.json

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
11
{
22
"extends": "@repobuddy/typescript/tsconfig/monorepo",
33
"compilerOptions": {
4+
"skipLibCheck": true,
45
"outDir": "esm",
56
"lib": ["ES2022", "ESNext.Disposable", "DOM"],
67
"rootDir": "ts"

packages/async-fp/package.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -88,14 +88,14 @@
8888
"devDependencies": {
8989
"@repobuddy/typescript": "^2.0.0",
9090
"@size-limit/preset-small-lib": "^13.0.0",
91-
"@vitest/coverage-v8": "^4.0.8",
91+
"@vitest/coverage-v8": "^4.1.11",
9292
"assertron": "^11.0.1",
9393
"npm-run-all2": "^9.0.0",
9494
"repobuddy": "^1.0.2",
9595
"rimraf": "^6.0.0",
9696
"size-limit": "^13.0.0",
9797
"type-plus": "8.0.0-beta.8",
98-
"vitest": "^4.0.8"
98+
"vitest": "^4.1.11"
9999
},
100100
"engines": {
101101
"node": ">= 14.16"

packages/async-fp/tsconfig.json

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
11
{
22
"extends": "@repobuddy/typescript/tsconfig/monorepo",
33
"compilerOptions": {
4+
"skipLibCheck": true,
45
"outDir": "esm",
56
"lib": ["ES2022", "ESNext.Disposable", "DOM"],
67
"rootDir": "ts"

packages/gizmo/package.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -79,13 +79,13 @@
7979
"devDependencies": {
8080
"@repobuddy/typescript": "^2.0.0",
8181
"@size-limit/preset-small-lib": "^13.0.0",
82-
"@vitest/coverage-v8": "^4.0.8",
82+
"@vitest/coverage-v8": "^4.1.11",
8383
"assertron": "^11.0.1",
8484
"npm-run-all2": "^9.0.0",
8585
"repobuddy": "^1.0.2",
8686
"rimraf": "^6.0.0",
8787
"size-limit": "^13.0.0",
88-
"vitest": "^4.0.8"
88+
"vitest": "^4.1.11"
8989
},
9090
"engines": {
9191
"node": ">= 14.16"

packages/gizmo/tsconfig.json

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
11
{
22
"extends": "@repobuddy/typescript/tsconfig/monorepo",
33
"compilerOptions": {
4+
"skipLibCheck": true,
45
"target": "es2022",
56
"lib": ["ES2022", "ESNext.Disposable", "DOM"],
67
"outDir": "esm",

0 commit comments

Comments
 (0)