testscript: Test that setting a function ID in a BDF fails

We need a negative test that shows, that adding a function ID when
entering a BDF result in libvirt generating a failure and CHV not
crashing.

Signed-off-by: Pascal Scholz <[email protected]>
On-behalf-of: SAP [email protected]

Author: scholzp

tests/common.nix

@@ -25,6 +25,8 @@ let
       serial ? "pty",
       # Whether all device will be assigned a static BDF through the XML or only some
       all_static_bdf ? false,
+      # Whether we add a function ID to specific BDFs or not
+      use_bdf_function ? false,
     }:
     ''
       <domain type='kvm' id='21050'>
@@ -134,9 +136,14 @@ let
             ${
               # Assign a fixed BDF that would normally be acquired by the implicit RNG device
               if all_static_bdf then
-                ''
-                  <address type='pci' domain='0x0000' bus='0x00' slot='0x01' function='0x0'/>
-                ''
+                if use_bdf_function then
+                  ''
+                    <address type='pci' domain='0x0000' bus='0x00' slot='0x01' function='0x1'/>
+                  ''
+                else
+                  ''
+                    <address type='pci' domain='0x0000' bus='0x00' slot='0x01' function='0x0'/>
+                  ''
               else
                 ""
             }
@@ -495,6 +502,14 @@ in
             })}";
           };
         };
+        "/etc/domain-chv-static-bdf-with-function.xml" = {
+          "C+" = {
+            argument = "${pkgs.writeText "domain-chv-static-bdf-with-function.xml" (virsh_ch_xml {
+              all_static_bdf = true;
+              use_bdf_function = true;
+            })}";
+          };
+        };
         "/etc/new_interface.xml" = {
           "C+" = {
             argument = "${pkgs.writeText "new_interface.xml" (new_interface { })}";

tests/testscript.py

@@ -1793,6 +1793,29 @@ def test_bdf_invalid_device_id(self):
         )
         assert number_of_devices(controllerVM) == num_before_expected_failure
 
+    def test_bdf_valid_device_id_with_function_id(self):
+        """
+        Test that a BDFs containing a function ID leads to errors.
+        """
+        # We don't support multi function devices currently
+        controllerVM.fail("virsh define /etc/domain-chv-static-bdf-with-function.xml")
+        # Using define + start creates a "persistent" domain rather than a transient
+        controllerVM.succeed("virsh define /etc/domain-chv.xml")
+        controllerVM.succeed("virsh start testvm")
+
+        assert wait_for_ssh(controllerVM)
+
+        num_before_expected_failure = number_of_devices(controllerVM)
+        # Add a persistent disk.
+        controllerVM.succeed(
+            "qemu-img create -f raw /var/lib/libvirt/storage-pools/nfs-share/vdb.img 5M"
+        )
+        # Attach to BDF 0:04.0
+        controllerVM.wait_until_fails(
+            "virsh attach-disk --domain testvm --target vdb --source /var/lib/libvirt/storage-pools/nfs-share/vdb.img --persistent --address pci:0.0.1f.5"
+        )
+        assert number_of_devices(controllerVM) == num_before_expected_failure
+
 
 def suite():
     # Test cases in alphabetical order
@@ -1801,6 +1824,7 @@ def suite():
         LibvirtTests.test_bdf_explicit_assignment,
         LibvirtTests.test_bdf_implicit_assignment,
         LibvirtTests.test_bdf_invalid_device_id,
+        LibvirtTests.test_bdf_valid_device_id_with_function_id,
         LibvirtTests.test_disk_is_locked,
         LibvirtTests.test_disk_resize_qcow2,
         LibvirtTests.test_disk_resize_raw,