refactor: linter

Author: cybex-dev

example/lib/api.dart

@@ -4,6 +4,8 @@ import 'package:http/http.dart' as http;
 
 import 'package:cloud_functions/cloud_functions.dart';
 
+import 'utils.dart';
+
 class Result {
   final String identity;
   final String accessToken;
@@ -20,23 +22,23 @@ class Result {
 ///  "token": "ey...",
 /// }
 Future<Result?> generateLocalAccessToken() async {
-  print("voip-registering with token ");
-  print("GET http://localhost:3000/token");
+  printDebug("voip-registering with token ");
+  printDebug("GET http://localhost:3000/token");
 
   final uri = Uri.http("localhost:3000", "/token");
   final result = await http.get(uri);
   if (result.statusCode >= 200 && result.statusCode < 300) {
-    print("Error requesting token from server [${uri.toString()}]");
-    print(result.body);
+    printDebug("Error requesting token from server [${uri.toString()}]");
+    printDebug(result.body);
     return null;
   }
   final data = jsonDecode(result.body);
   final identity = data["identity"] as String?;
   final token = data["token"] as String?;
 
   if (identity == null || token == null) {
-    print("Error requesting token from server [${uri.toString()}]");
-    print(result.body);
+    printDebug("Error requesting token from server [${uri.toString()}]");
+    printDebug(result.body);
     return null;
   }
   return Result(identity, token);
@@ -51,8 +53,8 @@ Future<Result?> generateLocalAccessToken() async {
 /// }
 ///
 Future<Result?> generateFirebaseAccessToken() async {
-  print("voip-registtering with token ");
-  print("voip-calling voice-accessToken");
+  printDebug("voip-registtering with token ");
+  printDebug("voip-calling voice-accessToken");
   final function = FirebaseFunctions.instance.httpsCallable("voice-accessToken");
 
   final params = {
@@ -67,8 +69,8 @@ Future<Result?> generateFirebaseAccessToken() async {
   final token = data["token"] as String?;
 
   if (identity == null || token == null) {
-    print("Error requesting token from server [${function.toString()}]");
-    print(result.data);
+    printDebug("Error requesting token from server [${function.toString()}]");
+    printDebug(result.data);
     return null;
   }
   return Result(identity, token);

example/lib/main.dart

@@ -11,6 +11,7 @@ import 'package:twilio_voice_example/screens/ui_call_screen.dart';
 import 'package:twilio_voice_example/screens/ui_registration_screen.dart';
 
 import 'api.dart';
+import 'utils.dart';
 
 extension IterableExtension<E> on Iterable<E> {
   /// Extension on [Iterable]'s [firstWhere] that returns null if no element is found instead of throwing an exception.
@@ -42,7 +43,7 @@ void main() async {
   WidgetsFlutterBinding.ensureInitialized();
   if (kIsWeb) {
     // Add firebase config here
-    final options = const FirebaseOptions(
+    const options = FirebaseOptions(
       apiKey: '',
       appId: '',
       messagingSenderId: '',
@@ -86,7 +87,7 @@ class _AppState extends State<App> {
 
   //#region #region Register with Twilio
   void register() async {
-    print("voip-service registration");
+    printDebug("voip-service registration");
 
     // Use for locally provided token generator e.g. Twilio's quickstarter project: https://github.com/twilio/voice-quickstart-server-node
     if (!kIsWeb) {
@@ -116,12 +117,12 @@ class _AppState extends State<App> {
 
   /// Registers [accessToken] with TwilioVoice plugin, acquires a device token from FirebaseMessaging and registers with TwilioVoice plugin.
   Future<bool> _registerAccessToken(String accessToken) async {
-    print("voip-registering access token");
+    printDebug("voip-registering access token");
 
     String? androidToken;
     if (Platform.isAndroid || kIsWeb) {
       androidToken = await FirebaseMessaging.instance.getToken();
-      print("androidToken is " + androidToken!);
+      printDebug("androidToken is ${androidToken!}");
     }
     final result = await TwilioVoice.instance.setTokens(accessToken: accessToken, deviceToken: androidToken);
     return result ?? false;
@@ -141,9 +142,9 @@ class _AppState extends State<App> {
     if (myId.isEmpty) myId = null;
     if (myToken.isEmpty) myToken = null;
 
-    print("voip-registering with environment variables");
+    printDebug("voip-registering with environment variables");
     if (myId == null || myToken == null) {
-      print("Failed to register with environment variables, please provide ID and TOKEN");
+      printDebug("Failed to register with environment variables, please provide ID and TOKEN");
       return false;
     }
     userId = myId;
@@ -165,10 +166,10 @@ class _AppState extends State<App> {
   /// Use this method to register with a local token generator
   /// To access this, run with `--dart-define=REGISTRATION_METHOD=local`
   Future<bool> _registerLocal() async {
-    print("voip-registering with local token generator");
+    printDebug("voip-registering with local token generator");
     final result = await generateLocalAccessToken();
     if (result == null) {
-      print("Failed to register with local token generator");
+      printDebug("Failed to register with local token generator");
       return false;
     }
     userId = result.identity;
@@ -181,9 +182,9 @@ class _AppState extends State<App> {
   void _listenForFirebaseLogin() {
     final auth = FirebaseAuth.instance;
     auth.authStateChanges().listen((user) async {
-      // print("authStateChanges $user");
+      // printDebug("authStateChanges $user");
       if (user == null) {
-        print("user is anonomous");
+        printDebug("user is anonomous");
         await auth.signInAnonymously();
       } else if (!authRegistered) {
         authRegistered = true;
@@ -192,7 +193,7 @@ class _AppState extends State<App> {
         if (userId.isEmpty) {
           userId = user.uid;
         }
-        print("registering client $userId [firebase id ${user.uid}]");
+        printDebug("registering client $userId [firebase id ${user.uid}]");
         _registerFirebase();
       }
     });
@@ -205,10 +206,10 @@ class _AppState extends State<App> {
       _listenForFirebaseLogin();
       return false;
     }
-    print("voip-registering with firebase token generator");
+    printDebug("voip-registering with firebase token generator");
     final result = await generateFirebaseAccessToken();
     if (result == null) {
-      print("Failed to register with firebase token generator");
+      printDebug("Failed to register with firebase token generator");
       return false;
     }
     userId = result.identity;
@@ -224,7 +225,7 @@ class _AppState extends State<App> {
     super.initState();
 
     TwilioVoice.instance.setOnDeviceTokenChanged((token) {
-      print("voip-device token changed");
+      printDebug("voip-device token changed");
       if (!kIsWeb) {
         register();
       }
@@ -233,7 +234,7 @@ class _AppState extends State<App> {
     listenForEvents();
     register();
 
-    final partnerId = "alicesId";
+    const partnerId = "alicesId";
     TwilioVoice.instance.registerClient(partnerId, "Alice");
     // TwilioVoice.instance.requestReadPhoneStatePermission();
     // TwilioVoice.instance.requestMicAccess();
@@ -243,7 +244,7 @@ class _AppState extends State<App> {
   /// Listen for call events
   void listenForEvents() {
     TwilioVoice.instance.callEventsListener.listen((event) {
-      print("voip-onCallStateChanged $event");
+      printDebug("voip-onCallStateChanged $event");
 
       switch (event) {
         case CallEvent.incoming:
@@ -260,7 +261,7 @@ class _AppState extends State<App> {
           if (activeCall != null) {
             final customData = activeCall.customParams;
             if (customData != null) {
-              print("voip-customData $customData");
+              printDebug("voip-customData $customData");
             }
           }
           break;
@@ -285,11 +286,11 @@ class _AppState extends State<App> {
   /// Place a call to [clientIdentifier]
   Future<void> _onPerformCall(String clientIdentifier) async {
     if (!await (TwilioVoice.instance.hasMicAccess())) {
-      print("request mic access");
+      printDebug("request mic access");
       TwilioVoice.instance.requestMicAccess();
       return;
     }
-    print("starting call to $clientIdentifier");
+    printDebug("starting call to $clientIdentifier");
     TwilioVoice.instance.call.place(to: clientIdentifier, from: userId, extraOptions: {"_TWI_SUBJECT": "Company Name"});
   }
 
@@ -341,19 +342,19 @@ class _AppState extends State<App> {
     final activeCall = TwilioVoice.instance.call.activeCall!;
     final action = await showIncomingCallScreen(context, activeCall);
     if (action == true) {
-      print("accepting call");
+      printDebug("accepting call");
       TwilioVoice.instance.call.answer();
     } else if (action == false) {
-      print("rejecting call");
+      printDebug("rejecting call");
       TwilioVoice.instance.call.hangUp();
     } else {
-      print("no action");
+      printDebug("no action");
     }
   }
 
   Future<bool?> showIncomingCallScreen(BuildContext context, ActiveCall activeCall) async {
     if (!kIsWeb && !Platform.isAndroid) {
-      print("showIncomingCallScreen only for web");
+      printDebug("showIncomingCallScreen only for web");
       return false;
     }
 

example/lib/screens/widgets/on_call_widget.dart

@@ -116,7 +116,7 @@ class _CallSID extends StatelessWidget {
 class _StatusIcon extends StatelessWidget {
   final bool active;
 
-  const _StatusIcon({super.key, required this.active});
+  const _StatusIcon({required this.active});
 
   @override
   Widget build(BuildContext context) {

example/lib/screens/widgets/permissions_block.dart

@@ -2,12 +2,13 @@ import 'dart:async';
 import 'dart:io';
 
 import 'package:firebase_messaging/firebase_messaging.dart';
-import 'package:flutter/foundation.dart';
 import 'package:flutter/material.dart';
 import 'package:twilio_voice/twilio_voice.dart';
 import 'package:twilio_voice_example/screens/widgets/permission_tile.dart';
 import 'package:twilio_voice_example/screens/widgets/state_toggle.dart';
 
+import '../../utils.dart';
+
 class PermissionsBlock extends StatefulWidget {
   const PermissionsBlock({super.key});
 
@@ -119,7 +120,7 @@ class _PermissionsBlockState extends State<PermissionsBlock> with WidgetsBinding
 
   @override
   void didChangeAppLifecycleState(AppLifecycleState state) {
-    print("AppLifecycleState: $state");
+    printDebug("AppLifecycleState: $state");
     if(_lastLifecycleState != state && state == AppLifecycleState.resumed) {
       _updatePermissions();
     }
@@ -322,7 +323,7 @@ class _PermissionsBlockState extends State<PermissionsBlock> with WidgetsBinding
                   title: "Phone Account",
                   granted: _hasRegisteredPhoneAccount,
                   onRequestPermission: () async {
-                    final result = await _tv.registerPhoneAccount();
+                    await _tv.registerPhoneAccount();
                     setPhoneAccountRegistered = await _tv.hasRegisteredPhoneAccount();
                   },
                 ),
@@ -337,7 +338,7 @@ class _PermissionsBlockState extends State<PermissionsBlock> with WidgetsBinding
                   subtitle: Text(_hasRegisteredPhoneAccount ? (_isPhoneAccountEnabled ? "Enabled" : "Not Enabled") : "Not Registered"),
                   trailing: ElevatedButton(
                     onPressed: _hasRegisteredPhoneAccount && !_isPhoneAccountEnabled ? () => _tv.openPhoneAccountSettings() : null,
-                    child: Text("Open Settings"),
+                    child: const Text("Open Settings"),
                   ),
                 ),
             ],

example/lib/utils.dart

@@ -0,0 +1,7 @@
+import 'package:flutter/foundation.dart';
+
+void printDebug(String message) {
+  if (kDebugMode) {
+    print(message);
+  }
+}

lib/_internal/js/core/promise.dart

@@ -4,9 +4,8 @@ import 'package:js/js.dart';
 
 @JS()
 abstract class Promise<T> {
-  external factory Promise(
-      void executor(void resolve(T result), Function reject));
-  external Promise then(void onFulfilled(T result), [Function onRejected]);
+  external factory Promise(void Function(Function(T result) resolve, Function reject) executor);
+  external Promise then(void Function(T result) onFulfilled, [Function onRejected]);
 }
 
 Future<Map<String, dynamic>> parsePromise(Promise<dynamic> promise) async {

lib/_internal/js/utils/js_object_utils.dart

@@ -1,14 +1,6 @@
 import 'package:js/js.dart';
 import 'package:js/js_util.dart';
 
-/// A workaround to converting an object from JS to a Dart Map.
-Map jsToMap(jsObject) {
-  return new Map.fromIterable(
-    objectKeys(jsObject),
-    value: (key) => getProperty(jsObject, key),
-  );
-}
-
 Map<String, String> jsToStringMap(dynamic jsonObject) {
   final map = <String, String>{};
   final keys = objectKeys(jsonObject);

lib/_internal/method_channel/twilio_call_method_channel.dart

@@ -26,7 +26,7 @@ class MethodChannelTwilioCall extends TwilioCallPlatform {
   Future<bool?> place({required String from, required String to, Map<String, dynamic>? extraOptions}) {
     _activeCall = ActiveCall(from: from, to: to, callDirection: CallDirection.outgoing);
 
-    var options = extraOptions ?? Map<String, dynamic>();
+    var options = extraOptions ?? <String, dynamic>{};
     options['From'] = from;
     options['To'] = to;
     return _channel.invokeMethod('makeCall', options);
@@ -65,6 +65,7 @@ class MethodChannelTwilioCall extends TwilioCallPlatform {
   }
 
   /// Query's active call holding state
+  @override
   Future<bool?> isHolding() {
     return _channel.invokeMethod('isHolding', <String, dynamic>{});
   }
@@ -76,6 +77,7 @@ class MethodChannelTwilioCall extends TwilioCallPlatform {
   }
 
   /// Query's mute status of call, true if call is muted
+  @override
   Future<bool?> isMuted() {
     return _channel.invokeMethod('isMuted', <String, dynamic>{});
   }
@@ -92,6 +94,7 @@ class MethodChannelTwilioCall extends TwilioCallPlatform {
   }*/
 
   /// Query's speaker output status, true if on loud speaker.
+  @override
   Future<bool?> isOnSpeaker() {
     return _channel.invokeMethod('isOnSpeaker', <String, dynamic>{});
   }