Merge pull request #233 from agent515/fix-null-custom-params-in-active-call-on-answer

cybex-dev · web-flow · commit 8897efbd1710 · 2025-03-19T20:43:41.000+02:00
Add Call Direction in sendPhoneCallEvents description to fix customPa…
diff --git a/android/src/main/kotlin/com/twilio/twilio_voice/TwilioVoicePlugin.kt b/android/src/main/kotlin/com/twilio/twilio_voice/TwilioVoicePlugin.kt
@@ -1735,7 +1735,7 @@ class TwilioVoicePlugin : FlutterPlugin, MethodCallHandler, EventChannel.StreamH
                     }
                 }.toString()
 //                callSid = callHandle
-                logEvents("", arrayOf("Answer", from, to, params))
+                logEvents("", arrayOf("Answer", from, to, CallDirection.INCOMING.label, params))
             }
 
             TVNativeCallActions.ACTION_DTMF -> {
diff --git a/ios/Classes/SwiftTwilioVoicePlugin.swift b/ios/Classes/SwiftTwilioVoicePlugin.swift
@@ -955,7 +955,7 @@ public class SwiftTwilioVoicePlugin: NSObject, FlutterPlugin,  FlutterStreamHand
             }
             self.sendPhoneCallEvents(description: "LOG|performAnswerVoiceCall: answering call", isError: false)
             let theCall = ci.accept(options: acceptOptions, delegate: self)
-            self.sendPhoneCallEvents(description: "Answer|\(theCall.from!)|\(theCall.to!)\(formatCustomParams(params: ci.customParameters))", isError:false)
+            self.sendPhoneCallEvents(description: "Answer|\(theCall.from!)|\(theCall.to!)|Incoming\(formatCustomParams(params: ci.customParameters))", isError:false)
             self.call = theCall
             self.callKitCompletionCallback = completionHandler
             self.callInvite = nil

Original file line number	Diff line number	Diff line change
`@@ -1735,7 +1735,7 @@ class TwilioVoicePlugin : FlutterPlugin, MethodCallHandler, EventChannel.StreamH`
`1735`	`1735`	`}`
`1736`	`1736`	`}.toString()`
`1737`	`1737`	`// callSid = callHandle`
`1738`		`- logEvents("", arrayOf("Answer", from, to, params))`
	`1738`	`+ logEvents("", arrayOf("Answer", from, to, CallDirection.INCOMING.label, params))`
`1739`	`1739`	`}`
`1740`	`1740`
`1741`	`1741`	`TVNativeCallActions.ACTION_DTMF -> {`
Original file line number	Diff line number	Diff line change
`@@ -955,7 +955,7 @@ public class SwiftTwilioVoicePlugin: NSObject, FlutterPlugin, FlutterStreamHand`
`955`	`955`	`}`
`956`	`956`	`self.sendPhoneCallEvents(description: "LOG\|performAnswerVoiceCall: answering call", isError: false)`
`957`	`957`	`let theCall = ci.accept(options: acceptOptions, delegate: self)`
`958`		`- self.sendPhoneCallEvents(description: "Answer\|\(theCall.from!)\|\(theCall.to!)\(formatCustomParams(params: ci.customParameters))", isError:false)`
	`958`	`+ self.sendPhoneCallEvents(description: "Answer\|\(theCall.from!)\|\(theCall.to!)\|Incoming\(formatCustomParams(params: ci.customParameters))", isError:false)`
`959`	`959`	`self.call = theCall`
`960`	`960`	`self.callKitCompletionCallback = completionHandler`
`961`	`961`	`self.callInvite = nil`