Skip to content

Commit cd707b7

Browse files
committed
Use priority name parameter resolution
1 parent 6d745b7 commit cd707b7

File tree

1 file changed

+36
-27
lines changed

1 file changed

+36
-27
lines changed

android/src/main/kotlin/com/twilio/twilio_voice/call/TVParametersImpl.kt

Lines changed: 36 additions & 27 deletions
Original file line numberDiff line numberDiff line change
@@ -23,29 +23,34 @@ class TVCallInviteParametersImpl(storage: Storage, callInvite: CallInvite) : TVP
2323
return mStorage.defaultCaller
2424
}
2525

26-
if (!mFrom.startsWith("client:")) {
27-
// we have a number, return as is
28-
return mFrom
29-
}
30-
31-
val mToName = mFrom.replace("client:", "")
3226
return customParameters[PARAM_CALLER_NAME]
3327
?: customParameters[PARAM_CALLER_ID]?.let { resolveHumanReadableName(it) }
34-
?: resolveHumanReadableName(mToName)
28+
?: run {
29+
if (!mFrom.startsWith("client:")) {
30+
// we have a number, return as is
31+
return mFrom
32+
}
33+
34+
val mToName = mFrom.replace("client:", "")
35+
return resolveHumanReadableName(mToName)
36+
}
3537
}
3638

3739
override val to: String
3840
get() {
3941
val mTo = mCallInvite.to
40-
if (!mTo.startsWith("client:")) {
41-
// we have a number, return as is
42-
return mTo
43-
}
4442

45-
val mToName = mTo.replace("client:", "")
4643
return customParameters[PARAM_RECIPIENT_NAME]
4744
?: customParameters[PARAM_RECIPIENT_ID]?.let { resolveHumanReadableName(it) }
48-
?: resolveHumanReadableName(mToName)
45+
?: run {
46+
if (!mTo.startsWith("client:")) {
47+
// we have a number, return as is
48+
return mTo
49+
}
50+
51+
val mToName = mTo.replace("client:", "")
52+
return resolveHumanReadableName(mToName)
53+
}
4954
}
5055

5156
override val fromRaw: String
@@ -87,15 +92,17 @@ class TVCallParametersImpl(storage: Storage, call: Call, callTo: String, callFro
8792
return mStorage.defaultCaller
8893
}
8994

90-
if (!mFrom.startsWith("client:")) {
91-
// we have a number, return as is
92-
return mFrom
93-
}
94-
95-
val mFromName = mFrom.replace("client:", "")
9695
return customParameters[PARAM_CALLER_NAME]
9796
?: customParameters[PARAM_CALLER_ID]?.let { resolveHumanReadableName(it) }
98-
?: resolveHumanReadableName(mFromName)
97+
?: run {
98+
if (!mFrom.startsWith("client:")) {
99+
// we have a number, return as is
100+
return mFrom
101+
}
102+
103+
val mFromName = mFrom.replace("client:", "")
104+
return resolveHumanReadableName(mFromName)
105+
}
99106
}
100107

101108
override val to: String
@@ -104,15 +111,17 @@ class TVCallParametersImpl(storage: Storage, call: Call, callTo: String, callFro
104111
return mStorage.defaultCaller
105112
}
106113

107-
if (!mTo.startsWith("client:")) {
108-
// we have a number, return as is
109-
return mTo
110-
}
111-
112-
val mToName = mTo.replace("client:", "")
113114
return customParameters[PARAM_RECIPIENT_NAME]
114115
?: customParameters[PARAM_RECIPIENT_ID]?.let { resolveHumanReadableName(it) }
115-
?: resolveHumanReadableName(mToName)
116+
?: run {
117+
if (!mTo.startsWith("client:")) {
118+
// we have a number, return as is
119+
return mTo
120+
}
121+
122+
val mToName = mTo.replace("client:", "")
123+
return resolveHumanReadableName(mToName)
124+
}
116125
}
117126

118127
override val fromRaw: String

0 commit comments

Comments
 (0)