Skip to content

Commit e8d6931

Browse files
fix: ringing & connected events in new sdk
1 parent ba93ec4 commit e8d6931

File tree

2 files changed

+10
-2
lines changed

2 files changed

+10
-2
lines changed

macos/Classes/JsInterop/Call/TVCall.swift

Lines changed: 8 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -146,7 +146,7 @@ public class TVCall: JSObject, TVCallDelegate, JSMessageHandlerDelegate {
146146
/// - SeeAlso Twilio [Call.Events](https://www.twilio.com/docs/voice/sdks/javascript/twiliocall#events)
147147
func attachEventListeners() {
148148
print("Attaching event listeners to [TVCall]")
149-
let events: [TVCallEvent] = [.accept, .cancel, .disconnect, .error, .reconnected, .reconnected, .reject, .status]
149+
let events: [TVCallEvent] = [.accept, .cancel, .disconnect, .error, .reconnecting, .reconnected, .reject, .ringing, .connected, .status]
150150
events.map {
151151
$0.rawValue
152152
}
@@ -168,7 +168,7 @@ public class TVCall: JSObject, TVCallDelegate, JSMessageHandlerDelegate {
168168
print("Detaching event listeners from [TVCall]")
169169
detachMessageHandler()
170170
return;
171-
let events: [TVCallEvent] = [.accept, .cancel, .disconnect, .error, .reconnected, .reconnected, .reject, .status]
171+
let events: [TVCallEvent] = [.accept, .cancel, .disconnect, .error, .reconnecting, .reconnected, .reject, .ringing, .connected, .status]
172172
events.map {
173173
$0.rawValue
174174
}
@@ -300,6 +300,12 @@ public class TVCall: JSObject, TVCallDelegate, JSMessageHandlerDelegate {
300300
case .reject:
301301
onCallReject()
302302
break
303+
case .ringing:
304+
onCallStatus(.ringing)
305+
break
306+
case .connected:
307+
onCallStatus(.connected)
308+
break
303309
case .status:
304310
if (message.args.count > 0) {
305311
let status = message.args[0] as? String

macos/Classes/JsInterop/Call/Types/TVCallEvent.swift

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,8 @@ public enum TVCallEvent: String {
1313
case reconnecting = "reconnecting"
1414
case reject = "reject"
1515
case status = "status"
16+
case ringing = "ringing"
17+
case connected = "connected"
1618
// case sample = "sample"
1719
// case warning = "warning"
1820
// case warningCleared = "warningCleared"

0 commit comments

Comments
 (0)