improve update notification; fix getting scan client

Author: MarshalX

cycode/cli/apps/auth/auth_common.py

@@ -13,7 +13,10 @@
 def get_authorization_info(ctx: 'Context') -> Optional[AuthInfo]:
     printer = ctx.obj.get('console_printer')
 
-    client_id, client_secret = CredentialsManager().get_credentials()
+    client_id, client_secret = ctx.obj.get('client_id'), ctx.obj.get('client_secret')
+    if not client_id or not client_secret:
+        client_id, client_secret = CredentialsManager().get_credentials()
+
     if not client_id or not client_secret:
         return None
 

cycode/cli/utils/get_api_client.py

@@ -28,7 +28,7 @@ def _get_cycode_client(
 def get_scan_cycode_client(ctx: 'typer.Context') -> 'ScanClient':
     client_id = ctx.obj.get('client_id')
     client_secret = ctx.obj.get('client_secret')
-    hide_response_log = not ctx.obj['show_secret']
+    hide_response_log = not ctx.obj.get('show_secret', False)
     return _get_cycode_client(create_scan_client, client_id, client_secret, hide_response_log)
 
 

cycode/cli/utils/version_checker.py

@@ -86,7 +86,9 @@ def get_latest_version(self) -> Optional[str]:
 
         """
         try:
-            response = self.get(f'{self.PYPI_PACKAGE_NAME}/json', timeout=self.PYPI_REQUEST_TIMEOUT)
+            response = self.get(
+                f'{self.PYPI_PACKAGE_NAME}/json', timeout=self.PYPI_REQUEST_TIMEOUT, hide_response_content_log=True
+            )
             data = response.json()
             return data.get('info', {}).get('version')
         except Exception:
@@ -203,10 +205,10 @@ def check_and_notify_update(self, current_version: str, use_cache: bool = True)
         should_update = bool(latest_version)
         if should_update:
             update_message = (
-                '\nNew version of cycode available! '
-                f'[yellow]{current_version}[/] → [bright_blue]{latest_version}[/]\n'
+                '\nNew release of Cycode CLI is available: '
+                f'[red]{current_version}[/] -> [green]{latest_version}[/]\n'
                 f'Changelog: [bright_blue]{self.GIT_CHANGELOG_URL_PREFIX}{latest_version}[/]\n'
-                f'Run [green]pip install --upgrade cycode[/] to update\n'
+                f'To update, run: [green]pip install --upgrade cycode[/]\n'
             )
             console.print(update_message)
 

tests/cli/commands/test_check_latest_version_on_close.py

@@ -10,7 +10,7 @@
 from tests.conftest import CLI_ENV_VARS
 
 _NEW_LATEST_VERSION = '999.0.0'  # Simulate a newer version available
-_UPDATE_MESSAGE_PART = 'new version of cycode available'
+_UPDATE_MESSAGE_PART = 'new release of cycode cli is available'
 
 
 @patch.object(VersionChecker, 'check_for_update')