Address review comments.

Author: hjoliver

src/7-to-8/major-changes/compatibility-mode.rst

@@ -33,7 +33,7 @@ The ``suite.rc`` filename triggers a backward compatibility mode in which:
   - (Cylc 8 spawns tasks on demand, and suicide triggers are not needed for
     branching)
 
-- ``succeeded`` task outputs are :ref:`*required* <User Guide Required Outputs>`,
+- ``succeeded`` task outputs are :ref:`required <User Guide Required Outputs>`,
   so in the absence of suicide triggers the scheduler will retain other
   :term:`final status` tasks in the :term:`n=0 window <n-window>` to stall the
   workflow.

src/glossary.rst

@@ -106,11 +106,11 @@ Glossary
    window
    n-window
    active window
-      The UI provides a :term:`graph`-based window or view of the workflow at
+      The GUI provides a :term:`graph`-based window or view of the workflow at
       runtime, including tasks out to ``n`` graph edges from current
       :term:`active tasks <active task>`.
 
-      Active tasks form the ``n=0`` core of the :term:`n-window`.
+      Active tasks form the ``n=0``` window.
 
       .. seealso::
 
@@ -1383,17 +1383,6 @@ Glossary
       - ``:succeeded``, or ``:failed``
 
 
-   prerequisite
-   task prerequisite
-      A task's prerequisites are the :term:`outputs <task output>` of
-      parent tasks upstream in the graph that must be completed before
-      it can run. Tasks are said to "depend on" their prerequisites, hence
-      the term :term:`dependency graph <graph>`.
-
-      Tasks can depend on :term:`external triggers <xtrigger>` as well as
-      the outputs of other, upstream, tasks.
-
-
    output
    task output
       Task outputs mark the progression of a :term:`task` from waiting (for
@@ -1426,8 +1415,9 @@ Glossary
       A task's outputs are *complete* if its *output completion condition* 
       is satisfied.
 
-      The completion condition can be defined by the user, or otherwise
-      it is automatically generated according to the rules:
+      The completion condition can be defined by the user in
+      :cylc:conf:`flow.cylc[runtime][<namespace>]completion`,
+      otherwise it is automatically generated according to the rules:
 
       - All :term:`required outputs <required output>` (referenced in the graph)
         must be completed.
@@ -1444,10 +1434,13 @@ Glossary
       the workflow.
 
 
+   prerequisite
    dependence
    dependency
       Dependencies in the :term:`graph` show how :term:`tasks <task>` depend on
       some combination of the :term:`outputs <task output>` of other tasks.
+      These dependencies are also called the prerequisites of the downstream.
+      task.
 
       For example, in the following dependency the task ``baz`` depends on both
       ``foo`` and ``bar`` succeeding:
@@ -1462,6 +1455,8 @@ Glossary
           * :term:`conditional dependence`
           * :term:`intercycle dependence`
 
+      Tasks can also depend on :term:`external triggers <xtrigger>`.
+
 
    conditional dependence
    conditional dependency

src/user-guide/running-workflows/workflow-completion.rst

@@ -3,19 +3,19 @@
 Workflow Completion
 ===================
 
-   A workflow is complete, and the scheduler will automatically
-   :term:`shut down <shutdown>`, if no tasks remain in the
-   :term:`n=0 <n-window>`.
-
-   That is, all active tasks have finished, and no tasks remain waiting on
-   :term:`prerequisites <prerequisite>` or "external" constraints (such as
-   :term:`xtriggers <xtrigger>` or task :term:`hold`).
-
-   If no active tasks remain and all external constraints are satisfied,
-   but the n=0 window contains tasks waiting with partially satisfied
-   :term:`prerequisites <prerequisite>`, or tasks with :term:`final status` and
-   :term:`incomplete outputs <output completion>`, then the workflow is
-   not complete and the scheduler will :term:`stall` pending manual intervention.
+A workflow is complete, and the scheduler will automatically
+:term:`shut down <shutdown>`, if no tasks remain in the
+:term:`n=0 <n-window>`.
+
+That is, all active tasks have finished, and no tasks remain waiting on
+:term:`prerequisites <prerequisite>` or "external" constraints (such as
+:term:`xtriggers <xtrigger>` or task :term:`hold`).
+
+If no active tasks remain and all external constraints are satisfied,
+but the n=0 window contains tasks waiting with partially satisfied
+:term:`prerequisites <prerequisite>`, or tasks with :term:`final status` and
+:term:`incomplete outputs <output completion>`, then the workflow is
+not complete and the scheduler will :term:`stall` pending manual intervention.
 
 
 .. _scheduler stall:

src/user-guide/writing-workflows/external-triggers.rst

@@ -170,8 +170,8 @@ this:
        'task': task_name,
        'point': cycle_point,
        'status': task_status,  # or
-	   'trigger': task_output_trigger,  # or
-	   'message': task_output_message,
+       'trigger': task_output_trigger,  # or
+       'message': task_output_message,
        'flow_num': flow_num  # if given
    }
    return (satisfied, results)
@@ -193,8 +193,8 @@ To see this, take a look at the job script for one of the downstream tasks:
        export upstream_workflow upstream_cylc_run_dir upstream_offset \
          upstream_message upstream_status upstream_point upstream_task
        upstream_workflow="up"
-	   upstream_task="foo"
-	   upstream_point="2011"
+       upstream_task="foo"
+       upstream_point="2011"
        upstream_status="succeeded"
    }
    ...
@@ -398,7 +398,6 @@ success. The function signature is:
 .. automodule:: cylc.flow.xtriggers.xrandom
    :members: xrandom, validate
    :member-order: bysource
-   :noindex:
 
 An example xrandom trigger workflow:
 

src/user-guide/writing-workflows/scheduling.rst

@@ -1560,7 +1560,7 @@ intervention, e.g. to be retriggered after a bug fix.
    Tasks that achieve a final status without completing their outputs will
    raise a warning and stall the workflow when there is nothing else for
    the scheduler to run (see :ref:`workflow completion`). They also count
-   toward the :term:`runahead limit`, because they may run again once dealt with.
+   toward the :term:`runahead limit`.
 
 This graph says task ``bar`` should trigger if ``foo`` succeeds:
 

src/workflows/xtrigger/sequential/flow.cylc

@@ -4,7 +4,7 @@
     initial cycle point = 2010
     sequential xtriggers = True
     [[xtriggers]]
-         upstream = workflow_state(up//%(point)s/foo:x):PT10S
+         upstream = workflow_state("up//%(point)s/foo:x"):PT10S
          clock_0 = wall_clock(offset=PT0H, sequential=False)
    [[graph]]
         P1Y = """

src/workflows/xtrigger/workflow_state/downstream/flow.cylc

@@ -3,7 +3,7 @@
 [scheduling]
     initial cycle point = 2010
     [[xtriggers]]
-         upstream = workflow_state(up//%(point)s/foo:x):PT10S
+         upstream = workflow_state("up//%(point)s/foo:x"):PT10S
          clock_0 = wall_clock(offset=PT0H)
    [[graph]]
         P1Y = """