Skip to content

Commit d915abd

Browse files
hjoliverwxtim
andauthored
Apply suggestions from code review
Co-authored-by: Tim Pillinger <[email protected]>
1 parent 64d70bb commit d915abd

File tree

3 files changed

+10
-7
lines changed

3 files changed

+10
-7
lines changed

src/glossary.rst

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -69,7 +69,7 @@ Glossary
6969
don't get overwritten.
7070

7171
active task
72-
Active tasks are those tasks currently held in working memory to feed
72+
Active tasks are those tasks held in memory to feed
7373
the scheduling algorithm. They form the ``n=0`` :term:`n-window`,
7474
so are always visible in the GUI.
7575

src/user-guide/running-workflows/tasks-jobs-ui.rst

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -109,7 +109,7 @@ extent for :term:`cycling workflows <cycling workflow>` with no
109109
:term:`final cycle point`.
110110

111111
Consequently the GUI often can't display "all of the tasks" at once. Instead
112-
it displays all tasks a configurable :term:`n-window` around the current
112+
it displays all tasks in a configurable :term:`n-window` around the current
113113
:term:`active tasks <active task>`.
114114

115115
.. image:: ../../img/n-window.png
@@ -118,7 +118,7 @@ it displays all tasks a configurable :term:`n-window` around the current
118118

119119
n=0:
120120
The ``n=0`` window contains current :term:`active tasks <active task>`: those
121-
that are near ready to run, running, or which require user intervention.
121+
that are near ready to run, running, or which may require user intervention.
122122
n=1:
123123
The ``n=1`` window contains the ``n=0`` tasks plus those out
124124
to *one* graph edge around them in the graph.

src/user-guide/running-workflows/workflow-completion.rst

Lines changed: 7 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -12,10 +12,13 @@ downstream activity - i.e., when :term:`n=0 window <n-window>` empties out.
1212
Scheduler Stall
1313
===============
1414

15-
If there are no tasks waiting on as yet unsatisfied external constraints
16-
such clock and xtriggers, and all activity has ceased but workflow has
17-
not :ref:`run to completion <workflow completion>`, then it
18-
has stalled and requires manual intervention to continue.
15+
A workflow has stalled if:
16+
17+
* No tasks are waiting on unstatisfied external events, like clock triggers and xtriggers.
18+
* AND All activity has ceased.
19+
* AND The workflow has not run to completion.
20+
21+
A workflow which has stalled requires manual intervention to continue.
1922

2023
Stalls are caused by :term:`final status incomplete tasks <output completion>`
2124
and :term:`partially satisfied tasks <prerequisite>`.

0 commit comments

Comments
 (0)