Skip to content

Update for UI sidebar task state badges#882

Merged
oliver-sanders merged 2 commits intocylc:masterfrom
MetRonnie:update-screenshots
Nov 28, 2025
Merged

Update for UI sidebar task state badges#882
oliver-sanders merged 2 commits intocylc:masterfrom
MetRonnie:update-screenshots

Conversation

@MetRonnie
Copy link
Member

For cylc/cylc-ui#2331

Requirements check-list

  • I have read CONTRIBUTING.md and added my name as a Code Contributor.

@MetRonnie MetRonnie added this to the 8.6.x milestone Nov 3, 2025
@MetRonnie MetRonnie self-assigned this Nov 3, 2025
@MetRonnie MetRonnie added content Addition or modification of documentation small labels Nov 3, 2025
@MetRonnie MetRonnie force-pushed the update-screenshots branch 2 times, most recently from a026b19 to 5e33642 Compare November 3, 2025 18:26
@MetRonnie MetRonnie marked this pull request as ready for review November 27, 2025 15:40
@MetRonnie MetRonnie marked this pull request as draft November 27, 2025 15:41
@MetRonnie MetRonnie marked this pull request as ready for review November 28, 2025 11:58
@MetRonnie MetRonnie changed the title Update screenshots Update for UI sidebar task state badges Nov 28, 2025
@MetRonnie
Copy link
Member Author

Just linkcheck failing

Comment on lines +32 to +36
:cylc-flow: `8.6 <https://github.com/cylc/cylc-flow/blob/master/CHANGES.md>`__
:cylc-ui: `2.11 <https://github.com/cylc/cylc-ui/blob/master/CHANGES.md>`__
:cylc-uiserver: `1.8 <https://github.com/cylc/cylc-uiserver/blob/master/CHANGES.md>`__
:cylc-rose: `1.7 <https://github.com/cylc/cylc-rose/blob/master/CHANGES.md>`__
:rose: `2.6 <https://github.com/metomi/rose/blob/master/CHANGES.md>`__
Copy link
Member

@oliver-sanders oliver-sanders Nov 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ach, should have been done at release time.

@wxtim, If not already in the release instructions (quite possible), would you mind adding it.

@MetRonnie, Linking to master with no URL fragment is just linking to the changes file, not the specified section within it. Which isn't really much use as new releases are added to the top.

Suggest either pinning to the branch (as done in earlier releases):

Suggested change
:cylc-flow: `8.6 <https://github.com/cylc/cylc-flow/blob/master/CHANGES.md>`__
:cylc-ui: `2.11 <https://github.com/cylc/cylc-ui/blob/master/CHANGES.md>`__
:cylc-uiserver: `1.8 <https://github.com/cylc/cylc-uiserver/blob/master/CHANGES.md>`__
:cylc-rose: `1.7 <https://github.com/cylc/cylc-rose/blob/master/CHANGES.md>`__
:rose: `2.6 <https://github.com/metomi/rose/blob/master/CHANGES.md>`__
:cylc-flow: `8.6 <https://github.com/cylc/cylc-flow/blob/8.6.x/CHANGES.md>`__
:cylc-ui: `2.11 <https://github.com/cylc/cylc-ui/blob/2.11.x/CHANGES.md>`__
:cylc-uiserver: `1.8 <https://github.com/cylc/cylc-uiserver/blob/1.8.x/CHANGES.md>`__
:cylc-rose: `1.7 <https://github.com/cylc/cylc-rose/blob/1.7.x/CHANGES.md>`__
:rose: `2.6 <https://github.com/metomi/rose/blob/2.6.x/CHANGES.md>`__

Or specifying the URL fragment in the URL, though this would require updating.

@oliver-sanders oliver-sanders merged commit d28c7e6 into cylc:master Nov 28, 2025
1 check passed
@MetRonnie MetRonnie deleted the update-screenshots branch November 28, 2025 15:18
@oliver-sanders
Copy link
Member

Dammit, wrong branch.

@oliver-sanders
Copy link
Member

@MetRonnie, can you either restore your branch, or open a new PR on 8.6.x

@MetRonnie MetRonnie restored the update-screenshots branch November 28, 2025 15:23
@MetRonnie MetRonnie mentioned this pull request Nov 28, 2025
1 task
@MetRonnie
Copy link
Member Author

Sorry just noticed it myself: #889

@oliver-sanders
Copy link
Member

oliver-sanders commented Nov 28, 2025

Np, I should have spotted it!

Will tag the release and deploy the docs once merged.

@MetRonnie MetRonnie deleted the update-screenshots branch November 28, 2025 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

content Addition or modification of documentation small

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants