Merge pull request #6178 from oliver-sanders/tui-exit

oliver-sanders · web-flow · commit 4ec556a3658a · 2024-07-03T13:24:23.000+01:00
tui: prevent hang on shutdown
diff --git a/changes.d/fix.6178.md b/changes.d/fix.6178.md
@@ -0,0 +1 @@
+Fix an issue where Tui could hang when closing.
diff --git a/cylc/flow/tui/app.py b/cylc/flow/tui/app.py
@@ -216,7 +216,10 @@ def updater_subproc(filters, client_timeout):
         yield updater
     finally:
         updater.terminate()
-        p.join()
+        p.join(4)  # timeout of 4 seconds
+        if p.exitcode is None:
+            # updater did not exit within timeout -> kill it
+            p.terminate()
 
 
 class TuiApp:

Original file line number	Diff line number	Diff line change
`@@ -0,0 +1 @@`
	`1`	`+Fix an issue where Tui could hang when closing.`