Skip to content

Commit e96fbb9

Browse files
authored
Apply suggestions from code review [skip ci]
1 parent de7a921 commit e96fbb9

File tree

2 files changed

+2
-3
lines changed

2 files changed

+2
-3
lines changed

cylc/flow/job_runner_mgr.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -373,7 +373,7 @@ def job_kill(self, st_file_path):
373373

374374
@classmethod
375375
def _create_nn(cls, job_file_path):
376-
"""Create NN symbolic link, or remove old job logs if they exist.
376+
"""Create NN symbolic link if necessary, and remove any old job logs.
377377
378378
If NN => 01, remove numbered dirs with submit numbers greater than 01.
379379

tests/integration/test_job_runner_mgr.py

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -88,10 +88,9 @@ async def test_kill_error(one, start, test_dir, capsys, log_filter):
8888
async def test_create_nn_new(one, start, test_dir, capsys, log_filter):
8989
"""Test _create_nn.
9090
91-
It should the NN symlink.
91+
It should create the NN symlink.
9292
"""
9393
async with start(one):
94-
# make it look like the task is running
9594
itask = one.pool.get_tasks()[0]
9695

9796
workflow_job_log_dir = Path(get_workflow_run_job_dir(one.workflow))

0 commit comments

Comments
 (0)