Skip to content

Feat.cylc review #7068

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Feat.cylc review #7068

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 1 addition & 8 deletions cylc/flow/etc/cylc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,7 @@
# for selection using CYLC_VERSION. e.g. ln -s cylc-8.0.1-1 cylc-next
#
# Legacy Cylc 7 and Rose 2019.01 versions can also be installed into environments
# in the ROOT location. The legacy support for rose edit, rosie and cylc review
# in the ROOT location. The legacy support for rose edit and rosie
# requires cylc-7 and rose-2019.01 symlinks to be created to the preferred
# environments.
# e.g. ln -s cylc-7.9.5 cylc-7
Expand Down Expand Up @@ -160,13 +160,6 @@ if [[ ${0##*/} =~ ^ros ]]; then
fi
fi

# Legacy support for cylc review
if [[ ${0##*/} == "cylc" && ${1:-} == "review" && \
! ${CYLC_ENV_NAME:-} =~ ^cylc-7 ]]; then
# Cylc 8: Use Cylc 7 to run "review"
CYLC_HOME="${CYLC_HOME_ROOT}/cylc-7"
fi

if [[ ! -x "${CYLC_HOME}/bin/${0##*/}" ]]; then
echo 1>&2 "ERROR: ${0##*/} not found in ${CYLC_HOME}"
exit 1
Expand Down
3 changes: 0 additions & 3 deletions cylc/flow/scripts/cylc.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -293,9 +293,6 @@ def get_version(long=False):
'cylc set-outputs (cylc 8.0-8.2) has been replaced by cylc set',
'restart':
'cylc run & cylc restart have been replaced by cylc play',
'review':
'cylc review has been removed; the latest Cylc 7 version is forward'
' compatible with Cylc 8.',
'suite-state':
'cylc suite-state has been replaced by cylc workflow-state',
'run':
Expand Down
Loading