ROSE_ORIG_HOST: variable being parsed differently to other variables?

[oliver-sanders]

It looks like #398 has caused problems.

There are now spurious quotes appearing.

This may not be restricted to ROSE_ORIG_HOST and be general to internally generated variables (please confirm this!).

Reproducible Example

./rose-suite.conf

[template variables]
FOO="abc"

./flow.cylc
``ini
#!Jinja2

[meta]
description= """
FOO={{ FOO }}
BAR={{ BAR }}
ROSE_ORIG_HOST={{ ROSE_ORIG_HOST }}
"""

```console
$ cylc install . -n xxx -S BAR='"bcd"'
INSTALLED xxx/run2 from ...
$ cylc view xxx -p
[meta]
    description= """
        FOO=abc
        BAR=bcd
        ROSE_ORIG_HOST="cazldf0000D0.spice.sc.metoffice.gov.uk"
    """

Note, neither FOO (rose-suite.conf) or BAR (CLI) are quoted, however ROSE_ORIG_HOST (internal) is.

The really interesting this is you have to install the workflow to see this issue, working from source, there are no spurious quotes:

$ cylc view -p . -S BAR='"bcd"'
[meta]
    description= """
        FOO=abc
        BAR=bcd
        ROSE_ORIG_HOST=cazldf0000D0.spice.sc.metoffice.gov.uk
    """

This likely pins the issue in the loading of the cylc-install optional config.

[TomekTrzeciak]

This likely pins the issue in the loading of the cylc-install optional config.

I think you're right, it looks like the following conditional might be the culprit - it exempts internal vars from literal_eval:

cylc-rose/cylc/rose/utilities.py

Lines 188 to 192 in a314e9d

	if key not in ['ROSE_ORIG_HOST', 'ROSE_VERSION', 'ROSE_SITE']:
	try:
	plugin_result['template_variables'][key] = (
	parser.literal_eval(value)
	)