Fix table view showing wrong latest job

Author: MetRonnie

src/views/Table.vue

@@ -73,23 +73,13 @@ export default {
     },
     tasks () {
       const ret = []
-      let latestJob
-      let previousJob
       for (const workflow of this.workflows) {
         for (const cycle of workflow.children) {
           for (const task of cycle.children) {
-            latestJob = null
-            previousJob = null
-            if (task.children.length) {
-              latestJob = task.children.slice(-1)[0]
-              if (task.children.length > 1) {
-                previousJob = task.children.slice(-2)[0]
-              }
-            }
             ret.push({
               task,
-              latestJob,
-              previousJob
+              latestJob: task.children[0],
+              previousJob: task.children[1],
             })
           }
         }

tests/unit/views/table.vue.spec.js

@@ -0,0 +1,104 @@
+/**
+ * Copyright (C) NIWA & British Crown (Met Office) & Contributors.
+ *
+ * This program is free software: you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License as published by
+ * the Free Software Foundation, either version 3 of the License, or
+ * (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with this program.  If not, see <http://www.gnu.org/licenses/>.
+ */
+
+import { mount } from '@vue/test-utils'
+import { createStore } from 'vuex'
+import sinon from 'sinon'
+import storeOptions from '@/store/options'
+import Table from '@/views/Table.vue'
+import WorkflowService from '@/services/workflow.service'
+import User from '@/model/User.model'
+
+chai.config.truncateThreshold = 0
+
+const workflows = [
+  {
+    id: '~user/one',
+    children: [
+      {
+        id: '~user/one//1',
+        children: [
+          {
+            id: '~user/one//1/eventually_succeeded',
+            children: [
+              {
+                id: '~user/one//1/eventually_succeeded/3',
+                children: [],
+              },
+              {
+                id: '~user/one//1/eventually_succeeded/2',
+                children: [],
+              },
+              {
+                id: '~user/one//1/eventually_succeeded/1',
+                children: [],
+              },
+            ],
+          },
+          {
+            id: '~user/one//1/failed',
+            children: [
+              {
+                id: '~user/one//1/failed/1',
+                children: [],
+              },
+            ],
+          },
+        ]
+      }
+    ]
+  },
+]
+
+describe('Table view', () => {
+  let store, $workflowService
+  beforeEach(() => {
+    store = createStore(storeOptions)
+    const user = new User('cylc', [], new Date(), true, 'localhost', 'owner')
+    store.commit('user/SET_USER', user)
+    $workflowService = sinon.createStubInstance(WorkflowService)
+  })
+
+  it('computes tasks', async () => {
+    const wrapper = mount(Table, {
+      shallow: true,
+      global: {
+        plugins: [store],
+        mocks: { $workflowService }
+      },
+      props: {
+        workflowName: 'one',
+      },
+      data: () => ({
+        // Override computed property
+        workflows
+      })
+    })
+
+    expect(wrapper.vm.tasks).toMatchObject([
+      {
+        task: { id: '~user/one//1/eventually_succeeded' },
+        latestJob: { id: '~user/one//1/eventually_succeeded/3' },
+        previousJob: { id: '~user/one//1/eventually_succeeded/2' }
+      },
+      {
+        task: { id: '~user/one//1/failed' },
+        latestJob: { id: '~user/one//1/failed/1' },
+      }
+    ])
+  })
+})