£tidy

Author: datamel

src/components/cylc/cylcObject/Menu.vue

@@ -59,12 +59,12 @@ along with this program.  If not, see <http://www.gnu.org/licenses/>.
           <v-list-item
             v-for="{ mutation, requiresInfo, authorised } in displayMutations"
             :key="mutation.name"
-            :disabled="!authorised"
+            :disabled="isDisabled(mutation, authorised)"
             @click.stop="enact(mutation, requiresInfo)"
             class="c-mutation"
           >
             <v-list-item-avatar>
-              <v-icon :disabled="!authorised" large>
+              <v-icon :disabled="isDisabled(mutation, authorised)" large>
                 {{ mutation._icon }}
               </v-icon>
             </v-list-item-avatar>
@@ -232,12 +232,18 @@ export default {
 
   methods: {
     isEditable (authorised, mutation) {
-      if (!authorised || mutation.name === 'log') {
+      if (mutation.name === 'log' || this.isDisabled(mutation, authorised)) {
         return true
       } else {
         return false
       }
     },
+    isDisabled (mutation, authorised) {
+      if (((mutation._validStates.indexOf(this.node.node.status)) === -1) || !authorised) {
+        return true
+      }
+      return false
+    },
     openDialog (mutation) {
       if (mutation.name === 'log') {
         this.showMenu = false

src/utils/aotf.js

@@ -432,9 +432,30 @@ export function processMutations (mutations, types) {
     mutation._icon = mutationIcons[mutation.name] || mutationIcons['']
     mutation._shortDescription = getMutationShortDesc(mutation.description)
     mutation._help = getMutationExtendedDesc(mutation.description)
+    mutation._validStates = getStates(mutation.description)
     processArguments(mutation, types)
   }
 }
+/**
+ * Get the workflow states that the mutation is valid for.
+ *
+ * @export
+ * @param {string=} text - Full mutation description.
+ * @return {Array<String>}
+ */
+export function getStates (text) {
+  const defaultStates = ['running', 'paused', 'stopping', 'stopped']
+  if (!text) {
+    return defaultStates
+  }
+  const re = /Valid\sfor:\s(.*)\sworkflows./
+  // default to all workflow states
+  const validStates = text.match(re)
+  if (validStates) {
+    return validStates[1]
+  }
+  return defaultStates
+}
 
 /**
  * Get the first part of a mutation description (up to the first double newline).

tests/unit/utils/aotf.spec.js

@@ -63,15 +63,16 @@ describe('aotf (Api On The Fly)', () => {
     it('should add computed fields', () => {
       const input = {
         name: 'fooBar',
-        description: 'Short description.\n\nLong\ndescription.',
+        description: 'Short description.\n\nLong\ndescription.\nValid for: [\'stopped\'] workflows.',
         args: []
       }
       const output = {
         ...input,
         _title: 'Foo Bar',
         _icon: aotf.mutationIcons[''],
         _shortDescription: 'Short description.',
-        _help: 'Long\ndescription.'
+        _help: 'Long\ndescription.\nValid for: [\'stopped\'] workflows.',
+        _validStates: "['stopped']"
       }
       aotf.processMutations([input], null)
       expect(input).to.deep.equal(output)