Merge pull request #1269 from MetRonnie/vue3

Upgrade to Vue 3 ⚡

Author: oliver-sanders

.env.offline

@@ -17,48 +17,46 @@
 
 module.exports = {
   root: true,
-  env: {
-    node: true
+  parserOptions: {
+    /* Allow new ECMAScript syntax but not globals. This is because vite/esbuild
+    transforms syntax to es2015 (at the earliest) but does not pollyfill APIs. */
+    ecmaVersion: 'latest',
   },
   extends: [
     'standard',
     'eslint:recommended',
-    'plugin:vue/essential',
-    'plugin:cypress/recommended'
+    'plugin:vue/vue3-essential',
+    'plugin:vuetify/base',
+    'plugin:cypress/recommended',
   ],
   rules: {
-    'no-console': process.env.NODE_ENV === 'production' ? 'error' : 'warn',
-    'no-debugger': process.env.NODE_ENV === 'production' ? 'error' : 'warn',
-    'no-unreachable': process.env.NODE_ENV === 'production' ? 'error' : 'warn',
-    'no-unused-vars': process.env.NODE_ENV === 'production' ? 'error' : 'warn',
-    indent: [
+    'comma-dangle': [
       'error',
-      2,
       {
-        ignoredNodes: [
-          'TemplateLiteral'
-        ]
-      }
+        arrays: 'only-multiline',
+        objects: 'only-multiline',
+        imports: 'only-multiline',
+        exports: 'only-multiline',
+        functions: 'never',
+      },
     ],
     'template-curly-spacing': [
       'off'
     ],
     'vue/multi-word-component-names': [
       'off'
     ],
-    'vue/no-reserved-component-names': [
-      'off'
-    ],
     'vue/valid-v-slot': [
       'error',
       {
         allowModifiers: true
       }
     ],
-    'import/no-duplicates': 'off',
-    'no-duplicate-imports': 'error'
+    'promise/param-names': [
+      'error'
+    ],
+    'promise/no-return-wrap': [
+      'error'
+    ],
   },
-  parserOptions: {
-    parser: '@babel/eslint-parser'
-  }
 }

.eslintrc.js

@@ -35,7 +35,7 @@ jobs:
         run: yarn install
 
       - name: Build
-        run: yarn build --optimize
+        run: yarn build
 
       - name: Get the version number
         run: |

.github/workflows/auto_publish_release.yml

@@ -6,6 +6,9 @@ on:
   pull_request:
   workflow_dispatch:
 
+env:
+  FORCE_COLOR: 2
+
 jobs:
   unit-test-and-build:
     runs-on: ubuntu-latest
@@ -23,26 +26,18 @@ jobs:
         run: yarn install
 
       - name: Lint
-        env:
-          NODE_ENV: production
         run: |
-          yarn run lint --no-fix
+          yarn run lint
 
       - name: Test
         run: |
-          yarn run coverage:unit --colors
-
-      - name: Docs
-        uses: andstor/jsdoc-action@v1
-        with:
-          config_file: jsdoc.conf.json
-        # TODO: upload to GH pages?
+          yarn run coverage:unit
 
       - name: Upload coverage to Codecov
         uses: codecov/codecov-action@v3
         with:
           token: ${{ secrets.CODECOV_TOKEN }}
-          file: ./coverage/lcov.info
+          file: ./coverage/clover.xml
           name: '${{ github.job }}'
           flags: unittests
           fail_ci_if_error: false
@@ -54,6 +49,7 @@ jobs:
   cypress-run:
     runs-on: ${{ matrix.os }}
     strategy:
+      fail-fast: false
       matrix:
         os: [ubuntu-latest]
         browser: [firefox, chrome]
@@ -62,6 +58,8 @@ jobs:
 #         include:
 #           - os: macos-latest
 #             browser: edge
+    env:
+      COVERAGE: true
     steps:
       - name: Checkout
         uses: actions/checkout@v3
@@ -71,20 +69,24 @@ jobs:
         with:
           node-version: '16'
 
-      - name: Test
+      - name: Test (E2E)
+        if: matrix.type == 'e2e'
         uses: cypress-io/github-action@v5
+        env:
+          BASE_URL: http://localhost:4173/
         with:
-          start: yarn run serve --hide=CLIENT  # turn off build output because it's absurdly long
-          wait-on: http://localhost:8080/
-          config-file: cypress.config.js
-          component: ${{ matrix.type == 'component' }}
-          spec: |
-            tests/e2e/**/*
-            cypress/component/*
-            cypress/component/**/*
+          build: yarn run build --mode offline
+          start: yarn run preview
+          config: baseUrl=${{ env.BASE_URL }}
+          wait-on: ${{ env.BASE_URL }}
+          browser: ${{ matrix.browser }}
+
+      - name: Test (component)
+        if: matrix.type == 'component'
+        uses: cypress-io/github-action@v5
+        with:
+          component: true
           browser: ${{ matrix.browser }}
-        env:
-          CYPRESS_baseUrl: http://localhost:8080/
 
       - uses: actions/upload-artifact@v3
         if: failure()

.github/workflows/main.yml

@@ -33,7 +33,6 @@ selenium-debug.log*
 
 # Editor-related config that we may want to commit down the line,
 # just not yet
-jsconfig.json
 vue-shim.d.js
 
 # Yarn

.gitignore

@@ -10,6 +10,7 @@ Martin Ryan           <[email protected]>
 Mel Hall              <[email protected]>                                      <[email protected]>
 Mel Hall              <[email protected]>              Melanie Hall            <[email protected]>
 Ronnie Dutta          <[email protected]>                                  <[email protected]>
+Ronnie Dutta          <[email protected]>                                  <[email protected]>
 Sadie Bartholomew     <[email protected]>     Sadie L. Bartholomew    <[email protected]>
 Alex Szabó            <[email protected]>                   Szabó Alex
 Tim Pillinger         <[email protected]>                                 <[email protected]>

.mailmap

@@ -10,6 +10,14 @@ creating a new release entry be sure to copy & paste the span tag with the
 `actions:bind` attribute, which is used by a regex to find the text to be
 updated. Only the first match gets replaced, so it's fine to leave the old
 ones in. -->
+-------------------------------------------------------------------------------
+## __cylc-ui-2.0.0 (<span actions:bind='release-date'>Upcoming</span>)__
+
+### Enhancements
+
+[#1269](https://github.com/cylc/cylc-ui/pull/1269) -
+Upgraded Vue and Vuetify frameworks to v3.
+
 -------------------------------------------------------------------------------
 ## __cylc-ui-1.6.0 (<span actions:bind='release-date'>Upcoming</span>)__
 
@@ -18,6 +26,12 @@ ones in. -->
 [#1187](https://github.com/cylc/cylc-ui/pull/1187) - Improved the workflow
 filtering menu in the sidebar.
 
+### Fixes
+
+[#1249](https://github.com/cylc/cylc-ui/pull/1249) - Fix tasks not loading
+when navigating between workflows in the standalone `#/tree/` and `#/table/`
+views.
+
 -------------------------------------------------------------------------------
 ## __cylc-ui-1.5.0 (<span actions:bind='release-date'>Released 2023-02-20</span>)__