Address code review

Author: MetRonnie

src/components/cylc/common/EstimatedTime.vue

@@ -23,14 +23,14 @@ along with this program.  If not, see <http://www.gnu.org/licenses/>.
   </template>
   <span
     v-else-if="isTruthyOrZero(estimate)"
+    v-tooltip="{ text: tooltip, openDelay: 200 }"
     class="d-inline-flex align-center text-blue-grey"
   >
     {{ formatter(estimate) }}
     <v-icon
       :icon="mdiTimerSand"
       size="small"
       class="ml-1"
-      v-tooltip="{ text: tooltip, openDelay: 200 }"
     />
   </span>
 </template>

src/components/cylc/common/JobDetails.vue

@@ -67,7 +67,7 @@ along with this program.  If not, see <http://www.gnu.org/licenses/>.
             :actual="getRunTime(node)"
             :estimate="meanElapsedTime"
             :formatter="(x) => formatDuration(x, { allowZeros: true })"
-            tooltip="Mean"
+            tooltip="Mean for this task"
           />
         </td>
       </tr>

src/components/cylc/table/Table.vue

@@ -65,7 +65,7 @@ along with this program.  If not, see <http://www.gnu.org/licenses/>.
       <EstimatedTime
         v-bind="taskRunTimes.get(item.task.id)"
         :formatter="(x) => formatDuration(x, { allowZeros: true })"
-        tooltip="Mean"
+        tooltip="Mean for this task"
       />
     </template>
     <template v-slot:item.data-table-expand="{ item, internalItem, toggleExpand, isExpanded }">

tests/e2e/specs/table.cy.js

@@ -96,18 +96,21 @@ describe('Table view', () => {
         .should('be.visible')
     })
     it('displays and sorts latest job run time', () => {
+      const nonzeroValues = [
+        '00:00:01',
+        '00:00:01',
+        '00:00:04',
+        '00:00:12',
+        '00:03:00',
+      ]
       // sort dt-mean ascending
       cy.get('.c-table')
         .contains('th', 'Run Time').as('dTHeader')
         .click()
         .get('tbody tr td:nth-child(10)') // 10th column
         .then(($cells) => {
           expect(Array.from($cells, (cell) => cell.innerText.trim())).to.deep.equal([
-            '00:00:01',
-            '00:00:01',
-            '00:00:04',
-            '00:00:12',
-            '00:03:00',
+            ...nonzeroValues,
             '', // no value sorted after numbers
             '',
           ])
@@ -118,11 +121,7 @@ describe('Table view', () => {
         .get('tbody tr td:nth-child(10)')
         .then(($cells) => {
           expect(Array.from($cells, (cell) => cell.innerText.trim())).to.deep.equal([
-            '00:03:00',
-            '00:00:12',
-            '00:00:04',
-            '00:00:01',
-            '00:00:01',
+            ...nonzeroValues.slice().reverse(),
             '', // no value still sorted after numbers
             '',
           ])

tests/unit/utils/tasks.spec.js

@@ -126,6 +126,7 @@ describe('tasks', () => {
     it.each([
       ['2022-10-05T11:56:00.000Z', '2022-10-05T11:56:00Z'],
       ['2023-05-20T14:48-04:30', '2023-05-20T19:18:00Z'],
+      ['2023-12-04T11:38+13:25', '2023-12-03T22:13:00Z'],
       ['2024-01-15T09:30:45.123Z', '2024-01-15T09:30:45Z'],
     ])('%s -> %s', (input, expected) => {
       expect(formatDatetime(new Date(input))).toEqual(expected)