Skip to content

Commit ca2236a

Browse files
authored
Fix arrow keys not working in Edit Runtime form inputs (#1643)
* Fix arrow keys not working in Edit Runtime form inputs * Update changelog [skip ci]
1 parent 450df28 commit ca2236a

File tree

2 files changed

+25
-18
lines changed

2 files changed

+25
-18
lines changed

CHANGES.md

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,15 @@ creating a new release entry be sure to copy & paste the span tag with the
1010
`actions:bind` attribute, which is used by a regex to find the text to be
1111
updated. Only the first match gets replaced, so it's fine to leave the old
1212
ones in. -->
13+
-------------------------------------------------------------------------------
14+
## __cylc-ui-2.4.0 (<span actions:bind='release-date'>Upcoming</span>)__
15+
16+
### Fixes
17+
18+
[#1643](https://github.com/cylc/cylc-ui/pull/1643) -
19+
Fix bug where the up/down/home/end keys would not work inside the Edit Runtime
20+
form inputs.
21+
1322
-------------------------------------------------------------------------------
1423
## __cylc-ui-2.3.0 (<span actions:bind='release-date'>Released 2023-11-28</span>)__
1524

src/components/graphqlFormGenerator/EditRuntimeForm.vue

Lines changed: 16 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -38,25 +38,23 @@ along with this program. If not, see <http://www.gnu.org/licenses/>.
3838
v-else
3939
v-model="isValid"
4040
ref="form"
41-
class="c-edit-runtime-form"
41+
class="c-edit-runtime-form ma-4"
4242
>
43-
<v-list>
44-
<v-list-item
45-
v-for="key in Object.keys(model)"
46-
:key="key"
47-
>
48-
<v-list-item-title class="c-input-label">
49-
<!-- input label - the display title for this input -->
50-
{{ startCase(key) }}
51-
</v-list-item-title>
52-
<component
53-
:is="getInputProps(key).is"
54-
v-bind="getInputProps(key)"
55-
v-model="model[key]"
56-
:types="types"
57-
/>
58-
</v-list-item>
59-
</v-list>
43+
<div
44+
v-for="key in Object.keys(model)"
45+
:key="key"
46+
>
47+
<v-list-item-title class="c-input-label">
48+
<!-- input label - the display title for this input -->
49+
{{ startCase(key) }}
50+
</v-list-item-title>
51+
<component
52+
:is="getInputProps(key).is"
53+
v-bind="getInputProps(key)"
54+
v-model="model[key]"
55+
:types="types"
56+
/>
57+
</div>
6058
</v-form>
6159
</div>
6260
</template>

0 commit comments

Comments
 (0)