view toolbar: add search & filter functionality #2370
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add functionality to the ViewToolbar component: * Add `action=menu` for dropdowns. * Add `action=input` for text input. * Allow `icon=Object` to configure state-dependent icons. * Reduce icon spacing and improve group divider. * Move the task search & filter controls into the ViewToolbar component. * Switch the Tree and Table views over to the ViewToolbar. * Addresses cylc#471 * Improve the task state filter control: * Add support for task modifiers - closes cylc#1666 * Collapse the control into a single button/menu (take up less space). * Reduce the width of the task search input, automatically increase this width when focused or when text is present in it.
* Ensure the ViewToolbar doesn't scroll out of view. * Closes cylc#991
* These can cause vite to crash.
oliver-sanders
commented
Nov 26, 2025
Comment on lines
+268
to
+280
| // it('Provides a select all functionality', () => { | ||
| // cy.visit('/#/tree/one') | ||
| // cy.get('[data-cy="control-taskStateFilter"]') | ||
| // .get('.v-list-item--active') | ||
| // .should('have.length', 0) | ||
| // cy.get('[data-cy="control-taskStateFilter"]') | ||
| // .click() | ||
| // .get('[data-cy=task-filter-select-all]') | ||
| // .click() | ||
| // cy.get('[data-cy="control-taskStateFilter"]') | ||
| // .get('.v-list-item--active') | ||
| // .should('have.length', 8) | ||
| // }) |
Member
Author
There was a problem hiding this comment.
oliver-sanders
commented
Nov 26, 2025
| .toolbar { | ||
| position: sticky; | ||
| top: 0; | ||
| background: white; |
Member
Author
There was a problem hiding this comment.
Any better ideas than white?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds task modifier filtering to the Tree & Table views as well as a bunch of related things:
action=menufor dropdowns.action=inputfor text input.icon=Objectto configure state-dependent icons.this width when focused or when text is present in it.
Check List
CONTRIBUTING.mdand added my name as a Code Contributor.setup.cfg(andconda-environment.ymlif present).?.?.xbranch.