remove non-functional attempt to pick a port

Author: wxtim

cylc/uiserver/ws.py

@@ -25,7 +25,6 @@
 from glob import glob
 import os
 from pathlib import Path
-import socket
 from typing import Annotated
 
 LOG_ROOT_TMPL = "~/.cylc/%(ns)s-%(util)s-%(host)s-%(port)s"
@@ -162,39 +161,24 @@ def get_util_home(*args):
 
 
 def get_review_service_config(
-    ports: tuple[Annotated[int, Ge(0)], Annotated[int, Ge(0)]] = (8000, 8999),
+    port: Annotated[int, Ge(0)] = 8042,
     service_root: str = 'services/cylc'
 ) -> dict:
     """Get a configuration for Cylc Review as a service.
 
     Args:
-        ports: A range of ports to attempt to make the Cylc Review service
-            available on.
+        port: The port to make the Cylc Review service available on.
         service_root: Include web service name under root of URL.
 
     Returns:
         Dictionary of settings for Cylc Review to be run as a hub service.
     """
-    port_found = False
-    for port in range(ports[0], ports[1]):
-        with socket.socket(socket.AF_INET, socket.SOCK_STREAM) as s:
-            try:
-                s.bind(('localhost', port))
-            except Exception:
-                pass
-            else:
-                port_found = True
-                break
-
-    if not port_found:
-        print('No suitable port found.')
-
     return {
         "name": "cylc-review",
         "command": [
             "cylc", "review", "start",
             f"--port={port}",
             f"--service-root={service_root}",
         ],
-        "url": f"http://127.0.0.1:{port}/",
+        "url": f"http://0.0.0.0:{port}/",
     }

tests/unit/test_ws.py

@@ -31,32 +31,3 @@ def _mock_bind(input_):
     if port in list(range(8000, 8002)):
         raise Exception(f'Port is {port}')
     return True
-
-
-@contextmanager
-def _mock_socket(*args):
-    """Mock socket.socket context object
-    """
-    yield SimpleNamespace(bind=_mock_bind)
-
-
-@pytest.mark.parametrize(
-    'inputs, port',
-    (
-        (((8000, 8003), None), 8002),
-        (((8000, 8003), 'gerbil/wheel'), 8002),
-    )
-)
-def test_get_review_service_config(monkeypatch, inputs, port):
-    monkeypatch.setattr('socket.socket', _mock_socket)
-    result = get_review_service_config(*inputs)
-    assert result['command'][3] == f'--port={port}'
-    assert result['command'][4] == f'--service-root={inputs[1]}'
-    assert result['url'] == f"http://127.0.0.1:{port}/"
-
-
-def test_get_review_service_config_no_port(monkeypatch):
-    inputs = ((8000, 8001), None)
-    monkeypatch.setattr('socket.socket', _mock_socket)
-    with pytest.raises(Exception, match='bleugh'):
-        get_review_service_config(*inputs)