Merge pull request #636 from oliver-sanders/shutdown-subproc-pool-backport

shutdown: terminate subprocesses

Author: oliver-sanders

changes.d/619.fix.md

@@ -0,0 +1 @@
+Ensure that subprocesses created by Cylc UI Server are cleaned up correctly when the server shuts down.

cylc/uiserver/app.py

@@ -580,10 +580,17 @@ def launch_instance(cls, argv=None, workflow_id=None, **kwargs):
     async def stop_extension(self):
         # stop the async scan task
         await self.workflows_mgr.stop()
+
+        # stop active subscriptions
         for sub in self.data_store_mgr.w_subs.values():
             sub.stop()
-        # Shutdown the thread pool executor
+
+        # Shutdown the thread pool executor (used for subscription processing)
         self.data_store_mgr.executor.shutdown(wait=False)
+
+        # stop the process pool (used for background commands)
+        self.executor.shutdown()
+
         # Destroy ZeroMQ context of all sockets
         self.workflows_mgr.context.destroy()
         self.profiler.stop()