cat log: handle longer lines in files #752
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MetRonnie
commented
Nov 19, 2025
| async for line in stream: | ||
| await queue.put(line.decode()) | ||
| except Exception as exc: | ||
| if re.match(r'Separator .+ chunk .+ limit', str(exc)): |
Member
Author
There was a problem hiding this comment.
From inspecting the asyncio code, there are 2 possible error messages that fit this pattern. Doesn't seem to be a better way to detect this unfortunately, as the error subclass is swallowed into a ValueError for some reason
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses a bug reported by a user where they said they saw an red error snackbar in the UI that said
I have not managed to reproduce in exactly this way, but if a line is longer than 64 kiB, the log view in the UI will stop at that line, but there is no hint that anything is wrong. Later in the uiserver log I saw the error message and traceback once I closed the UI.
This PR increases the line limit to 200 kiB as a precaution, and properly displays a "line too long" error in the log view should a line exceed this.
Check List
CONTRIBUTING.mdand added my name as a Code Contributor.?.?.xbranch.