Merge pull request llvm#9617 from swiftlang/cherrypick-stable/20240723-7c20bdf373d6

[🍒 stable/20240723] [lldb] Fix synchronization in AlarmTest (NFC)

Author: JDevlieghere

lldb/unittests/Host/AlarmTest.cpp

@@ -56,6 +56,9 @@ TEST(AlarmTest, Create) {
   // Leave plenty of time for all the alarms to fire.
   std::this_thread::sleep_for(TEST_TIMEOUT);
 
+  // Acquire the lock to check the callbacks.
+  std::lock_guard<std::mutex> guard(m);
+
   // Make sure all the alarms fired around the expected time.
   for (size_t i = 0; i < 5; ++i)
     EXPECT_GE(callbacks_actual[i], callbacks_expected[i]);
@@ -83,6 +86,9 @@ TEST(AlarmTest, Exit) {
     // Let the alarm go out of scope before any alarm had a chance to fire.
   }
 
+  // Acquire the lock to check the callbacks.
+  std::lock_guard<std::mutex> guard(m);
+
   // Make sure none of the alarms fired.
   for (bool callback : callbacks)
     EXPECT_TRUE(callback);
@@ -113,6 +119,9 @@ TEST(AlarmTest, Cancel) {
   // Leave plenty of time for all the alarms to fire.
   std::this_thread::sleep_for(TEST_TIMEOUT);
 
+  // Acquire the lock to check the callbacks.
+  std::lock_guard<std::mutex> guard(m);
+
   // Make sure none of the first 4 alarms fired.
   for (size_t i = 0; i < 4; ++i)
     EXPECT_FALSE(callbacks[i]);
@@ -146,13 +155,17 @@ TEST(AlarmTest, Restart) {
 
   // Update the last 2 alarms.
   for (size_t i = 3; i < 5; ++i) {
+    std::lock_guard<std::mutex> guard(m);
     callbacks_expected[i] = std::chrono::system_clock::now() + ALARM_TIMEOUT;
     EXPECT_TRUE(alarm.Restart(handles[i]));
   }
 
   // Leave plenty of time for all the alarms to fire.
   std::this_thread::sleep_for(TEST_TIMEOUT);
 
+  // Acquire the lock to check the callbacks.
+  std::lock_guard<std::mutex> guard(m);
+
   // Make sure all the alarms around the expected time.
   for (size_t i = 0; i < 5; ++i)
     EXPECT_GE(callbacks_actual[i], callbacks_expected[i]);