[wip] port SecureJoin to partialLookupInRoot #14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Aleksa Sarai <[email protected]>
cyphar
force-pushed
the
securejoin-rework
branch
from
b7d9a84 to
c3ef86b
Compare
Signed-off-by: Aleksa Sarai <[email protected]>
cyphar
force-pushed
the
securejoin-rework
branch
from
c3ef86b to
22faec1
Compare
cyphar
force-pushed
the
main
branch
4 times, most recently
from
325f6cb to
70d0ea2
Compare
cyphar
force-pushed
the
main
branch
3 times, most recently
from
bc37ffe to
bc371b5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is based on #13 and is mostly a proof-of-concept to show how
partialLookupInRootcan be adapted to implementSecureJoin.Note that due to the different semantics, there are test failures when dealing with dangling symlinks. I'm not quite sure what we should do for those (emulating them using
partialLookupInRootwould get quite expensive -- especially when usingopenat2). And obviously we can only switch the implementation on Linux becausepartialLookupInRootis Linux-only.