fix(frontend): use Clearer User Feedback

Author: Baraka24

modules/core/output_modules.php

@@ -18,7 +18,7 @@ protected function output() {
         $res = '<li class="menu_search mb-2"><form method="get">';
         $res .= '<div class="input-group">';
         if (!$this->get('hide_folder_icons')) {
-            $res .= '<a href="?page=search" class="input-group-text" id="basic-addon1">' . 
+            $res .= '<a href="?page=search" class="input-group-text" id="basic-addon1">' .
             '<i class="bi bi-search"></i>' .
             '</a>';
         }
@@ -635,7 +635,7 @@ protected function output() {
             format_data_sources($this->get('data_sources', array()), $this);
 
         if (!$this->get('disable_delete_prompt', DEFAULT_DISABLE_DELETE_PROMPT)) {
-            $res .= 'var hm_delete_prompt = function() { return confirm("'.$this->trans('Are you sure?').'"); };';
+            $res .= 'var hm_delete_prompt = function() { return confirm("'.$this->trans('Are you sure you wanto to delete this server?').'"); };';
         }
         else {
             $res .= 'var hm_delete_prompt = function() { return true; };';
@@ -1686,9 +1686,9 @@ protected function output() {
         $share_folder_modal .= '</thead>';
         $share_folder_modal .= '<tbody></tbody>';
         $share_folder_modal .= '</table>';
-        
+
         $share_folder_modal .= '</div>';
-        
+
         $share_folder_modal .= '<div class="col-lg-4 col-md-12">';
         $share_folder_modal .= '<form id="shareForm" action="" method="POST">';
         $share_folder_modal .= '<input type="hidden" name="server_id" id="server_id" value="">';

modules/imap/handler_modules.php

@@ -734,7 +734,7 @@ public function process() {
 
                     if ($ceo_use_detect_ceo_fraud && hex2bin($form['folder']) == 'INBOX') {
                         if ($this->isCeoFraud($msg['to'], $msg['subject'], $msg['preview_msg'])) {
-                            
+
                             $folder = "Suspicious emails";
                             if (!count($mailbox->get_mailbox_status($folder))) {
                                 $mailbox->create_folder($folder);
@@ -750,7 +750,7 @@ public function process() {
                             $total--;
                         }
                     }
-                    
+
                     if ($msg) {
                         if (! $include_preview && isset($msg['preview_msg'])) {
                             $msg['preview_msg'] = "";
@@ -770,18 +770,18 @@ public function process() {
             $this->out('do_not_flag_as_read_on_open', $this->user_config->get('unread_on_open_setting', false));
         }
     }
-    public function isCeoFraud($email, $subject, $msg) {          
+    public function isCeoFraud($email, $subject, $msg) {
         // 1. Check Suspicious Terms or Requests
         $suspiciousTerms = explode(",", $this->user_config->get("ceo_suspicious_terms_setting"));
         if ($this->detectSuspiciousTerms($msg, $suspiciousTerms) || $this->detectSuspiciousTerms($subject, $suspiciousTerms)) {
-           
+
             // 2. check ceo_rate_limit
             $amounts = $this->extractAmountFromEmail($msg);
             $amountLimit = $this->user_config->get("ceo_amount_limit_setting");
             $isUpperAmount = array_reduce($amounts, function ($carry, $value) use ($amountLimit) {
                 return $carry || $value > $amountLimit;
             }, false);
-            
+
             if ($isUpperAmount) {
                 if ($this->user_config->get("ceo_use_trusted_contact_setting")) {
                     $contacts = $this->get('contact_store');
@@ -815,16 +815,16 @@ private function isEmailInTrustedDomainList($trustedDomain, $email) {
     }
     private function extractAmountFromEmail($emailBody) {
         $pattern = '/\b\d+(?:,\d+)?\.?\d*\s*(?:USD|dollars?|US\$?|EUR|euros?|€|JPY|yen|¥|GBP|pounds?|£|CAD|CAD\$|AUD|AUD\$)/i';
-    
+
         preg_match_all($pattern, $emailBody, $matches);
-    
+
         if ($matches) {
-            return array_map(function($value) { 
-                return floatval(preg_replace('/[^0-9]/', '', $value)); 
+            return array_map(function($value) {
+                return floatval(preg_replace('/[^0-9]/', '', $value));
             }, $matches[0]);
         }
     }
-    
+
 }
 
 /**
@@ -1135,7 +1135,7 @@ public function process() {
      * @param string $folder The folder where the messages currently reside.
      * @param array $specials Special folder information for handling specific actions.
      * @param array $server_details Details of the server, including its unique ID and settings.
-     * 
+     *
      * @return array Returns an associative array with:
      *   - 'error' => bool Indicates if an error occurred during the operation.
      *   - 'moved' => array List of moved message identifiers in a specific format.
@@ -1182,7 +1182,7 @@ private function perform_action($mailbox, $action_type, $uids, $folder, $special
      * @param string $action_type The action type that determines which special folder to retrieve (e.g., 'delete', 'archive').
      * @param array $specials An associative array of special folder names, like 'trash', 'archive', and 'junk'.
      * @param array $server_details Details of the server, including its name.
-     * 
+     *
      * @return string|false Returns the special folder name if found, or false if no corresponding folder is configured.
      */
     private function get_special_folder($action_type, $specials, $server_details) {
@@ -1273,7 +1273,7 @@ public function process() {
         $offset = 0;
         $list_page = 1;
         $maxPerSource = round($limit / count($data_sources));
-        
+
         if (isset($this->request->get['list_page'])) {
             $list_page = (int) $this->request->get['list_page'];
             if ($list_page && $list_page > 1) {
@@ -1373,7 +1373,7 @@ public function process() {
             $offsets = explode(',', $offsets);
         }
         $searchTerms[] = [search_since_based_on_setting($this->user_config), $date];
-        
+
         $result = getCombinedMessagesLists($data_sources, [
             'cache' => $this->cache,
             'session' => $this->session,
@@ -1693,12 +1693,12 @@ class Hm_Handler_load_imap_folders_permissions extends Hm_Handler_Module {
      */
     public function process() {
         list($success, $form) = $this->process_form(array('imap_server_id','imap_folder_uid','imap_folder'));
-        
+
         if ($success && !empty($form['imap_server_id']) && !empty($form['imap_folder'])  && !empty($form['imap_folder_uid'])) {
             Hm_IMAP_List::init($this->user_config, $this->session);
             $server = Hm_IMAP_List::dump($form['imap_server_id'], true);
             $cache = Hm_IMAP_List::get_cache($this->cache, $form['imap_server_id']);
-            
+
             $imap = Hm_IMAP_List::connect($form['imap_server_id'], $cache, $server['user'], $server['pass']);
             $permissions = $imap->get_acl($form['imap_folder']);
             $this->out('imap_folders_permissions', $permissions);
@@ -1716,13 +1716,13 @@ class Hm_Handler_set_acl_to_imap_folders extends Hm_Handler_Module {
      */
     public function process() {
         list($success, $form) = $this->process_form(array('imap_server_id','imap_folder','identifier','permissions','action'));
-        
+
         if ($success && !empty($form['imap_server_id']) && !empty($form['identifier'])  && !empty($form['permissions']) && !empty($form['action'])) {
 
             Hm_IMAP_List::init($this->user_config, $this->session);
             $server = Hm_IMAP_List::dump($form['imap_server_id'], true);
             $cache = Hm_IMAP_List::get_cache($this->cache, $form['imap_server_id']);
-            
+
             $imap = Hm_IMAP_List::connect($form['imap_server_id'], $cache, $server['user'], $server['pass']);
             if($form['action'] === 'add') {
                 $response = $imap->set_acl($form['imap_folder'], $form['identifier'], $form['permissions']);
@@ -1903,7 +1903,7 @@ public function process() {
         if (isset($this->request->post['imap_connect'])) {
             list($success, $form) = $this->process_form(array('imap_server_id'));
             $imap_details = Hm_IMAP_List::dump($form['imap_server_id'], true);
-            if ($success && $imap_details) {         
+            if ($success && $imap_details) {
                 if ($this->module_is_supported('sievefilters') && $this->user_config->get('enable_sieve_filter_setting', DEFAULT_ENABLE_SIEVE_FILTER)) {
                     try {
                         list($sieve_host, $sieve_port) = parse_sieve_config_host($imap_details['sieve_config_host']);
@@ -2325,9 +2325,15 @@ public function process() {
         if (isset($this->request->post['hide_imap_server'])) {
             list($success, $form) = $this->process_form(array('imap_server_id'));
             if ($success) {
-                Hm_IMAP_List::toggle_hidden($form['imap_server_id'], (bool) $this->request->post['hide_imap_server']);
-                Hm_Msgs::add('Hidden status updated');
-                $this->session->record_unsaved(sprintf('%s server hidden status updated', imap_server_type($form['imap_server_id'])));
+                $action = (bool) $this->request->post['hide_imap_server'];
+                $server_type = imap_server_type($form['imap_server_id']);
+                Hm_IMAP_List::toggle_hidden($form['imap_server_id'], $action);
+                if ($action) {
+                    Hm_Msgs::add(sprintf('%s server has been hidden', $server_type));
+                } else {
+                    Hm_Msgs::add(sprintf('%s server is now visible', $server_type));
+                }
+                $this->session->record_unsaved(sprintf('%s server visibility updated', $server_type));
             }
         }
     }
@@ -2495,7 +2501,7 @@ function process_ceo_use_detect_ceo_fraud_callback($val) { return $val; }
         function process_ceo_use_trusted_contact_callback($val) { return $val; }
         function process_ceo_suspicious_terms_callback($val) { return $val; }
         function process_ceo_amount_limit_callback($val) { return $val; }
-        
+
         process_site_setting('ceo_use_detect_ceo_fraud', $this, 'process_ceo_use_detect_ceo_fraud_callback');
         process_site_setting('ceo_use_trusted_contact', $this, 'process_ceo_use_trusted_contact_callback');
         process_site_setting('ceo_suspicious_terms', $this, 'process_ceo_suspicious_terms_callback');

tests/phpunit/modules/core/output_modules.php

@@ -435,7 +435,7 @@ public function test_js_data() {
         $this->assertStringStartsWith('<script type="text/javascript" id="data-store">var globals = {};var hm_is_logged = function () { return 0; };var hm_empty_folder = function() { return "So alone"; };var hm_mobile = function() { return 0; };var hm_debug = function() { return "0"; };var hm_mailto = function() { return 0; };var hm_page_name = function() { return ""; };var hm_language_direction = function() { return "ltr"; };var hm_list_path = function() { return ""; };var hm_list_parent = function() { return ""; };var hm_msg_uid = function() { return Hm_Utils.get_from_global("msg_uid", ""); };var hm_encrypt_ajax_requests = function() { return ""; };var hm_encrypt_local_storage = function() { return ""; };var hm_web_root_path = function() { return ""; };var hm_flag_image_src = function() { return "<i class=\\"bi bi-star-half\\"></i>"; };var hm_check_dirty_flag = function() { return 0; };var hm_data_sources = function() { return []; };var hm_delete_prompt = function() { return true; };', implode($res->output_response));
         $test->handler_response = array();
         $res = $test->run();
-        $this->assertStringStartsWith('<script type="text/javascript" id="data-store">var globals = {};var hm_is_logged = function () { return 0; };var hm_empty_folder = function() { return "So alone"; };var hm_mobile = function() { return 0; };var hm_debug = function() { return "0"; };var hm_mailto = function() { return 0; };var hm_page_name = function() { return ""; };var hm_language_direction = function() { return "ltr"; };var hm_list_path = function() { return ""; };var hm_list_parent = function() { return ""; };var hm_msg_uid = function() { return Hm_Utils.get_from_global("msg_uid", ""); };var hm_encrypt_ajax_requests = function() { return ""; };var hm_encrypt_local_storage = function() { return ""; };var hm_web_root_path = function() { return ""; };var hm_flag_image_src = function() { return "<i class=\\"bi bi-star-half\\"></i>"; };var hm_check_dirty_flag = function() { return 0; };var hm_data_sources = function() { return []; };var hm_delete_prompt = function() { return confirm("Are you sure?"); };', implode($res->output_response));
+        $this->assertStringStartsWith('<script type="text/javascript" id="data-store">var globals = {};var hm_is_logged = function () { return 0; };var hm_empty_folder = function() { return "So alone"; };var hm_mobile = function() { return 0; };var hm_debug = function() { return "0"; };var hm_mailto = function() { return 0; };var hm_page_name = function() { return ""; };var hm_language_direction = function() { return "ltr"; };var hm_list_path = function() { return ""; };var hm_list_parent = function() { return ""; };var hm_msg_uid = function() { return Hm_Utils.get_from_global("msg_uid", ""); };var hm_encrypt_ajax_requests = function() { return ""; };var hm_encrypt_local_storage = function() { return ""; };var hm_web_root_path = function() { return ""; };var hm_flag_image_src = function() { return "<i class=\\"bi bi-star-half\\"></i>"; };var hm_check_dirty_flag = function() { return 0; };var hm_data_sources = function() { return []; };var hm_delete_prompt = function() { return confirm("Are you sure you wanto to delete this server?"); };', implode($res->output_response));
     }
     /**
      * @preserveGlobalState disabled