Skip to content

Commit 2bdd091

Browse files
authored
fix(backend): address potential security exploits in request parameters (#1514)
* use FILTER_SANITIZE_FULL_SPECIAL_CHARS for all get request parameters instead of FILTER_DEFAULT and fix duplicate post filters of the contact module * for all other parameters, use FILTER_UNSAFE_RAW instead of FILTER_DEFAULT for better clarity
1 parent 0847b37 commit 2bdd091

File tree

32 files changed

+345
-354
lines changed

32 files changed

+345
-354
lines changed

modules/2fa/setup.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@
2323
'ajax_2fa_setup_check',
2424
),
2525
'allowed_post' => array(
26-
'2fa_code' => FILTER_DEFAULT,
26+
'2fa_code' => FILTER_UNSAFE_RAW,
2727
'2fa_enable' => FILTER_VALIDATE_INT,
2828
'2fa_backup_codes' => array('filter' => FILTER_VALIDATE_INT, 'flags' => FILTER_FORCE_ARRAY)
2929
),

modules/account/setup.php

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -31,13 +31,13 @@
3131
'change_password'
3232
),
3333
'allowed_post' => array(
34-
'create_username' => FILTER_DEFAULT,
34+
'create_username' => FILTER_UNSAFE_RAW,
3535
'create_password' => FILTER_UNSAFE_RAW,
3636
'create_password_again' => FILTER_UNSAFE_RAW,
37-
'delete_username' => FILTER_DEFAULT,
37+
'delete_username' => FILTER_UNSAFE_RAW,
3838
'new_pass1' => FILTER_UNSAFE_RAW,
3939
'new_pass2' => FILTER_UNSAFE_RAW,
4040
'old_pass' => FILTER_UNSAFE_RAW,
41-
'change_password' => FILTER_DEFAULT,
41+
'change_password' => FILTER_UNSAFE_RAW,
4242
)
4343
);

modules/advanced_search/setup.php

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -31,14 +31,14 @@
3131
'ajax_adv_search'
3232
),
3333
'allowed_post' => array(
34-
'adv_source' => FILTER_DEFAULT,
35-
'adv_start' => FILTER_DEFAULT,
34+
'adv_source' => FILTER_UNSAFE_RAW,
35+
'adv_start' => FILTER_UNSAFE_RAW,
3636
'adv_source_limit' => FILTER_VALIDATE_INT,
37-
'adv_end' => FILTER_DEFAULT,
38-
'adv_charset' => FILTER_DEFAULT,
39-
'adv_flags' => array('filter' => FILTER_DEFAULT, 'flags' => FILTER_REQUIRE_ARRAY),
40-
'adv_terms' => array('filter' => FILTER_DEFAULT, 'flags' => FILTER_REQUIRE_ARRAY),
41-
'adv_targets' => array('filter' => FILTER_DEFAULT, 'flags' => FILTER_REQUIRE_ARRAY),
37+
'adv_end' => FILTER_UNSAFE_RAW,
38+
'adv_charset' => FILTER_UNSAFE_RAW,
39+
'adv_flags' => array('filter' => FILTER_UNSAFE_RAW, 'flags' => FILTER_REQUIRE_ARRAY),
40+
'adv_terms' => array('filter' => FILTER_UNSAFE_RAW, 'flags' => FILTER_REQUIRE_ARRAY),
41+
'adv_targets' => array('filter' => FILTER_UNSAFE_RAW, 'flags' => FILTER_REQUIRE_ARRAY),
4242
'all_folders' => FILTER_VALIDATE_BOOLEAN,
4343
'all_special_folders' => FILTER_VALIDATE_BOOLEAN,
4444
'include_subfolders' => FILTER_VALIDATE_BOOLEAN,

modules/api_login/setup.php

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -13,8 +13,8 @@
1313
return array(
1414
'allowed_pages' => array('process_api_login'),
1515
'allowed_post' => array(
16-
'hm_session' => FILTER_DEFAULT,
17-
'hm_id' => FILTER_DEFAULT,
18-
'api_login_key' => FILTER_DEFAULT
16+
'hm_session' => FILTER_UNSAFE_RAW,
17+
'hm_id' => FILTER_UNSAFE_RAW,
18+
'api_login_key' => FILTER_UNSAFE_RAW
1919
)
2020
);

modules/calendar/setup.php

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -22,16 +22,16 @@
2222
'calendar',
2323
),
2424
'allowed_post' => array(
25-
'event_title' => FILTER_DEFAULT,
26-
'event_detail' => FILTER_DEFAULT,
27-
'event_date' => FILTER_DEFAULT,
28-
'event_time' => FILTER_DEFAULT,
29-
'event_repeat' => FILTER_DEFAULT,
30-
'delete_id' => FILTER_DEFAULT
25+
'event_title' => FILTER_UNSAFE_RAW,
26+
'event_detail' => FILTER_UNSAFE_RAW,
27+
'event_date' => FILTER_UNSAFE_RAW,
28+
'event_time' => FILTER_UNSAFE_RAW,
29+
'event_repeat' => FILTER_UNSAFE_RAW,
30+
'delete_id' => FILTER_UNSAFE_RAW
3131
),
3232
'allowed_get' => array(
33-
'date' => FILTER_DEFAULT,
34-
'view' => FILTER_DEFAULT,
35-
'action' => FILTER_DEFAULT,
33+
'date' => FILTER_SANITIZE_FULL_SPECIAL_CHARS,
34+
'view' => FILTER_SANITIZE_FULL_SPECIAL_CHARS,
35+
'action' => FILTER_SANITIZE_FULL_SPECIAL_CHARS,
3636
),
3737
);

modules/carddav_contacts/setup.php

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -24,13 +24,13 @@
2424

2525
return array(
2626
'allowed_post' => array(
27-
'carddav_usernames' => array('filter' => FILTER_DEFAULT, 'flags' => FILTER_FORCE_ARRAY),
27+
'carddav_usernames' => array('filter' => FILTER_UNSAFE_RAW, 'flags' => FILTER_FORCE_ARRAY),
2828
'carddav_passwords' => array('filter' => FILTER_UNSAFE_RAW, 'flags' => FILTER_FORCE_ARRAY),
29-
'carddav_email' => FILTER_DEFAULT,
30-
'carddav_fn' => FILTER_DEFAULT,
31-
'carddav_phone' => FILTER_DEFAULT,
32-
'carddav_phone_id' => FILTER_DEFAULT,
33-
'carddav_fn_id' => FILTER_DEFAULT,
34-
'carddav_email_id' => FILTER_DEFAULT
29+
'carddav_email' => FILTER_UNSAFE_RAW,
30+
'carddav_fn' => FILTER_UNSAFE_RAW,
31+
'carddav_phone' => FILTER_UNSAFE_RAW,
32+
'carddav_phone_id' => FILTER_UNSAFE_RAW,
33+
'carddav_fn_id' => FILTER_UNSAFE_RAW,
34+
'carddav_email_id' => FILTER_UNSAFE_RAW
3535
)
3636
);

modules/contacts/setup.php

Lines changed: 15 additions & 24 deletions
Original file line numberDiff line numberDiff line change
@@ -63,39 +63,30 @@
6363
'ajax_autocomplete_contact'
6464
),
6565
'allowed_post' => array(
66-
'contact_email' => FILTER_DEFAULT,
67-
'contact_name' => FILTER_DEFAULT,
68-
'contact_phone' => FILTER_DEFAULT,
69-
'contact_id' => FILTER_DEFAULT,
70-
'contact_value' => FILTER_DEFAULT,
71-
'edit_contact' => FILTER_DEFAULT,
72-
'add_contact' => FILTER_DEFAULT,
73-
'contact_source' => FILTER_DEFAULT,
74-
'contact_type' => FILTER_DEFAULT,
75-
'import_contact' => FILTER_DEFAULT,
76-
'contact_email' => FILTER_SANITIZE_FULL_SPECIAL_CHARS,
77-
'contact_name' => FILTER_SANITIZE_FULL_SPECIAL_CHARS,
78-
'contact_phone' => FILTER_SANITIZE_FULL_SPECIAL_CHARS,
79-
'contact_group' => FILTER_SANITIZE_FULL_SPECIAL_CHARS,
80-
'contact_value' => FILTER_SANITIZE_FULL_SPECIAL_CHARS,
81-
'edit_contact' => FILTER_SANITIZE_FULL_SPECIAL_CHARS,
82-
'add_contact' => FILTER_SANITIZE_FULL_SPECIAL_CHARS,
83-
'contact_source' => FILTER_SANITIZE_FULL_SPECIAL_CHARS,
84-
'contact_type' => FILTER_SANITIZE_FULL_SPECIAL_CHARS,
66+
'contact_email' => FILTER_SANITIZE_EMAIL,
67+
'contact_name' => FILTER_UNSAFE_RAW,
68+
'contact_phone' => FILTER_UNSAFE_RAW,
69+
'contact_id' => FILTER_UNSAFE_RAW,
70+
'contact_value' => FILTER_UNSAFE_RAW,
71+
'edit_contact' => FILTER_UNSAFE_RAW,
72+
'add_contact' => FILTER_UNSAFE_RAW,
73+
'contact_source' => FILTER_UNSAFE_RAW,
74+
'contact_type' => FILTER_UNSAFE_RAW,
75+
'import_contact' => FILTER_UNSAFE_RAW,
8576
'contact_auto_collect' => FILTER_VALIDATE_BOOLEAN,
8677
'enable_warn_contacts_cc_not_exist_in_list_contact' => FILTER_VALIDATE_INT,
87-
'email_address' => FILTER_SANITIZE_FULL_SPECIAL_CHARS
78+
'email_address' => FILTER_SANITIZE_EMAIL
8879
),
8980
'allowed_get' => array(
9081
'contact_id' => FILTER_SANITIZE_FULL_SPECIAL_CHARS,
9182
'contact_page' => FILTER_VALIDATE_INT,
92-
'contact_type' => FILTER_DEFAULT,
93-
'contact_source' => FILTER_DEFAULT,
94-
'import_contact' => FILTER_DEFAULT,
83+
'contact_type' => FILTER_SANITIZE_FULL_SPECIAL_CHARS,
84+
'contact_source' => FILTER_SANITIZE_FULL_SPECIAL_CHARS,
85+
'import_contact' => FILTER_SANITIZE_FULL_SPECIAL_CHARS,
9586
),
9687
'allowed_output' => array(
9788
'contact_deleted' => array(FILTER_VALIDATE_INT, false),
98-
'imported_contact' => array(FILTER_DEFAULT, FILTER_REQUIRE_ARRAY),
89+
'imported_contact' => array(FILTER_SANITIZE_FULL_SPECIAL_CHARS, FILTER_REQUIRE_ARRAY),
9990
'contact_suggestions' => array(FILTER_SANITIZE_FULL_SPECIAL_CHARS, FILTER_REQUIRE_ARRAY),
10091
'collect_contacts' => array(FILTER_VALIDATE_BOOLEAN, false),
10192
'imap_allow_images' => array(FILTER_VALIDATE_BOOLEAN, false),

modules/core/setup.php

Lines changed: 77 additions & 77 deletions
Original file line numberDiff line numberDiff line change
@@ -222,143 +222,143 @@
222222
'ajax_combined_message_list'
223223
),
224224
'allowed_output' => array(
225-
'date' => array(FILTER_DEFAULT, false),
225+
'date' => array(FILTER_UNSAFE_RAW, false),
226226
'formatted_folder_list' => array(FILTER_UNSAFE_RAW, false),
227-
'router_user_msgs' => array(FILTER_DEFAULT, FILTER_REQUIRE_ARRAY),
227+
'router_user_msgs' => array(FILTER_UNSAFE_RAW, FILTER_REQUIRE_ARRAY),
228228
'router_login_state' => array(FILTER_VALIDATE_BOOLEAN, false),
229229
'formatted_message_list' => array(FILTER_UNSAFE_RAW, FILTER_REQUIRE_ARRAY),
230230
'just_saved_credentials' => array(FILTER_VALIDATE_BOOLEAN, false),
231231
'just_forgot_credentials' => array(FILTER_VALIDATE_BOOLEAN, false),
232-
'deleted_server_id' => array(FILTER_DEFAULT, false),
232+
'deleted_server_id' => array(FILTER_UNSAFE_RAW, false),
233233
'msg_headers' => array(FILTER_UNSAFE_RAW, false),
234234
'msg_text' => array(FILTER_UNSAFE_RAW, false),
235235
'msg_source' => array(FILTER_UNSAFE_RAW, false),
236236
'msg_parts' => array(FILTER_UNSAFE_RAW, false),
237237
'pages' => array(FILTER_VALIDATE_INT, false),
238-
'folder_status' => array(FILTER_DEFAULT, FILTER_REQUIRE_ARRAY),
239-
'imap_server_id' => array(FILTER_DEFAULT, false),
240-
'imap_service_name' => array(FILTER_DEFAULT, false)
238+
'folder_status' => array(FILTER_UNSAFE_RAW, FILTER_REQUIRE_ARRAY),
239+
'imap_server_id' => array(FILTER_UNSAFE_RAW, false),
240+
'imap_service_name' => array(FILTER_UNSAFE_RAW, false)
241241
),
242242
'allowed_cookie' => array(
243-
'CYPHTID' => FILTER_DEFAULT,
244-
'hm_id' => FILTER_DEFAULT,
245-
'hm_session' => FILTER_DEFAULT,
246-
'hm_msgs' => FILTER_DEFAULT,
243+
'CYPHTID' => FILTER_UNSAFE_RAW,
244+
'hm_id' => FILTER_UNSAFE_RAW,
245+
'hm_session' => FILTER_UNSAFE_RAW,
246+
'hm_msgs' => FILTER_UNSAFE_RAW,
247247
'hm_reload_folders' => FILTER_VALIDATE_INT
248248
),
249249
'allowed_server' => array(
250-
'REQUEST_URI' => FILTER_DEFAULT,
251-
'REQUEST_METHOD' => FILTER_DEFAULT,
250+
'REQUEST_URI' => FILTER_UNSAFE_RAW,
251+
'REQUEST_METHOD' => FILTER_UNSAFE_RAW,
252252
'SERVER_ADDR' => FILTER_VALIDATE_IP,
253253
'REMOTE_ADDR' => FILTER_VALIDATE_IP,
254254
'SERVER_PORT' => FILTER_VALIDATE_INT,
255-
'SERVER_PROTOCOL' => FILTER_DEFAULT,
256-
'PHP_SELF' => FILTER_DEFAULT,
257-
'REQUEST_SCHEME' => FILTER_DEFAULT,
258-
'HTTP_HOST' => FILTER_DEFAULT,
255+
'SERVER_PROTOCOL' => FILTER_UNSAFE_RAW,
256+
'PHP_SELF' => FILTER_UNSAFE_RAW,
257+
'REQUEST_SCHEME' => FILTER_UNSAFE_RAW,
258+
'HTTP_HOST' => FILTER_UNSAFE_RAW,
259259
'HTTP_ORIGIN' => FILTER_VALIDATE_URL,
260260
'HTTP_REFERER' => FILTER_VALIDATE_URL,
261-
'HTTP_ACCEPT_LANGUAGE' => FILTER_DEFAULT,
262-
'HTTP_ACCEPT_ENCODING' => FILTER_DEFAULT,
263-
'HTTP_ACCEPT_CHARSET' => FILTER_DEFAULT,
264-
'HTTP_ACCEPT' => FILTER_DEFAULT,
265-
'HTTP_USER_AGENT' => FILTER_DEFAULT,
266-
'HTTPS' => FILTER_DEFAULT,
267-
'SERVER_NAME' => FILTER_DEFAULT,
268-
'HTTP_X_REQUESTED_WITH' => FILTER_DEFAULT,
269-
'HTTP_X_FORWARDED_HOST' => FILTER_DEFAULT
261+
'HTTP_ACCEPT_LANGUAGE' => FILTER_UNSAFE_RAW,
262+
'HTTP_ACCEPT_ENCODING' => FILTER_UNSAFE_RAW,
263+
'HTTP_ACCEPT_CHARSET' => FILTER_UNSAFE_RAW,
264+
'HTTP_ACCEPT' => FILTER_UNSAFE_RAW,
265+
'HTTP_USER_AGENT' => FILTER_UNSAFE_RAW,
266+
'HTTPS' => FILTER_UNSAFE_RAW,
267+
'SERVER_NAME' => FILTER_UNSAFE_RAW,
268+
'HTTP_X_REQUESTED_WITH' => FILTER_UNSAFE_RAW,
269+
'HTTP_X_FORWARDED_HOST' => FILTER_UNSAFE_RAW
270270
),
271271

272272
'allowed_get' => array(
273-
'page' => FILTER_DEFAULT,
274-
'msgs' => FILTER_DEFAULT,
275-
'list_path' => FILTER_DEFAULT,
276-
'list_parent' => FILTER_DEFAULT,
273+
'page' => FILTER_SANITIZE_FULL_SPECIAL_CHARS,
274+
'msgs' => FILTER_SANITIZE_FULL_SPECIAL_CHARS,
275+
'list_path' => FILTER_SANITIZE_FULL_SPECIAL_CHARS,
276+
'list_parent' => FILTER_SANITIZE_FULL_SPECIAL_CHARS,
277277
'list_page' => FILTER_VALIDATE_INT,
278-
'uid' => FILTER_DEFAULT,
278+
'uid' => FILTER_SANITIZE_FULL_SPECIAL_CHARS,
279279
'search_terms' => FILTER_UNSAFE_RAW,
280-
'search_since' => FILTER_DEFAULT,
281-
'search_fld' => FILTER_DEFAULT,
282-
'filter' => FILTER_DEFAULT,
283-
'sort' => FILTER_DEFAULT,
284-
'keyword' => FILTER_DEFAULT,
285-
'screen_emails' => FILTER_DEFAULT,
280+
'search_since' => FILTER_SANITIZE_FULL_SPECIAL_CHARS,
281+
'search_fld' => FILTER_SANITIZE_FULL_SPECIAL_CHARS,
282+
'filter' => FILTER_SANITIZE_FULL_SPECIAL_CHARS,
283+
'sort' => FILTER_SANITIZE_FULL_SPECIAL_CHARS,
284+
'keyword' => FILTER_SANITIZE_FULL_SPECIAL_CHARS,
285+
'screen_emails' => FILTER_SANITIZE_FULL_SPECIAL_CHARS,
286286
),
287287

288288
'allowed_post' => array(
289-
'payload' => FILTER_DEFAULT,
290-
'reset_factory' => FILTER_DEFAULT,
291-
'hm_page_key' => FILTER_DEFAULT,
289+
'payload' => FILTER_UNSAFE_RAW,
290+
'reset_factory' => FILTER_UNSAFE_RAW,
291+
'hm_page_key' => FILTER_UNSAFE_RAW,
292292
'logout' => FILTER_VALIDATE_BOOLEAN,
293293
'save_and_logout' => FILTER_VALIDATE_BOOLEAN,
294294
'limit' => FILTER_VALIDATE_INT,
295-
'username' => FILTER_DEFAULT,
295+
'username' => FILTER_UNSAFE_RAW,
296296
'show_list_icons' => FILTER_VALIDATE_BOOLEAN,
297297
'password' => FILTER_UNSAFE_RAW,
298-
'hm_ajax_hook' => FILTER_DEFAULT,
299-
'save_settings' => FILTER_DEFAULT,
300-
'save_settings_permanently' => FILTER_DEFAULT,
301-
'save_settings_permanently_then_logout' => FILTER_DEFAULT,
302-
'language' => FILTER_DEFAULT,
298+
'hm_ajax_hook' => FILTER_UNSAFE_RAW,
299+
'save_settings' => FILTER_UNSAFE_RAW,
300+
'save_settings_permanently' => FILTER_UNSAFE_RAW,
301+
'save_settings_permanently_then_logout' => FILTER_UNSAFE_RAW,
302+
'language' => FILTER_UNSAFE_RAW,
303303
'flagged_per_source' => FILTER_VALIDATE_INT,
304-
'flagged_since' => FILTER_DEFAULT,
304+
'flagged_since' => FILTER_UNSAFE_RAW,
305305
'unread_per_source' => FILTER_VALIDATE_INT,
306-
'unread_since' => FILTER_DEFAULT,
306+
'unread_since' => FILTER_UNSAFE_RAW,
307307
'all_email_per_source' => FILTER_VALIDATE_INT,
308-
'all_email_since' => FILTER_DEFAULT,
308+
'all_email_since' => FILTER_UNSAFE_RAW,
309309
'all_per_source' => FILTER_VALIDATE_INT,
310-
'all_since' => FILTER_DEFAULT,
310+
'all_since' => FILTER_UNSAFE_RAW,
311311
'no_folder_icons' => FILTER_VALIDATE_BOOLEAN,
312312
'mailto_handler' => FILTER_VALIDATE_BOOLEAN,
313-
'list_style' => FILTER_DEFAULT,
314-
'timezone' => FILTER_DEFAULT,
313+
'list_style' => FILTER_UNSAFE_RAW,
314+
'timezone' => FILTER_UNSAFE_RAW,
315315
'disable_delete_prompt' => FILTER_VALIDATE_INT,
316316
'allow_delete_attachment' => FILTER_VALIDATE_INT,
317-
'section_state' => FILTER_DEFAULT,
318-
'section_class' => FILTER_DEFAULT,
319-
'message_ids' => FILTER_DEFAULT,
320-
'action_type' => FILTER_DEFAULT,
321-
'server_pw_id' => FILTER_DEFAULT,
322-
'message_list_since' => FILTER_DEFAULT,
317+
'section_state' => FILTER_UNSAFE_RAW,
318+
'section_class' => FILTER_UNSAFE_RAW,
319+
'message_ids' => FILTER_UNSAFE_RAW,
320+
'action_type' => FILTER_UNSAFE_RAW,
321+
'server_pw_id' => FILTER_UNSAFE_RAW,
322+
'message_list_since' => FILTER_UNSAFE_RAW,
323323
'no_password_save' => FILTER_VALIDATE_BOOLEAN,
324324
'start_page' => FILTER_SANITIZE_URL,
325-
'default_sort_order' => FILTER_DEFAULT,
325+
'default_sort_order' => FILTER_UNSAFE_RAW,
326326
'stay_logged_in' => FILTER_VALIDATE_BOOLEAN,
327327
'junk_per_source' => FILTER_VALIDATE_INT,
328-
'junk_since' => FILTER_DEFAULT,
328+
'junk_since' => FILTER_UNSAFE_RAW,
329329
'snoozed_per_source' => FILTER_VALIDATE_INT,
330-
'snoozed_since' => FILTER_DEFAULT,
330+
'snoozed_since' => FILTER_UNSAFE_RAW,
331331
'trash_per_source' => FILTER_VALIDATE_INT,
332-
'trash_since' => FILTER_DEFAULT,
333-
'drafts_per_source' => FILTER_DEFAULT,
334-
'drafts_since' => FILTER_DEFAULT,
332+
'trash_since' => FILTER_UNSAFE_RAW,
333+
'drafts_per_source' => FILTER_UNSAFE_RAW,
334+
'drafts_since' => FILTER_UNSAFE_RAW,
335335
'warn_for_unsaved_changes' => FILTER_VALIDATE_BOOLEAN,
336-
'srv_setup_stepper_imap_server_id' => FILTER_DEFAULT,
337-
'srv_setup_stepper_smtp_server_id' => FILTER_DEFAULT,
338-
'srv_setup_stepper_profile_name' => FILTER_DEFAULT,
339-
'srv_setup_stepper_email' => FILTER_DEFAULT,
336+
'srv_setup_stepper_imap_server_id' => FILTER_UNSAFE_RAW,
337+
'srv_setup_stepper_smtp_server_id' => FILTER_UNSAFE_RAW,
338+
'srv_setup_stepper_profile_name' => FILTER_UNSAFE_RAW,
339+
'srv_setup_stepper_email' => FILTER_UNSAFE_RAW,
340340
'srv_setup_stepper_password' => FILTER_UNSAFE_RAW,
341-
'srv_setup_stepper_provider' => FILTER_DEFAULT,
341+
'srv_setup_stepper_provider' => FILTER_UNSAFE_RAW,
342342
'srv_setup_stepper_is_sender' => FILTER_VALIDATE_BOOLEAN,
343343
'srv_setup_stepper_is_receiver' => FILTER_VALIDATE_BOOLEAN,
344-
'srv_setup_stepper_smtp_address' => FILTER_DEFAULT,
345-
'srv_setup_stepper_smtp_port' => FILTER_DEFAULT,
344+
'srv_setup_stepper_smtp_address' => FILTER_UNSAFE_RAW,
345+
'srv_setup_stepper_smtp_port' => FILTER_UNSAFE_RAW,
346346
'srv_setup_stepper_smtp_tls' => FILTER_VALIDATE_BOOLEAN,
347-
'srv_setup_stepper_imap_address' => FILTER_DEFAULT,
348-
'srv_setup_stepper_imap_port' => FILTER_DEFAULT,
347+
'srv_setup_stepper_imap_address' => FILTER_UNSAFE_RAW,
348+
'srv_setup_stepper_imap_port' => FILTER_UNSAFE_RAW,
349349
'srv_setup_stepper_imap_tls' => FILTER_VALIDATE_BOOLEAN,
350350
'srv_setup_stepper_enable_sieve' => FILTER_VALIDATE_BOOLEAN,
351351
'srv_setup_stepper_create_profile' => FILTER_VALIDATE_BOOLEAN,
352352
'srv_setup_stepper_profile_is_default' => FILTER_VALIDATE_BOOLEAN,
353-
'srv_setup_stepper_profile_signature' => FILTER_DEFAULT,
354-
'srv_setup_stepper_profile_reply_to' => FILTER_DEFAULT,
355-
'srv_setup_stepper_imap_sieve_host' => FILTER_DEFAULT,
353+
'srv_setup_stepper_profile_signature' => FILTER_UNSAFE_RAW,
354+
'srv_setup_stepper_profile_reply_to' => FILTER_UNSAFE_RAW,
355+
'srv_setup_stepper_imap_sieve_host' => FILTER_UNSAFE_RAW,
356356
'srv_setup_stepper_imap_sieve_mode_tls' => FILTER_VALIDATE_BOOLEAN,
357357
'srv_setup_stepper_only_jmap' => FILTER_VALIDATE_BOOLEAN,
358358
'srv_setup_stepper_jmap_hide_from_c_page' => FILTER_VALIDATE_BOOLEAN,
359-
'srv_setup_stepper_jmap_address' => FILTER_DEFAULT,
359+
'srv_setup_stepper_jmap_address' => FILTER_UNSAFE_RAW,
360360
'srv_setup_stepper_imap_hide_from_c_page' => FILTER_VALIDATE_BOOLEAN,
361-
'images_whitelist' => FILTER_DEFAULT,
361+
'images_whitelist' => FILTER_UNSAFE_RAW,
362362
'update' => FILTER_VALIDATE_BOOLEAN,
363363
'enable_child_processes' => FILTER_VALIDATE_BOOLEAN,
364364
)

modules/dynamic_login/setup.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,5 +13,5 @@
1313
'allowed_cookie' => array(),
1414
'allowed_server' => array(),
1515
'allowed_get' => array(),
16-
'allowed_post' => array('email_provider' => FILTER_DEFAULT)
16+
'allowed_post' => array('email_provider' => FILTER_UNSAFE_RAW)
1717
);

0 commit comments

Comments
 (0)