fix(other): sieve capabilities list improper imploding, testing imap credentials using incorrect parameters, get_messages on a non-existing folder returning unexpcted result

Author: kroky

modules/core/hm-mailbox.php

@@ -261,7 +261,7 @@ public function get_special_use_mailboxes($folder = false) {
      */
     public function get_messages($folder, $sort, $reverse, $flag_filter, $offset=0, $limit=50, $keyword=false, $trusted_senders=[], $include_preview = false) {
         if (! $this->select_folder($folder)) {
-            return;
+            return [0, []];
         }
         if ($this->is_imap()) {
             $messages = $this->connection->get_mailbox_page($folder, $sort, $reverse, $flag_filter, $offset, $limit, $keyword, $trusted_senders, $include_preview);

modules/imap/handler_modules.php

@@ -1917,13 +1917,13 @@ public function process() {
 
                 $mailbox = false;
                 $cache = Hm_IMAP_List::get_cache($this->cache, $form['imap_server_id']);
-                $mailbox = Hm_IMAP_List::connect($form['imap_server_id'], $cache, $form['imap_user'], $form['imap_pass']);
+                $mailbox = Hm_IMAP_List::connect($form['imap_server_id'], $cache);
                 if ($mailbox) {
                     if ($mailbox->authed()) {
-                        Hm_Msgs::add(sprintf("Successfully authenticated to the %s server : %s", $mailbox->server_type(), $form['imap_user']));
+                        Hm_Msgs::add(sprintf("Successfully authenticated to the %s server : %s", $mailbox->server_type(), $imap_details['user']));
                     }
                     else {
-                        Hm_Msgs::add(sprintf("Failed to authenticate to the %s server : %s", $mailbox->server_type(), $form['imap_user']), "danger");
+                        Hm_Msgs::add(sprintf("Failed to authenticate to the %s server : %s", $mailbox->server_type(), $imap_details['user']), "danger");
                     }
                 }
                 else {

modules/imap/output_modules.php

@@ -840,7 +840,10 @@ protected function output() {
         $res = '';
         $capabilities = $this->get('sieve_server_capabilities', array());
         if ($capabilities) {
-            $res .= '<span class="sieve_extensions">'.implode(', ', $capabilities).'</span>';
+            foreach ($capabilities as $key => $val) {
+                $capabilities[$key] = $key . ': ' . (is_array($val) ? implode(', ', $val) : $val);
+            }
+            $res .= '<span class="sieve_extensions">' . implode(', ', $capabilities) . '</span>';
         }
         $this->out('sieve_detail_display', $res);
         $res = '';