fix(frontend/backend): do not show a 'save settings' link in the notice shown when a server is added while the save page is disabled

Author: mercihabam

modules/core/functions.php

@@ -780,3 +780,8 @@ function getSettingsSectionOutput($section, $sectionLabel, $sectionIcon, $settin
     return $res;
 }
 
+function isPageConfigured($page) {
+    $pages = array_keys(Hm_Handler_Modules::dump());
+    return in_array($page, $pages);
+}
+

modules/core/handler_modules.php

@@ -1179,7 +1179,11 @@ public function process() {
                     $this->out('imap_service_name', $provider);
                 }
                 $this->out('just_saved_credentials', true);
-                Hm_Msgs::add("Server saved. To preserve these settings after logout, please go to <a class='alert-link' href='/?page=save'>Save Settings</a>.");
+                if (isPageConfigured('save')) {
+                    Hm_Msgs::add("Server saved. To preserve these settings after logout, please go to <a class='alert-link' href='/?page=save'>Save Settings</a>.");
+                } else {
+                    Hm_Msgs::add("Server saved.");
+                }
             }
 
             if ($createProfile && $this->smtp_server_id && ($this->imap_server_id || $this->jmap_server_id)) {

modules/imap/handler_modules.php

@@ -1456,8 +1456,12 @@ public function process() {
                     'type' => 'jmap',
                     'port' => false,
                     'tls' => false));
-                Hm_Msgs::add("Added server!. To preserve these settings after logout, please go to <a class='alert-link' href='/?page=save'>Save Settings</a>.");
-                $this->session->record_unsaved('JMAP server added');
+                if (isPageConfigured('save')) {
+                    Hm_Msgs::add("Added server!. To preserve these settings after logout, please go to <a class='alert-link' href='/?page=save'>Save Settings</a>.");
+                    $this->session->record_unsaved('JMAP server added');
+                } else {
+                    Hm_Msgs::add('Added server!');
+                }
             }
             else {
                 Hm_Msgs::add('Could not access supplied URL', 'warning');
@@ -1613,8 +1617,12 @@ public function process() {
                 ];
                 $this->user_config->set('special_imap_folders', $specials);
             }
-            Hm_Msgs::add("EWS server saved. To preserve these settings after logout, please go to <a class='alert-link' href='/?page=save'>Save Settings</a>.");
-            $this->session->record_unsaved('EWS server added');
+            if (isPageConfigured('save')) {
+                Hm_Msgs::add("EWS server saved. To preserve these settings after logout, please go to <a class='alert-link' href='/?page=save'>Save Settings</a>.");
+                $this->session->record_unsaved('EWS server added');
+            } else {
+                Hm_Msgs::add('EWS server saved.');
+            }
             $this->session->secure_cookie($this->request, 'hm_reload_folders', '1');
         }
     }

modules/nux/modules.php

@@ -140,7 +140,11 @@ public function process() {
                         ));
                         $this->session->record_unsaved('SMTP server added');
                     }
-                    Hm_Msgs::add("E-mail account successfully added, To preserve these settings after logout, please go to <a class='alert-link' href='/?page=save'>Save Settings</a>.");
+                    if (isPageConfigured('save')) {
+                        Hm_Msgs::add("E-mail account successfully added, To preserve these settings after logout, please go to <a class='alert-link' href='/?page=save'>Save Settings</a>.");
+                    } else {
+                        Hm_Msgs::add("E-mail account successfully added.");
+                    }
                     Hm_IMAP_List::clean_up();
                     $this->session->del('nux_add_service_details');
                     $this->session->record_unsaved('IMAP server added');
@@ -214,7 +218,11 @@ public function process() {
                     $this->session->record_unsaved('IMAP server added');
                     $this->session->record_unsaved('SMTP server added');
                     $this->session->secure_cookie($this->request, 'hm_reload_folders', '1');
-                    Hm_Msgs::add("E-mail account successfully added, To preserve these settings after logout, please go to <a class='alert-link' href='/?page=save'>Save Settings</a>.");
+                    if (isPageConfigured('save')) {
+                        Hm_Msgs::add("E-mail account successfully added, To preserve these settings after logout, please go to <a class='alert-link' href='/?page=save'>Save Settings</a>.");
+                    } else {
+                        Hm_Msgs::add("E-mail account successfully added.");
+                    }
                     $this->session->close_early();
                     $this->out('nux_account_added', true);
                     if ($this->module_is_supported('imap_folders')) {