Removed Hm_Notices::hide method as not need anymore

Author: josaphatim

modules/advanced_search/site.js

@@ -361,7 +361,6 @@ var get_adv_other = function() {
 };
 
 var process_advanced_search = function() {
-    Hm_Notices.hide(true);
     var terms = get_adv_terms();
     if (terms.length == 0) {
         Hm_Notices.show('You must enter at least one search term', 'warning');

modules/core/site.js

@@ -229,7 +229,6 @@ var Hm_Ajax_Request = function() { return {
             }
             if (Hm_Ajax.err_condition) {
                 Hm_Ajax.err_condition = false;
-                Hm_Notices.hide(true);
             }
             if (res.router_user_msgs && !$.isEmptyObject(res.router_user_msgs)) {
                 Object.values(res.router_user_msgs).forEach((msg) => {
@@ -448,10 +447,6 @@ class Hm_Alert {
         }, dismissTime * 1000);
     }
 
-    clearAll() {
-        this.container.innerHTML = '';
-    }
-
     #getIcon(type) {
         const icons = {
             success: 'check-circle-fill',
@@ -475,13 +470,10 @@ var Hm_Notices = {
      * @param {*} type : The type of message to display (primary, secondary, success, danger, warning, info)
      */
     show: function(msg, type = 'success', dismissible = true, dismissTime = 10) {
+        msg = hm_trans(msg);
         this.hm_alert.createAlert(msg, type, dismissible, dismissTime);
     },
 
-    hide: function() {
-        this.hm_alert.clearAll();
-    },
-
     /**
      * Shows pending messages on page load
      */
@@ -1756,10 +1748,6 @@ var decrease_servers = function(section) {
     }
 };
 
-var err_msg = function(msg) {
-    return "ERR"+hm_trans(msg);
-};
-
 var hm_spinner = function(type = 'border', size = '') {
     return `<div class="d-flex justify-content-center spinner">
         <div class="spinner-${type} text-dark${size ? ` spinner-${type}-${size}` : ''}" role="status">
@@ -1810,7 +1798,6 @@ var fillJmapData = function(details) {
 var imap_smtp_edit_action = function(event) {
     resetQuickSetupForm();
     event.preventDefault();
-    Hm_Notices.hide(true);
     var details = $(this).data('server-details');
 
     $('.imap-jmap-smtp-btn').trigger('click');

modules/feeds/site.js

@@ -2,7 +2,6 @@
 
 var feed_test_action = function(event) {
     event.preventDefault();
-    Hm_Notices.hide(true);
     var form = $(this).parent();
     Hm_Ajax.request(
         form.serializeArray(),
@@ -16,7 +15,6 @@ var feed_delete_action = function(event) {
         return false;
     }
     event.preventDefault();
-    Hm_Notices.hide(true);
     var form = $(this).parent();
     Hm_Ajax.request(
         form.serializeArray(),

modules/imap/site.js

@@ -5,7 +5,6 @@ var imap_delete_action = function(event) {
         return false;
     }
     event.preventDefault();
-    Hm_Notices.hide(true);
     var form = $(this).closest('.imap_connect');
     Hm_Ajax.request(
         form.serializeArray(),
@@ -43,15 +42,13 @@ var imap_hide_action = function(form, server_id, hide) {
 
 var imap_hide = function(event) {
     event.preventDefault();
-    Hm_Notices.hide(true);
     var form = $(this).closest('.imap_connect');
     var server_id = $('.imap_server_id', form).val();
     imap_hide_action(form, server_id, 1);
 };
 
 var imap_unhide = function(event) {
     event.preventDefault();
-    Hm_Notices.hide(true);
     var form = $(this).closest('.imap_connect');
     var server_id = $('.imap_server_id', form).val();
     imap_hide_action(form, server_id, 0);
@@ -60,7 +57,6 @@ var imap_unhide = function(event) {
 var imap_test_action = function(event) {    
     $('.imap_folder_data').empty();
     event.preventDefault();
-    Hm_Notices.hide(true);
     var form = $(this).closest('.imap_connect');
     Hm_Ajax.request(
         [{'name': 'hm_ajax_hook', 'value': 'ajax_imap_debug'},
@@ -93,7 +89,6 @@ var imapServersPageHandler = function() {
 
 var ews_edit_action = function(event) {
     event.preventDefault();
-    Hm_Notices.hide(true);
     var details = $(this).data('server-details');
 
     $('.ews-btn').trigger('click');

modules/pgp/site.js

@@ -195,9 +195,6 @@ var Hm_Pgp = {
         if (Hm_Pgp.error_msg) {
             Hm_Pgp.show_error();
         }
-        else {
-            Hm_Notices.hide(true);
-        }
     },
 
     show_error: function() {

modules/smtp/site.js

@@ -21,7 +21,6 @@ var check_attachment_dir_access = function() {
 var smtp_test_action = function(event) {
     event.preventDefault();
     var form = $(this).closest('.smtp_connect');
-    Hm_Notices.hide(true);
     Hm_Ajax.request(
         [{'name': 'hm_ajax_hook', 'value': 'ajax_smtp_debug'},
             {'name': 'smtp_server_id', 'value': $('.smtp_server_id', form).val()}],
@@ -35,7 +34,6 @@ var smtp_delete_action = function(event) {
         return false;
     }
     event.preventDefault();
-    Hm_Notices.hide(true);
     var form = $(this).closest('.smtp_connect');
     Hm_Ajax.request(
         form.serializeArray(),