Refact JS calls for creating notices

Author: josaphatim

modules/2fa/site.js

@@ -1,12 +1,4 @@
 $(function () {
-    function tFaToast(message, timer = 3000) {
-        Hm_Notices.show([message]);
-        const tm = setTimeout(function () {
-            Hm_Notices.hide(true);
-            clearTimeout(tm);
-        }, timer);
-    }
-
     function focusElement(elem) {
         elem.focus();
         elem.select();
@@ -79,7 +71,7 @@ $(function () {
 
                 if (checked && !verified) {
                     $(this).prop("checked", false);
-                    tFaToast(err_msg('You need to verify your 2 factor authentication code before processing'));
+                    Hm_Notices.show('You need to verify your 2 factor authentication code before processing', 'warning');
                     return;
                 }
             });
@@ -138,11 +130,7 @@ $(function () {
             var code = getInputCode();
 
             if (!code) {
-                tFaToast(err_msg("You need to enter the verification code"));
-                var tm = setTimeout(function () {
-                    Hm_Notices.hide(true);
-                    clearTimeout(tm);
-                }, 2000);
+                Hm_Notices.show("You need to enter the verification code", 'warning');
                 return;
             }
 
@@ -157,13 +145,13 @@ $(function () {
                         verified = true;
                         formInput.prop("checked", true);
                         confirmationBtn.addClass("valid");
-                        tFaToast("2 factor authentication enabled");
+                        Hm_Notices.show("2 factor authentication enabled");
                     } else {
                         verified = false;
                         formInput.prop("checked", false);
                         $(".tfa_confirmation_input_digit").addClass("invalid");
                         confirmationBtn.addClass("invalid").addClass("shake");
-                        tFaToast("ERR2 factor authentication code does not match");
+                        Hm_Notices.show("2 factor authentication code does not match", 'danger');
                     }
                     confirmationBtn.text("Verify code").removeClass("loading");
                 }

modules/advanced_search/site.js

@@ -364,22 +364,22 @@ var process_advanced_search = function() {
     Hm_Notices.hide(true);
     var terms = get_adv_terms();
     if (terms.length == 0) {
-        Hm_Notices.show([err_msg('You must enter at least one search term')]);
+        Hm_Notices.show('You must enter at least one search term', 'warning');
         return;
     }
     const sources = get_adv_sources();
     if (sources.length == 0) {
-        Hm_Notices.show([err_msg('You must select at least one source')]);
+        Hm_Notices.show('You must select at least one source', 'warning');
         return;
     }
     var targets = get_adv_targets();
     if (targets.length == 0) {
-        Hm_Notices.show([err_msg('You must have at least one target')]);
+        Hm_Notices.show('You must have at least one target', 'warning');
         return;
     }
     var times = get_adv_times();
     if (times.length == 0) {
-        Hm_Notices.show([err_msg('You must enter at least one time range')]);
+        Hm_Notices.show('You must enter at least one time range', 'warning');
         return;
     }
     var other = get_adv_other();

modules/contacts/js_modules/route_handlers.js

@@ -19,7 +19,7 @@ function applyContactsPageHandlers() {
         const allowed_characters = ['+','-','(',')'];
         for (let chain_counter = 0; chain_counter < contact_phone.length; chain_counter++) {
             if(!(regex_number.test(contact_phone[chain_counter])) && !(allowed_characters.indexOf(contact_phone[chain_counter]) > -1)){
-                Hm_Notices.show([hm_trans("This phone number appears to contain invalid character (s).\nIf you are sure ignore this warning and continue!")]);
+                Hm_Notices.show("This phone number appears to contain invalid character (s).\nIf you are sure ignore this warning and continue!", "warning");
                 $(this).off();
             }
         }

modules/core/js_modules/actions/pagination.js

@@ -68,7 +68,7 @@ async function changePage(toPage, button, offsets) {
         display_imap_mailbox(messagesStore.rows, null, messagesStore.list);
         $(".pagination .current").text(toPage);
     } catch (error) {
-        Hm_Utils.add_sys_message("Failed to fetch content", "danger");
+        Hm_Notices.show("Failed to fetch content", "danger");
     } finally {
         $(button).removeClass('active');
         refreshNextButton(toPage);

modules/core/js_modules/actions/privacy_controls.js

@@ -8,7 +8,7 @@ async function addSenderToImagesWhitelist(email) {
         ], (response) => {
             resolve(response);
         }, [], false, undefined, () => {
-            Hm_Notices.show([`ERRAn error occured while adding the sender to the whitelist`]);
+            Hm_Notices.show('An error occured while adding the sender to the whitelist', 'danger');
             reject();
         });
     });

modules/core/js_modules/actions/sortCombinedLists.js

@@ -10,6 +10,6 @@ async function sortCombinedLists(sortValue) {
         Hm_Utils.tbody().attr('id', messagesStore.list);
         display_imap_mailbox(messagesStore.rows, null, messagesStore.list);
     } catch (error) {
-        Hm_Utils.add_sys_message('Failed to load messages', 'danger');
+        Hm_Notices.show('Failed to load messages', 'danger');
     }
 }

modules/core/navigation/navigation.js

@@ -91,7 +91,7 @@ async function navigate(url) {
 
         trackLocationSearchChanges();
     } catch (error) {
-        Hm_Notices.show([`ERR${error.message}`]);
+        Hm_Notices.show(error.message, 'danger');
     } finally {
         hideRoutingToast();
     }