fix(backend): deal with mixed-case header names

Author: kroky

modules/imap/output_modules.php

@@ -193,17 +193,17 @@ protected function output() {
             if (!array_key_exists('subject', lc_headers($headers)) || !trim(lc_headers($headers)['subject'])) {
                 $headers['subject'] = $this->trans('[No Subject]');
             }
-            
+
             // Start Bootstrap container
             $txt .= '<div class="container-fluid p-0 ml-0 border-bottom border-secondary-subtle text-muted">';
-            
+
             foreach ($small_headers as $fld) {
                 foreach ($headers as $name => $value) {
                     if ($fld == mb_strtolower($name)) {
                         if ($fld == 'subject') {
                             $txt .= '<div class="row g-0 py-0 py-sm-1 small_header d-flex">';
                             $txt .= '<div class="col-12">';
-                            if (isset($headers['Flags']) && mb_stristr($headers['Flags'], 'flagged')) {
+                            if (array_key_exists('flags', lc_headers($headers)) && mb_stristr(lc_headers($headers)['flags'], 'flagged')) {
                                 $txt .= '<i class="bi bi-star-half account_icon"></i> ';
                             }
                             $txt .= '<span class="fs-5 fw-normal text-dark js-header_subject">' . $this->html_safe($value) . '</span>';
@@ -271,10 +271,10 @@ protected function output() {
                             $txt .= '</div></div></div></div></div>';
                         }
                         elseif ($fld == 'reply-to') {
-                            $from = addr_parse($headers['From']);
+                            $from = addr_parse(lc_headers($headers)['from'] ?? '');
                             $replyEmails = array_map(function ($addr) {
                                 return $addr['email'];
-                            }, process_address_fld($headers['Reply-To']));
+                            }, process_address_fld(lc_headers($headers)['reply-to'] ?? ''));
 
                             if (count($replyEmails) === 1 && ($replyEmails[0] === $from['email'])) {
                                 $txt .= '<div class="row g-0 py-1 long_header">';
@@ -307,7 +307,7 @@ protected function output() {
                     }
                 }
             }
-            $is_draft = isset($headers['Flags']) && mb_stristr($headers['Flags'], 'draft');
+            $is_draft = array_key_exists('flags', lc_headers($headers)) && mb_stristr(lc_headers($headers)['flags'], 'draft');
             if($is_draft) {
                 $txt .= '<div class="row g-0 py-2"><div class="col-12 text-center text-md-start"><a class="btn btn-primary" href="?page=compose'.$reply_args.'&imap_draft=1"><i class="bi bi-pencil"></i> '.$this->trans('Edit Draft').'</a></div></div>';
             }
@@ -328,11 +328,11 @@ protected function output() {
                     }
                 }
             }
-            
+
             if ($this->get('list_headers')) {
                 $txt .= format_list_headers($this);
             }
-            
+
             $lc_headers = lc_headers($headers);
             if (array_key_exists('to', $lc_headers)) {
                 $addr_list = process_address_fld($lc_headers['to']);
@@ -362,9 +362,9 @@ protected function output() {
             $txt .= '<a href="#" class="hlink all_headers text-decoration-none btn btn-sm btn-outline-secondary">'.$this->trans('All headers').'</a>';
             $txt .= '<a class="hlink small_headers text-decoration-none btn btn-sm btn-outline-secondary" href="#">'.$this->trans('Small headers').'</a>';
             $txt .= '</div>';
-            
+
             $txt .= '<div class="d-flex flex-wrap gap-2">';
-            if (!isset($headers['Flags']) || !mb_stristr($headers['Flags'], 'draft')) {
+            if (!array_key_exists('flags', $lc_headers) || !mb_stristr($lc_headers['flags'], 'draft')) {
                 $txt .= '<a class="reply_link hlink text-decoration-none btn btn-sm btn-outline-secondary" href="?page=compose&amp;reply=1'.$reply_args.'">'.$this->trans('Reply').'</a>';
                 if ($size > 1) {
                     $txt .= '<a class="reply_all_link hlink text-decoration-none btn btn-sm btn-outline-secondary" href="?page=compose&amp;reply_all=1'.$reply_args.'">'.$this->trans('Reply-all').'</a>';
@@ -373,7 +373,7 @@ protected function output() {
                 }
                 $txt .= forward_dropdown($this, $reply_args);
             }
-            if (isset($headers['Flags']) && mb_stristr($headers['Flags'], 'flagged')) {
+            if (array_key_exists('flags', $lc_headers) && mb_stristr($lc_headers['flags'], 'flagged')) {
                 $txt .= '<a id="flag_msg" class="flagged_link hlink text-decoration-none btn btn-sm btn-outline-secondary hide" data-state="unflagged" href="#">'.$this->trans('Flag').'</a>';
                 $txt .= '<a id="unflag_msg" class="unflagged_link hlink text-decoration-none btn btn-sm btn-outline-secondary" data-state="flagged" href="#">'.$this->trans('Unflag').'</a>';
             } else {
@@ -388,17 +388,17 @@ protected function output() {
             if (!$this->get('is_archive_folder')) {
                 $txt .= '<a class="archive_link hlink text-decoration-none btn btn-sm btn-outline-secondary" id="archive_message" href="#">'.$this->trans('Archive').'</a>';
             }
-            
+
             if($this->get('tags')){
                 $txt .= tags_dropdown($this, $headers);
             }
-            if (isset($headers['X-Schedule'])) {
+            if (isset($lc_headers['x-schedule'])) {
                 $txt .= schedule_dropdown($this, true);
             }
 
             $settings = $this->get('user_settings', array());
             if(array_key_exists('enable_snooze_setting', $settings) && $settings['enable_snooze_setting']) {
-                $txt .= snooze_dropdown($this, isset($headers['X-Snoozed']));
+                $txt .= snooze_dropdown($this, isset($lc_headers['x-snoozed']));
             }
             if ($this->get('sieve_filters_enabled') && !$is_draft) {
                 $server_id = $this->get('msg_server_id');
@@ -407,7 +407,7 @@ protected function output() {
                     $user_config = $this->get('user_config');
                     $contact_list = $user_config->get('contacts', []);
                     $existing_emails = array_column($contact_list, 'email_address');
-                    $sender = addr_parse($headers['From'])['email'];
+                    $sender = addr_parse($lc_headers['from'] ?? '')['email'];
                     $domain = '*@'.get_domain($sender);
                     $blocked_senders = get_blocked_senders_array($imap_server, $this->get('site_config'), $this->get('user_config'));
                     $sender_blocked = in_array($sender, $blocked_senders);
@@ -742,7 +742,7 @@ protected function output() {
                 }
                 $res .= '</tr>';
             }
-        }   
+        }
         return $res;
     }
 }
@@ -1299,7 +1299,7 @@ protected function output() {
         if (!$enable_snooze) {
             return;
         }
-        
+
         $parts = explode('_', $this->get('list_path'));
         $unsnooze = $parts[0] == 'imap' && hex2bin($parts[2]) == 'Snoozed';
         $res = snooze_dropdown($this, $unsnooze);