fix(selenium): update loading indicator ID in wait condition for Selenium tests

Author: Shadow243

modules/core/js_modules/utils/loaders.js

@@ -1,7 +1,7 @@
 function showLoaderToast(text = 'Loading...') {
     const uniqueId = Math.random().toString(36).substring(7);
     const toastHTML = `
-    <div class="position-fixed bottom-0 start-0 p-3" style="z-index: 9999">
+    <div id="loading_indicator" class="position-fixed bottom-0 start-0 p-3" style="z-index: 9999">
         <div class="toast bg-primary text-white" id="${uniqueId}" role="alert" aria-live="assertive" aria-atomic="true" data-bs-autohide="false">
         <div class="toast-body">
             <div class="d-flex align-items-center">

tests/selenium/base.py

@@ -169,7 +169,7 @@ def wait_for_navigation_to_complete(self, timeout=30):
         try:
             # Wait for any loading indicators to disappear
             WebDriverWait(self.driver, 5).until_not(
-                lambda driver: len(driver.find_elements(By.CLASS_NAME, "loading_icon")) > 0
+                lambda driver: len(driver.find_elements(By.ID, "loading_indicator")) > 0
             )
         except:
             # Loading icon might not be present, continue

tests/selenium/pages.py

@@ -22,6 +22,7 @@ def search(self):
         # More flexible text matching for search page
         content_title = self.by_class('content_title')
         title_text = content_title.text.strip()
+        print(f"MESSAGES FOUND: '{title_text}'")
         assert 'Search' in title_text or 'search' in title_text.lower(), f"Expected 'Search' in title, got: '{title_text}'"
 
     def sent(self):
@@ -87,16 +88,9 @@ def flagged(self):
         self.wait_with_folder_list()
         self.safari_workaround()
         self.wait_for_navigation_to_complete()
-        # Look for mailbox_list_title inside content_title
-        try:
-            mailbox_title = self.by_class('mailbox_list_title')
-            title_text = mailbox_title.text.strip()
-            assert 'Flagged' in title_text, f"Expected 'Flagged' in mailbox title, got: '{title_text}'"
-        except:
-            # Fallback: check content_title for flagged-related text
-            content_title = self.by_class('content_title')
-            title_text = content_title.text.strip()
-            assert 'Flagged' in title_text, f"Expected 'Flagged' in content title, got: '{title_text}'"
+        mailbox_title = self.by_class('mailbox_list_title')
+        title_text = mailbox_title.text.strip()
+        assert 'Flagged' in title_text, f"Expected 'Flagged' in mailbox title, got: '{title_text}'"
 
     def contacts(self):
         if not self.mod_active('contacts'):
@@ -138,7 +132,7 @@ def calendar(self):
         # Try calendar_content_title first, then fallback to content_title
         try:
             calendar_title = self.by_class('calendar_content_title')
-            title_text = calendar_title.text.strip()
+            title_text = calendar_title.text
             assert 'Calendar' in title_text, f"Expected 'Calendar' in calendar title, got: '{title_text}'"
         except:
             # Fallback: check content_title for calendar-related text

tests/selenium/servers.py

@@ -40,7 +40,16 @@ def server_stmp_and_imap_add(self):
         next_button = WebDriverWait(self.driver, 10).until(
             EC.element_to_be_clickable((By.ID, "step_config_action_next"))
         )
-        next_button.click()
+         # Scroll to the button and wait for any animations/overlays to finish
+        self.driver.execute_script("arguments[0].scrollIntoView({behavior: 'smooth', block: 'center'});", next_button)
+        sleep(0.5)  # Wait for smooth scroll to complete
+
+        # Try multiple click methods for better reliability
+        try:
+            next_button.click()
+        except Exception as e:
+            print(f"Normal click failed: {e}. Trying JavaScript click...")
+            self.driver.execute_script("arguments[0].click();", next_button)
         # show step two
         WebDriverWait(self.driver, 10).until(
             EC.visibility_of_element_located((By.XPATH, '//h2[text()="Step 2"]'))