refactor(spinner): remove spinner display logic from message store and output modules

Author: Shadow243

modules/core/js_modules/Hm_MessagesStore.js

@@ -256,10 +256,6 @@ class Hm_MessagesStore {
     }
 
     fetch(hideLoadingState = false) {
-        // show my custom cypht spinner(class = cypht-spinner)
-        const spinner = document.querySelector('.cypht-spinner');
-        if (spinner) spinner.style.display = 'block';
-
         let store = this;
         return this.getRequestConfigs().map((config) => {
             const initialConfig = Object.assign([], config);
@@ -277,9 +273,6 @@ class Hm_MessagesStore {
                     undefined,
                     reject
                 );
-            }).finally(() => {
-                // Hide the spinner
-                if (spinner) spinner.style.display = 'none';
             });
         });
     }

modules/core/output_modules.php

@@ -1901,7 +1901,6 @@ protected function output() {
             }
         }
         $res = '<div class="p-3">';
-        $res .= '<div class="cypht-spinner"><div class="spinner-border text-danger" role="status"><span class="visually-hidden">Loading...</span></div></div>';
         $res .= '<table class="message_table table">';
         if (!$this->get('no_message_list_headers')) {
             if (!empty($col_flds)) {

modules/core/site.css

@@ -265,20 +265,6 @@ td {
 .placeholder {
   width: 100px !important;
 }
-.cypht-spinner {
-    position: absolute;
-    inset-inline-start: 55%;
-    top: 50%;
-    --tw-translate-x: -50%;
-    display: none;
-}
-
-/* On small screens we don't have left menu, so there add 5% to inset-inline-start */
-@media screen and (max-width: 600px) {
-  .cypht-spinner {
-    inset-inline-start: 50%;
-  }
-}
 
 .logout {
   margin: 2px;

tests/phpunit/modules/core/output_modules.php

@@ -1047,10 +1047,10 @@ public function test_message_list_start() {
         $test = new Output_Test('message_list_start', 'core');
         $test->handler_response = array('message_list_fields' => array('foo', 'bar'));
         $res = $test->run();
-        $this->assertEquals(array('<div class="p-3"><div class="cypht-spinner"><div class="spinner-border text-danger" role="status"><span class="visually-hidden">Loading...</span></div></div><table class="message_table table"><colgroup><col class="f"><col class="b"></colgroup><thead><tr><th class="o">o</th><th class="a">r</th></tr></thead><tbody class="message_table_body">'), $res->output_response);
+        $this->assertEquals(array('<div class="p-3"><table class="message_table table"><colgroup><col class="f"><col class="b"></colgroup><thead><tr><th class="o">o</th><th class="a">r</th></tr></thead><tbody class="message_table_body">'), $res->output_response);
         $test->handler_response = array('message_list_fields' => array(array(false, true, false)));
         $res = $test->run();
-        $this->assertEquals(array('<div class="p-3"><div class="cypht-spinner"><div class="spinner-border text-danger" role="status"><span class="visually-hidden">Loading...</span></div></div><table class="message_table table"><thead><tr><th></th></tr></thead><tbody class="message_table_body">'), $res->output_response);
+        $this->assertEquals(array('<div class="p-3"><table class="message_table table"><thead><tr><th></th></tr></thead><tbody class="message_table_body">'), $res->output_response);
     }
     /**
      * @preserveGlobalState disabled