Convert https://on.cypress.io/ local target links to full local #6061
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
👷 Deploy request for cypress-docs pending review.Visit the deploys page to approve it
|
|
jennifer-shehane
approved these changes
Dec 30, 2024
You're welcome! The links are now cleaner and maintenance should be more reliable in future. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Source links stored in
*.mdxfiles with the Cypress redirect server https://on.cypress.io/ that redirect to https://docs.cypress.io/ do not allow transparent testing by Docusaurus. Incorrect redirection links, such as https://on.cypress.io/github#Pull-request-comments which produces a "HTTP 404 not found" error, go undetected as Docusaurus only checks local links.Change
Links such as https://on.cypress.io/discord or https://on.cypress.io/cloud, that redirect to another domain, are left unchanged.
Also in code example comments, links such as
// see: https://on.cypress.io/mounting-reactare valid and left unchanged./cloud/integrations/slack/cloud/integrations/source-control/github/cloud/integrations/source-control/gitlab/cloud/integrations/source-control/bitbucket/api/commands/root/api/commands/find/app/tooling/code-coverage/cloud/get-started/setup/cloud/integrations/source-control/github#Pull-request-comments/app/references/command-line#cypress-info/app/core-concepts/best-practices#Selecting-Elements/app/core-concepts/open-mode#Debug/app/component-testing/custom-frameworks/api/cypress-api/custom-queries/api/cypress-api/keyboard-api/app/core-concepts/writing-and-organizing-tests#Allowed-config-values/cloud/get-started/introduction/app/references/changelog#12-0-0/cloud/account-management/projects#Change-project-access/cloud/faq#What-counts-as-a-test-result/app/tooling/IDE-integration#File-Opener-Preference/app/references/changelog#12-4-0Dead links
The following are dead links previously used in docs.cypress.io. They may need correction in the service responsible for on.cypress.io.
[✖] https://on.cypress.io/github#Pull-request-comments → Status: 404
[✖] https://on.cypress.io/projects#Change-project-access → Status: 404
[✖] https://on.cypress.io/cloud-faq#What-counts-as-a-test-result → Status: 404