fix: normalize browser name comparison

bahmutov · bahmutov · commit dfef76add9a1 · 2020-02-03T16:23:43.000-05:00
diff --git a/index.js b/index.js
@@ -54,7 +54,7 @@ const isOn = name => {
   }
 
   if (isBrowser(normalizedName)) {
-    return Cypress.browser.name === normalizedName
+    return checkBrowserName(normalizedName)
   }
 
   if (isEnvironment(name)) {
@@ -154,7 +154,7 @@ const skipOn = (name, cb) => {
     }
 
     if (isBrowser(normalizedName)) {
-      if (Cypress.browser.name === normalizedName) {
+      if (checkBrowserName(normalizedName)) {
         skip()
       }
       return

Original file line number	Diff line number	Diff line change
`@@ -54,7 +54,7 @@ const isOn = name => {`
`54`	`54`	`}`
`55`	`55`
`56`	`56`	`if (isBrowser(normalizedName)) {`
`57`		`- return Cypress.browser.name === normalizedName`
	`57`	`+ return checkBrowserName(normalizedName)`
`58`	`58`	`}`
`59`	`59`
`60`	`60`	`if (isEnvironment(name)) {`
`@@ -154,7 +154,7 @@ const skipOn = (name, cb) => {`
`154`	`154`	`}`
`155`	`155`
`156`	`156`	`if (isBrowser(normalizedName)) {`
`157`		`- if (Cypress.browser.name === normalizedName) {`
	`157`	`+ if (checkBrowserName(normalizedName)) {`
`158`	`158`	`skip()`
`159`	`159`	`}`
`160`	`160`	`return`