clean tests and add a test for new warning

Author: mabela416

packages/config/__snapshots__/index.spec.ts.js

@@ -3,6 +3,7 @@ exports['config/src/index .getBreakingKeys returns list of breaking config keys
   'experimentalSessionAndOrigin',
   'experimentalSkipDomainInjection',
   'videoUploadOnPasses',
+  'experimentalStudio',
 ]
 
 exports['config/src/index .getDefaultValues returns list of public config keys 1'] = {
@@ -32,7 +33,6 @@ exports['config/src/index .getDefaultValues returns list of public config keys 1
   'experimentalOriginDependencies': false,
   'experimentalSourceRewriting': false,
   'experimentalSingleTabRunMode': false,
-  'experimentalStudio': false,
   'experimentalWebKitSupport': false,
   'fileServerFolder': '',
   'fixturesFolder': 'cypress/fixtures',
@@ -123,7 +123,6 @@ exports['config/src/index .getDefaultValues returns list of public config keys f
   'experimentalOriginDependencies': false,
   'experimentalSourceRewriting': false,
   'experimentalSingleTabRunMode': false,
-  'experimentalStudio': false,
   'experimentalWebKitSupport': false,
   'fileServerFolder': '',
   'fixturesFolder': 'cypress/fixtures',
@@ -210,7 +209,6 @@ exports['config/src/index .getPublicConfigKeys returns list of public config key
   'experimentalOriginDependencies',
   'experimentalSourceRewriting',
   'experimentalSingleTabRunMode',
-  'experimentalStudio',
   'experimentalWebKitSupport',
   'fileServerFolder',
   'fixturesFolder',

packages/config/test/project/utils.spec.ts

@@ -978,6 +978,16 @@ describe('config/src/project/utils', () => {
       expect(warning).to.be.calledWith('EXPERIMENTAL_SESSION_AND_ORIGIN_REMOVED')
     })
 
+    it('warns if experimentalStudio is passed', async function () {
+      const warning = sinon.spy(errors, 'warning')
+
+      await this.defaults('experimentalStudio', true, {
+        experimentalStudio: true,
+      })
+
+      expect(warning).to.be.calledWith('EXPERIMENTAL_STUDIO_REMOVED')
+    })
+
     describe('.resolved', () => {
       it('sets reporter and port to cli', () => {
         const obj = {
@@ -1015,7 +1025,6 @@ describe('config/src/project/utils', () => {
             experimentalOriginDependencies: { value: false, from: 'default' },
             experimentalRunAllSpecs: { value: false, from: 'default' },
             experimentalSingleTabRunMode: { value: false, from: 'default' },
-            experimentalStudio: { value: false, from: 'default' },
             experimentalSourceRewriting: { value: false, from: 'default' },
             experimentalWebKitSupport: { value: false, from: 'default' },
             fileServerFolder: { value: '', from: 'default' },
@@ -1134,7 +1143,6 @@ describe('config/src/project/utils', () => {
             experimentalOriginDependencies: { value: false, from: 'default' },
             experimentalRunAllSpecs: { value: false, from: 'default' },
             experimentalSingleTabRunMode: { value: false, from: 'default' },
-            experimentalStudio: { value: false, from: 'default' },
             experimentalSourceRewriting: { value: false, from: 'default' },
             experimentalWebKitSupport: { value: false, from: 'default' },
             fileServerFolder: { value: '', from: 'default' },

packages/launchpad/cypress/e2e/config-warning.cy.ts

@@ -90,40 +90,6 @@ describe('experimentalSingleTabRunMode', () => {
   })
 })
 
-describe('experimentalStudio', () => {
-  it('is not a valid config for component testing', () => {
-    cy.scaffoldProject('experimentalSingleTabRunMode')
-    cy.openProject('experimentalSingleTabRunMode', ['--config-file', 'cypress-invalid-studio-experiment.config.js'])
-
-    cy.visitLaunchpad()
-    cy.get('[data-cy-testingtype="component"]').click()
-    cy.findByTestId('error-header')
-    cy.contains('The experimentalStudio experiment is currently only supported for End to End Testing.')
-  })
-
-  it('is a valid config for e2e testing', { defaultCommandTimeout: THIRTY_SECONDS }, () => {
-    cy.scaffoldProject('e2e')
-    cy.openProject('e2e')
-    cy.withCtx(async (ctx) => {
-      await ctx.actions.file.writeFileInProject('cypress.config.js', `
-        const { defineConfig } = require('cypress')
-
-        module.exports = defineConfig({
-          experimentalStudio: true,
-          e2e: {
-            experimentalStudio: true
-          },
-        })
-      `)
-    })
-
-    cy.visitLaunchpad()
-    cy.get('[data-cy-testingtype="e2e"]').click()
-    cy.findByTestId('launchpad-Choose a browser')
-    cy.get('h1').contains('Choose a browser')
-  })
-})
-
 describe('experimentalRunAllSpecs', () => {
   it('is a valid config for e2e testing', { defaultCommandTimeout: THIRTY_SECONDS }, () => {
     cy.scaffoldProject('run-all-specs')

packages/server/test/unit/project_spec.js

@@ -574,36 +574,9 @@ This option will not have an effect in Some-other-name. Tests that rely on web s
     })
 
     describe('studio initialization', function () {
-      it('does not create studio lifecycle manager when experimental flag is disabled', async function () {
-        const cfg = {
-          isTextTerminal: false,
-          resolved: {
-            experimentalStudio: {
-              value: false,
-            },
-          },
-          projectId: 'test-project',
-          port: 8080,
-        }
-
-        sinon.stub(this.project, 'initializeConfig').resolves(cfg)
-        sinon.stub(this.project, 'saveState').resolves()
-
-        sinon.stub(process, 'chdir')
-
-        await this.project.open()
-
-        expect(this.project.ctx.coreData.studioLifecycleManager).to.be.undefined
-      })
-
       it('does not create studio lifecycle manager when in text terminal mode', async function () {
         const cfg = {
           isTextTerminal: true,
-          resolved: {
-            experimentalStudio: {
-              value: true,
-            },
-          },
           projectId: 'test-project',
           port: 8080,
         }