chore: make the @packages/types an independent bundle without needed ts-node to register entrypoint. Both ESM and CJS distributions are built and types are used as source to be compatible with older styles of commonjs bundling. Types are not shipped with the package. (#32608)

Author: AtofStryker

guides/esm-migration.md

@@ -63,7 +63,7 @@
 - [x] packages/stderr-filtering ✅ **COMPLETED**
 - [ ] packages/telemetry **PARTIAL** - entry point is JS
 - [ ] packages/ts **PARTIAL** - ultimate goal is removal and likely not worth the effort to convert
-- [ ] packages/types **PARTIAL** - entry point is JS
+- [x] packages/types ✅ **COMPLETED**
 - [x] packages/v8-snapshot-require
 - [x] packages/web-config
 

packages/types/.gitignore

@@ -1 +1,2 @@
-src/**/*.js
+esm/
+cjs/

packages/types/index.js

@@ -2,32 +2,39 @@
   "name": "@packages/types",
   "version": "0.0.0-development",
   "private": true,
-  "main": "index.js",
-  "browser": "src/index.ts",
+  "main": "cjs/index.js",
+  "browser": "esm/index.js",
   "scripts": {
-    "build-prod": "tsc || echo 'built, with type errors'",
-    "check-ts": "tsc --noEmit",
-    "clean": "rimraf --glob 'src/*.js' 'src/**/*.js'",
+    "build": "yarn build:esm && yarn build:cjs",
+    "build-prod": "yarn build",
+    "build:cjs": "rimraf cjs && tsc -p tsconfig.cjs.json",
+    "build:esm": "rimraf esm && tsc -p tsconfig.esm.json",
+    "check-ts": "tsc -p tsconfig.cjs.json --noEmit",
+    "clean": "rimraf cjs esm",
     "lint": "eslint --ext .js,.jsx,.ts,.tsx,.json, .",
     "test": "vitest run"
   },
   "dependencies": {
     "semver": "^7.7.1"
   },
   "devDependencies": {
+    "@packages/root": "0.0.0-development",
     "@types/node": "22.18.0",
     "axios": "^1.8.3",
     "better-sqlite3": "11.10.0",
     "devtools-protocol": "0.0.1459876",
     "express": "4.21.0",
+    "rimraf": "^6.0.1",
     "socket.io": "4.0.1",
     "typescript": "~5.4.5",
     "vitest": "^3.2.4"
   },
   "files": [
-    "src/*"
+    "cjs/*",
+    "esm/*"
   ],
   "types": "src/index.ts",
+  "module": "esm/index.js",
   "workspaces": {
     "nohoist": [
       "devtools-protocol"

packages/types/package.json

@@ -1,5 +1,5 @@
 import semverMajor from 'semver/functions/major'
-import packageInfo from '../../../package.json'
+import packageInfo from '@packages/root'
 
 import type { SpecFile } from './spec'
 

packages/types/src/constants.ts

@@ -1,5 +1,4 @@
 {
-  "extends": "../ts/tsconfig.json",
   "include": [
     "src/*.ts",
     "src/**/*.ts"
@@ -11,13 +10,14 @@
     "noUnusedLocals": false,
     "noUnusedParameters": false,
     "allowJs": true,
-    "types": [],
     "noUncheckedIndexedAccess": true,
     "ignoreDeprecations": "5.0",
-    /* 
-     * TODO: remove importsNotUsedAsValues after typescript 5.5 and up as it will no longer work. If we want the same behavior
-     * as importsNotUsedAsValues, we need to use "verbatimModuleSyntax", which will require this package to be an ES Module.
-     */
     "importsNotUsedAsValues": "error",
-  },
+    "skipLibCheck": true,
+    "resolveJsonModule": true,
+    "types": [
+      "mocha",
+      "node"
+    ]
+  }
 }

packages/types/tsconfig.json renamed to packages/types/tsconfig.base.json

@@ -0,0 +1,10 @@
+{
+  "extends": "./tsconfig.base.json",
+  "compilerOptions": {
+    "rootDir": "./src",
+    "outDir": "./cjs",
+    "target": "ES2022",
+    "module": "CommonJS",
+    "moduleResolution": "node"
+  }
+}

packages/types/tsconfig.cjs.json

@@ -0,0 +1,10 @@
+{
+  "extends": "./tsconfig.base.json",
+  "compilerOptions": {
+    "rootDir": "./src",
+    "outDir": "./esm",
+    "target": "ES2022",
+    "module": "ES2022",
+    "moduleResolution": "node"
+  }
+}