fix: refactor function getFilesByGlob to use concat instead of isArray (#20245)

* fix: avoid using Array.isArray when possible

* fix: add one more refactoring

Co-authored-by: Zachary Williams <[email protected]>

Co-authored-by: Zachary Williams <[email protected]>

Author: Barthélémy Ledoux

packages/data-context/src/sources/FileDataSource.ts

@@ -31,9 +31,9 @@ export class FileDataSource {
   }
 
   async getFilesByGlob (cwd: string, glob: string | string[], globOptions?: GlobbyOptions) {
-    const globs = Array.isArray(glob) ? glob : [glob]
+    const globs = ([] as string[]).concat(glob)
 
-    const ignoreGlob = globOptions && Array.isArray(globOptions?.ignore) ? globOptions.ignore.concat('**/node_modules/**') : ['**/node_modules/**']
+    const ignoreGlob = (globOptions?.ignore ?? []).concat('**/node_modules/**')
 
     if (process.platform === 'win32') {
       // globby can't work with backwards slashes

packages/data-context/src/sources/migration/shouldShowSteps.ts

@@ -10,12 +10,8 @@ function getTestFilesGlobs (config: OldCypressConfig, type: 'component' | 'integ
 
   const glob = config[k]?.testFiles ?? config.testFiles
 
-  if (glob && Array.isArray(glob)) {
-    return glob
-  }
-
-  if (glob && typeof glob === 'string') {
-    return [glob]
+  if (glob) {
+    return ([] as string[]).concat(glob)
   }
 
   return ['**/*']