chore: upgrade cli eslint to 9 (#32446)

* chore: replace dtslint with eslint-plugin-expect-type

* update guide

* add lint-staged

* rm stale script

* modify cli eslint and tsconfigs to support ts migration

* separate expect-type files

* modifications to tsconfigs to make eslint a little easier

* revert workflow.yml

* further revision

* put tslint config for dtslint back in

* ensure false negative case is tested

* correct tsconfigs

* align dtslint tsconfig with eslint 9 config

* consolidate / DRY tsconfigs

Author: cacieprins

cli/.eslintignore

@@ -0,0 +1,48 @@
+import { baseConfig, cliOverrides } from '@packages/eslint-config'
+
+export default [
+  ...baseConfig,
+  ...cliOverrides,
+  {
+    languageOptions: {
+      parserOptions: {
+        tsconfigRootDir: __dirname,
+      },
+    },
+  },
+  {
+    rules: {
+      '@stylistic/comma-dangle': 'warn',
+      '@stylistic/comma-spacing': 'warn',
+      '@stylistic/type-generic-spacing': 'warn',
+      '@stylistic/quotes': 'warn',
+      '@stylistic/arrow-parens': 'warn',
+      '@stylistic/no-multi-spaces': 'warn',
+      'padding-line-between-statements': 'warn',
+      '@stylistic/space-unary-ops': 'warn',
+      '@stylistic/member-delimiter-style': 'warn',
+      '@stylistic/object-curly-spacing': 'warn',
+      '@stylistic/semi': 'warn',
+      '@stylistic/space-in-parens': 'warn',
+      '@stylistic/space-infix-ops': 'warn',
+      '@stylistic/template-tag-spacing': 'warn',
+      'no-var': 'warn',
+      '@stylistic/space-before-function-paren': ['warn', 'always'],
+    },
+  },
+  {
+    ignores: [
+      '**/__snapshots__',
+      '**/build/**/*',
+      'package.json',
+      '**/angular/**/*',
+      '**/react/**/*',
+      '**/vue/**/*',
+      '**/svelte/**/*',
+      '**/mount-utils/**/*',
+      '**/types/{bluebird,chai,chai-jquery,jquery,lodash,minimatch,mocha,sinon,sinon-chai}/**/*',
+      '.mocharc.js',
+      '**/*.js',
+    ],
+  },
+]

cli/.eslintrc.json

@@ -4,11 +4,11 @@
   "private": true,
   "main": "dist/index.js",
   "scripts": {
-    "build-cli": "tsc && tsc -p tsconfig.esm.json && tsx ./scripts/build.ts && tsx ./scripts/post-build.ts",
+    "build-cli": "tsc -p tsconfig.build.json && tsc -p tsconfig.esm.json && tsx ./scripts/build.ts && tsx ./scripts/post-build.ts",
     "clean": "tsx ./scripts/clean.ts",
     "dtslint": "dtslint types",
     "postinstall": "patch-package && tsx ./scripts/post-install.ts",
-    "lint": "eslint --ext .ts,.tsx,.json,.vue .",
+    "lint": "eslint",
     "prebuild": "yarn postinstall && tsx ./scripts/start-build.ts",
     "size": "t=\"cypress-v0.0.0.tgz\"; yarn pack --filename \"${t}\"; wc -c \"${t}\"; tar tvf \"${t}\"; rm \"${t}\";",
     "test": "yarn test-unit",
@@ -70,6 +70,7 @@
     "@cypress/sinon-chai": "2.9.1",
     "@cypress/svelte": "0.0.0-development",
     "@cypress/vue": "0.0.0-development",
+    "@packages/eslint-config": "0.0.0-development",
     "@packages/root": "0.0.0-development",
     "@types/bluebird": "3.5.33",
     "@types/chai": "4.2.15",
@@ -83,7 +84,9 @@
     "cross-env": "7.0.3",
     "dependency-check": "4.1.0",
     "dtslint": "4.2.1",
+    "eslint": "^9.31.0",
     "execa-wrap": "1.4.0",
+    "jiti": "^2.4.2",
     "mock-fs": "5.4.0",
     "nock": "13.2.9",
     "resolve-pkg": "2.0.0",
@@ -151,9 +154,13 @@
   "workspaces": {
     "nohoist": [
       "@types/*",
+      "eslint-plugin-expect-type",
       "tsx"
     ]
   },
+  "lint-staged": {
+    "**/*.{js,jsx,ts,tsx,json,vue}": "eslint --fix"
+  },
   "nx": {
     "targets": {
       "build-cli": {

cli/eslint.config.ts

@@ -74,10 +74,9 @@ export default makeUserPackageFile
 if (require.main === module) {
   makeUserPackageFile(process.env.BRANCH)
   .catch((err: any) => {
-    /* eslint-disable no-console */
     console.error('Could not write user package file')
     console.error(err)
-    /* eslint-enable no-console */
+
     process.exit(-1)
   })
 }

cli/package.json

@@ -1,7 +1,7 @@
 #!/usr/bin/env node
 
 // @ts-check
-/* eslint-disable no-console */
+
 import fs from 'fs-extra'
 import { includeTypes } from './utils'
 import shell from 'shelljs'

cli/scripts/build.ts

@@ -23,7 +23,7 @@ includeTypes.forEach((folder: string) => {
 })
 
 // build the project and copy the build files over to the build directory
-shell.exec('tsc -p tsconfig.json')
+shell.exec('tsc -p tsconfig.build.json')
 shell.exec('tsc -p tsconfig.esm.json')
 
 shell.mkdir('-p', 'build/dist')

cli/scripts/post-install.ts

@@ -0,0 +1,22 @@
+{
+  "compilerOptions": {
+    "module": "commonjs",
+    "lib": [
+      "node",
+    ],
+    "exactOptionalPropertyTypes": true,
+    "noImplicitAny": true,
+    "noImplicitThis": true,
+    "strictNullChecks": true,
+    "strictFunctionTypes": true,
+    "noUnusedLocals": false,
+    "noUnusedParameters": false,
+    "types": [],
+    "noEmit": true,
+    "forceConsistentCasingInFileNames": true,
+    "esModuleInterop": true
+  },
+  "include": [
+      "**/*.ts"
+  ]
+}

cli/scripts/start-build.ts

@@ -5,6 +5,9 @@
     "noImplicitAny": false,
     "types": [
       "mocha", "chai", "sinon"
-    ]
-  }
+    ],
+  },
+  "include": [
+    "**/*.ts"
+  ]
 }