chore: update CLI snapshots to include ANSI, replace check-more-types and la, and use vi.mocked (#32486)

* chore: rework vitest mocks

* chore: turn on ANSI for snapshots in the CLI

* chore: remove check-more-types from the CLI and just use lodash/regex

* chore: remove lazy-ass in favor of the native assertion library in node

Author: AtofStryker

cli/lib/errors.ts

@@ -1,12 +1,10 @@
 import chalk from 'chalk'
 import { stripIndent, stripIndents } from 'common-tags'
-import la from 'lazy-ass'
+import _ from 'lodash'
+import assert from 'assert'
 import util from './util'
 import state from './tasks/state'
 
-// TODO: this package needs to be replaced as we can't import it in vitest
-const is = require('check-more-types')
-
 const docsUrl = 'https://on.cypress.io'
 const requiredDependenciesUrl = `${docsUrl}/required-dependencies`
 const runDocumentationUrl = `${docsUrl}/cypress-run`
@@ -309,18 +307,14 @@ export async function formErrorText (info: any, msg?: string, prevMessage?: stri
     formatted.push(stripIndents(msg))
   }
 
-  la(
-    is.unemptyString(infoWithPlatform.description),
-    'expected error description to be text',
-    infoWithPlatform.description,
-  )
+  assert.ok(_.isString(infoWithPlatform.description) && !_.isEmpty(infoWithPlatform.description), 'expected error description to be text.')
 
   // assuming that if there the solution is a function it will handle
   // error message and (optional previous error message)
-  if (is.fn(infoWithPlatform.solution)) {
+  if (_.isFunction(infoWithPlatform.solution)) {
     const text = infoWithPlatform.solution(msg, prevMessage)
 
-    la(is.unemptyString(text), 'expected solution to be text', text)
+    assert.ok(_.isString(text) && !_.isEmpty(text), 'expected solution to be text.')
 
     add(`
         ${infoWithPlatform.description}
@@ -329,11 +323,7 @@ export async function formErrorText (info: any, msg?: string, prevMessage?: stri
 
       `)
   } else {
-    la(
-      is.unemptyString(infoWithPlatform.solution),
-      'expected error solution to be text',
-      infoWithPlatform.solution,
-    )
+    assert.ok(_.isString(infoWithPlatform.solution) && !_.isEmpty(infoWithPlatform.solution), 'expected error solution to be text.')
 
     add(`
         ${infoWithPlatform.description}

cli/lib/tasks/download.ts

@@ -1,5 +1,6 @@
-import la from 'lazy-ass'
 import os from 'os'
+import assert from 'assert'
+import _ from 'lodash'
 import url from 'url'
 import path from 'path'
 import Debug from 'debug'
@@ -12,9 +13,6 @@ import { throwFormErrorText, errors } from '../errors'
 import fs from 'fs-extra'
 import util from '../util'
 
-// TODO: this package needs to be replaced as we can't import it in vitest
-const is = require('check-more-types')
-
 const debug = Debug('cypress:cli')
 
 const defaultBaseUrl = 'https://download.cypress.io/'
@@ -84,7 +82,7 @@ const prepend = (arch: string, urlPath: string, version: string): string => {
 }
 
 const getUrl = (arch: string, version?: string): string => {
-  if (is.webUrl(version)) {
+  if (_.isString(version) && version.match(/^https?:\/\/.*$/)) {
     debug('version is already an url', version)
 
     return version as string
@@ -338,7 +336,7 @@ const start = async (opts: any): Promise<any> => {
   let { version, downloadDestination, progress, redirectTTL } = opts
 
   if (!downloadDestination) {
-    la(is.unemptyString(downloadDestination), 'missing download dir', opts)
+    assert.ok(_.isString(downloadDestination) && !_.isEmpty(downloadDestination), 'missing download dir')
   }
 
   if (!progress) {

cli/lib/tasks/unzip.ts

@@ -1,5 +1,4 @@
 import _ from 'lodash'
-import la from 'lazy-ass'
 import cp from 'child_process'
 import os from 'os'
 import yauzl from 'yauzl'
@@ -9,9 +8,7 @@ import readline from 'readline'
 import fs from 'fs-extra'
 import { throwFormErrorText, errors } from '../errors'
 import util from '../util'
-
-// TODO: this package needs to be replaced as we can't import it in vitest
-const is = require('check-more-types')
+import assert from 'assert'
 
 const debug = Debug('cypress:cli:unzip')
 
@@ -199,7 +196,7 @@ function isMaybeWindowsMaxPathLengthError (err: any): boolean {
 }
 
 const start = async ({ zipFilePath, installDir, progress }: any): Promise<void> => {
-  la(is.unemptyString(installDir), 'missing installDir')
+  assert.ok(_.isString(installDir) && !_.isEmpty(installDir), 'missing installDir')
   if (!progress) {
     progress = { onProgress: () => {
       return {}

cli/lib/util.ts

@@ -1,9 +1,9 @@
 import _ from 'lodash'
+import assert from 'assert'
 import arch from 'arch'
 import os from 'os'
 import ospath from 'ospath'
 import hasha from 'hasha'
-import la from 'lazy-ass'
 import tty from 'tty'
 import path from 'path'
 import { isCI as isCi } from 'ci-info'
@@ -23,9 +23,6 @@ import Debug from 'debug'
 import fs from 'fs-extra'
 import pkg from '../package.json'
 
-// TODO: this package needs to be replaced as we can't import it in vitest
-const is = require('check-more-types')
-
 const debug = Debug('cypress:cli')
 
 const issuesUrl = 'https://github.com/cypress-io/cypress/issues'
@@ -34,13 +31,13 @@ const issuesUrl = 'https://github.com/cypress-io/cypress/issues'
  * Returns SHA512 of a file
  */
 const getFileChecksum = (filename: string): any => {
-  la(is.unemptyString(filename), 'expected filename', filename)
+  assert.ok(_.isString(filename) && !_.isEmpty(filename), 'expected filename')
 
   return hasha.fromFile(filename, { algorithm: 'sha512' })
 }
 
 const getFileSize = async (filename: string): Promise<any> => {
-  la(is.unemptyString(filename), 'expected filename', filename)
+  assert.ok(_.isString(filename) && !_.isEmpty(filename), 'expected filename')
 
   const { size } = await fs.stat(filename)
 
@@ -165,7 +162,7 @@ function printNodeOptions (log: any = debug): void {
   ```
  */
 const dequote = (str: string): string => {
-  la(is.string(str), 'expected a string to remove double quotes', str)
+  assert.ok(_.isString(str), 'expected a string to remove double quotes')
   if (str.length > 1 && str[0] === '"' && str[str.length - 1] === '"') {
     return str.substr(1, str.length - 2)
   }
@@ -501,7 +498,7 @@ const util = {
   },
 
   getEnv (varName: string, trim?: boolean): string | undefined {
-    la(is.unemptyString(varName), 'expected environment variable name, not', varName)
+    assert.ok(_.isString(varName) && !_.isEmpty(varName), 'expected environment variable name, not')
 
     const configVarName = `npm_config_${varName}`
     const configVarNameLower = configVarName.toLowerCase()
@@ -560,8 +557,8 @@ const util = {
   isPossibleLinuxWithIncorrectDisplay,
 
   getGitHubIssueUrl (number: number): string {
-    la(is.positive(number), 'github issue should be a positive number', number)
-    la(_.isInteger(number), 'github issue should be an integer', number)
+    assert.ok(_.isInteger(number), 'github issue should be an integer')
+    assert.ok(number > 0, 'github issue should be a positive number')
 
     return `${issuesUrl}/${number}`
   },

cli/package.json

@@ -29,7 +29,6 @@
     "buffer": "^5.7.1",
     "cachedir": "^2.3.0",
     "chalk": "^4.1.0",
-    "check-more-types": "^2.24.0",
     "ci-info": "^4.1.0",
     "cli-cursor": "^3.1.0",
     "cli-table3": "0.6.1",
@@ -46,7 +45,6 @@
     "fs-extra": "^9.1.0",
     "hasha": "5.2.2",
     "is-installed-globally": "~0.4.0",
-    "lazy-ass": "^1.6.0",
     "listr2": "^3.8.3",
     "lodash": "^4.17.21",
     "log-symbols": "^4.0.0",

cli/test/lib/build.spec.ts

@@ -22,14 +22,12 @@ describe('package.json build', () => {
     // with a few test props
     // the rest should come from root package.json file
 
-    // @ts-expect-error - mockResolvedValue
-    fs.readJson.mockResolvedValue({
+    vi.mocked(fs.readJson).mockResolvedValue({
       name: 'test',
       engines: 'test engines',
-    })
+    } as any)
 
-    // @ts-expect-error - mockResolvedValue
-    fs.outputJson.mockResolvedValue(undefined)
+    vi.mocked(fs.outputJson).mockResolvedValue(undefined)
   })
 
   it('has a semver version', async () => {