You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
chore: convert tests in @packages/errors from mocha to vitest (#32572)
* start vitest convertion and convert errors spec to vitest
* chore: convert errTemplate to vitest
* convert stripIndent to vitest
* convert the visualsnapshoterrors spec to vitest
* chore: clean up errors package, update guide, and move snapshots
* move tests out of unit test directory as most tests are integration tests
* add to esm checklist and update workflow
* clean build and rebuild after test due to CI having built files
* Chore: fix bad test assertion in error spec
* Update guides/esm-migration.md
Co-authored-by: Bill Glesias <[email protected]>
* chore: remove unused FIREFOX_CDP_FAILED_TO_CONNECT error as it is no longer used and likely missed with the CDP removal for Firefox
* chore: fix missed imports
* remove system test code to check for CDP error in firefox
---------
Co-authored-by: Jennifer Shehane <[email protected]>
Copy file name to clipboardExpand all lines: guides/error-handling.md
+11-18Lines changed: 11 additions & 18 deletions
Display the source diff
Display the rich diff
Original file line number
Diff line number
Diff line change
@@ -8,30 +8,23 @@ All error related logic for the server should be added to `@packages/errors`.
8
8
9
9
### Errors Development Workflow
10
10
11
-
Adding and editing errors is best done with the help of the Error Comparison tool.
11
+
Adding and editing errors is best done with the help of an ANSI Comparison tool. Cursor/VSCode offer the [vscode-ansi](https://marketplace.cursorapi.com/items/?itemName=iliazeus.vscode-ansi) comparison tool.
12
12
13
-
Start off by launching the Error Comparison tool from `packages/errors` via `yarn comparison`. This will launch a mini-webapp at http://localhost:5555.
14
-
15
-
The Error Comparison app has three pages: Ansi Compare, Ansi Base List, and Markdown.
16
-
17
-
1. Ansi Compare - Used to compare and accept changes made during development
18
-
2. Ansi Base List - Used to preview errors as they will be rendered to users in the Terminal.
19
-
3. Markdown - Used to preview errors as they will be rendered to users within the App, Launchpad, and Reporter.
13
+
Errors can be compared directly in your code error. Comparing old vs new errors can be done via comparing the git diff or the snapshot diff.
20
14
21
15
#### Editing or Adding New Errors and Updating Snapshots
0 commit comments