Skip to content

Commit e3f4064

Browse files
ryanthemanuelCopilotAtofStrykerestrada9166mschile
authored
internal: rename excludeFromAI type (#32653)
* Create cy-prompt-development.md * chore: cy prompt infrastructure (#31748) * feat: cy prompt infrastructure * refactor and add tests * refactor * rename experimental config * prompt * fix test * Update cy-prompt-development.md * Update cy-prompt-development.md * PR comments * Update packages/server/lib/cloud/api/cy-prompt/get_cy_prompt_bundle.ts Co-authored-by: Copilot <[email protected]> * PR comments --------- Co-authored-by: Copilot <[email protected]> * fix test * Delete packages/server/lib/cloud/StudioLifecycleManager.ts * Delete packages/server/test/unit/cloud/StudioLifecycleManager_spec.ts * chore: add cdp connection to cy prompt (#31806) * chore: add cdp connection to cy prompt * minor fix * fix type build * try to fix build * Update packages/server/lib/browsers/browser-cri-client.ts Co-authored-by: Bill Glesias <[email protected]> * Update packages/server/lib/browsers/browser-cri-client.ts Co-authored-by: Bill Glesias <[email protected]> * do not support prompt in firefox or webkit * rework timing of lifecycle * refactor * fix tests * troubleshooting * troubleshooting * fix tests * additional troubleshooting * additional troubleshooting * additional troubleshooting * attempt to fix build * add back * debugging * debugging * debugging * debugging * clean up * fix unit tests * rework --------- Co-authored-by: Bill Glesias <[email protected]> * chore: create infrastructure to support backend function in cy.prompt (#31803) * chore: add promptBackend as an additional Cypress-attached function * Update packages/app/src/runner/event-manager.ts * update types * fix types * fix spacing * refactor * additional refactor * fix type build * fix build * refactor * reword messages * fix * debugging * undo debugging * PR comment * fix tests * fix tests * fix tests * fix test * chore: add watcher for cy-prompt development (#31810) * chore: add watcher for cy-prompt development * test caching * fix types * chore: turn on beta deployments for cy-prompt * internal: (cy.prompt) handle errors better in the command definition (#31835) * internal: (cy.prompt) handle errors better in the command definition * internal: (cy.prompt) add timeout and handle loading errors more cleanly * add process environment variable * clean up test * update JSDoc * chore: handle errors (#31854) * chore: handle errors * Fix ts, add test * Fix error title * Fix ts * Fix ts * chores: (cy.prompt) refactor routing to support both app and driver (#31891) * chore: Share error utils with the cloud (#31887) * share error utils with cloud * additional rework * Fix command, add isOpenMode * Add / fix test * fix ts --------- Co-authored-by: Ryan Manuel <[email protected]> * internal: (cy.prompt) add infrastructure to support a Get Code modal (#31904) * chore: (cy.prompt) add infrastructure to support a Get Code modal * fix tests * fix code paths * Update eject button styles * handle errors * update types * Update packages/server/lib/socket-base.ts * Fix cy test * update readme --------- Co-authored-by: estrada9166 <[email protected]> * chore: (cy.prompt) refactor getTestsState to take a runnable id (#31965) * chore: (cy.prompt) refactor getTestsState to take a runnable id * fix tests * minor tweak * chore: (cy.prompt) add manifest for all of the cloud delivered files (#31922) * chore: (cy.prompt) add manifest for all of the cloud delivered files * fix tests and remove environment variables * update strategy * fix build * rework * require manifest * clean up * refactor * refactor * Update packages/server/lib/cloud/cy-prompt/CyPromptLifecycleManager.ts Co-authored-by: Matt Schile <[email protected]> * fix test --------- Co-authored-by: Matt Schile <[email protected]> * feat: add cy prompt more info needed modal (WIP) (#31970) * feat: add cy prompt more info needed modal * Reset promptStore * additional things exposed for more info * rework * fix tests * fix build * fix types * fix types * Update packages/app/src/runner/event-manager.ts Co-authored-by: Copilot <[email protected]> * reefactor * chore: (cy.prompt) rework the file save lifecycle * rework types * add unit tests --------- Co-authored-by: estrada9166 <[email protected]> Co-authored-by: Copilot <[email protected]> * fix: (cy.prompt) ensure that we do not attach a vue ref to the react root in the cy.prompt modals (#32011) * fix: (studio) ensure that we do not attach a vue ref to the react root in the studio panel * fix test * chore: Handle cy-prompt error to the cloud (#32009) Co-authored-by: Ryan Manuel <[email protected]> * chore: display prompt error message (#32016) * add createCloudRequest to cloudApi, handle errors during createCyPromptServer * render the get code button on failure * chore: update types * chore: move CT and browser error to cloud (#32077) * feat: (cy.prompt) give cy.prompt access to recording information (#32110) * feat: (cy.prompt) give cy.prompt access to recording information * undo bad refactor * undo bad refactor * undo bad refactor * rename * fix typo * Update packages/server/test/unit/modes/record_spec.js * Update packages/server/test/unit/modes/record_spec.js * Update packages/server/test/unit/modes/record_spec.js * Update packages/server/test/unit/modes/record_spec.js * Update packages/server/test/unit/modes/record_spec.js * Update cy-prompt-development.md * Update cy-prompt-development.md * Update cy-prompt-development.md * chore: add CYPRESS_INTERNAL_SIMULATE_OPEN_MODE to simulate running Cypress tests in open mode (#32114) * chore: (cy.prompt) ensure to strip out paths from all data when reporting errors in prompt (#32134) * fix: (cy.prompt) ensure to strip out paths from all data when reporting errors in prompt * refactor * update tests * fix logic error with protocol * add event manager to get code * Apply suggestions from code review * fix: (cy.prompt) improve the get project options performance by running promises in parallel (#32196) * fix: (cy.prompt) improve the get project options performance by running promises in parallel * add awaits in test * bump cache * Update packages/server/lib/cloud/studio/StudioLifecycleManager.ts * fix build * chore: cleanup * blank * Update trigger-publish-binary-pipeline.js * Update packages/server/test/unit/socket_spec.js * get rid of environment variable * fix: (cy.prompt) ensure to reset the prompt state when the event manager is torn down (indicating that we're no longer on the runner page) (#32301) * fix: (cy.prompt) ensure to reset the prompt state when the event manager is torn down (indicating that we're no longer on the runner page) * move test * fix lint issue * feat: (cy.prompt) introduce the concept of log collapse state being open/closed by default (#32262) * feat: (cy.prompt) introduce the concept of logs' collapse state being open/closed by default * update tests * rename * PR comments * fix test due to bad merge of develop * chore: Only allow experimentalPromptCommand within e2e config (#32435) * chore: Only allow experimentalPromptCommand within e2e config * Fix config * Update tests * Update test, update types * Fix test and types * fix tests * Add types * Update cli/types/cypress.d.ts Co-authored-by: Ryan Manuel <[email protected]> --------- Co-authored-by: Ryan Manuel <[email protected]> * Update workflows.yml * Add optional cyPromptManagerPromise property * Implement error handling in CyPromptManager Added a new method to handle errors uniformly in CyPromptManager. * Fix indentation in socket_spec.js * fix: (cy.prompt) handle when the prompt is executed by in CT or when the experiment is not enabled (#32470) * fix: (cy.prompt) handle when the prompt is executed by in CT or when the experiment is not enabled * Update packages/driver/cypress/e2e/commands/prompt/prompt.cy.ts * Update packages/driver/cypress/e2e/commands/prompt/prompt.cy.ts * update name of errors * Bump cache version to 9-15-2025 * update yarn.lock * fixes * fix snapshot * fix snapshot * internal: fix get code button to be purple with correct margin (#32504) * feat: (cy.prompt) update the types of prompt (#32529) * fix: move currentMoreInfoNeededModalInfo.onCancel to onClose (#32559) * internal: (cy.prompt) various improvements to error messages and time outs (#32582) * internal: (cy.prompt) various improvements to error messages and timeouts * fix test * remove dead code * Update packages/driver/src/cy/commands/prompt/index.ts * update prompt experiment description * fix build * fix tests * fix tests * fix test * update error message * Update packages/server/lib/experiments.ts Co-authored-by: Tim Griesser <[email protected]> --------- Co-authored-by: Tim Griesser <[email protected]> * internal: (cy.prompt) ensure that get code can properly work with prompts in cy.origin (#32596) * internal: (cy.prompt) ensure that get code can properly work with prompts in cy.origin * additional tests * additional tests * Apply suggestions from code review * code review comment * fix merge * fix merge * Update packages/data-context/graphql/schemaTypes/index.ts * update workflow * blank * persist binaries * chore: display custom link title (#32567) * chore: display custom link title * Add test * Pass docs as second argument of the error * Revert changes * Use openExternal for links --------- Co-authored-by: Jennifer Shehane <[email protected]> * update * internal: (cy.prompt) do not retry on cert failures (#32624) * internal: (cy.prompt) do not retry on cert failures * tests and clean up * additional cleanup and add error message for prompt * fix unit tests * Update report_studio_error.ts * Update packages/network/lib/agent.ts * cursor comment * fix build * fix build * fix test * fix build * fix build * fix build * fix build * fix build * revert * Update packages/driver/src/cypress/error_messages.ts * Update packages/driver/cypress/e2e/commands/prompt/prompt-initialization-error.cy.ts * fix build * cursor comment * clean up * fix: (cy.prompt) rename exclude from AI to parameters * fix: (cy.prompt) rename exclude from AI to privateNoCache * further rename and build binary * Update packages/frontend-shared/src/locales/en-US.json * fix tests * rename to placeholders --------- Co-authored-by: Copilot <[email protected]> Co-authored-by: Bill Glesias <[email protected]> Co-authored-by: Alejandro Estrada <[email protected]> Co-authored-by: Matt Schile <[email protected]> Co-authored-by: Tim Griesser <[email protected]> Co-authored-by: Jennifer Shehane <[email protected]>
1 parent 113a136 commit e3f4064

File tree

7 files changed

+5
-13
lines changed

7 files changed

+5
-13
lines changed

.circleci/src/pipeline/@pipeline.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -118,7 +118,7 @@ commands:
118118
name: Set environment variable to determine whether or not to persist artifacts
119119
command: |
120120
echo "Setting SHOULD_PERSIST_ARTIFACTS variable"
121-
echo 'if ! [[ "$CIRCLE_BRANCH" != "develop" && "$CIRCLE_BRANCH" != "release/"* && "$CIRCLE_BRANCH" != "feat/cy-prompt" ]]; then
121+
echo 'if ! [[ "$CIRCLE_BRANCH" != "develop" && "$CIRCLE_BRANCH" != "release/"* && "$CIRCLE_BRANCH" != "ryanm/fix/rename-exclude-from-ai" ]]; then
122122
export SHOULD_PERSIST_ARTIFACTS=true
123123
fi' >> "$BASH_ENV"
124124
# You must run `setup_should_persist_artifacts` command and be using bash before running this command

.circleci/src/pipeline/workflows/@main.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@ linux-x64:
55
- equal: [ develop, << pipeline.git.branch >> ]
66
# use the following branch as well to ensure that v8 snapshot cache updates are fully tested
77
- equal: [ 'update-v8-snapshot-cache-on-develop', << pipeline.git.branch >> ]
8-
- equal: [ 'feat/cy-prompt', << pipeline.git.branch >> ]
8+
- equal: [ 'ryanm/fix/rename-exclude-from-ai', << pipeline.git.branch >> ]
99
- matches:
1010
pattern: /^release\/\d+\.\d+\.\d+$/
1111
value: << pipeline.git.branch >>

cli/types/cypress.d.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -59,7 +59,7 @@ declare namespace Cypress {
5959
[key: string]: any
6060
}
6161
interface PromptOptions {
62-
excludeFromAI?: Record<string, string>
62+
placeholders?: Record<string, string>
6363
}
6464
interface Auth {
6565
username: string

packages/server/lib/cloud/api/cy-prompt/get_cy_prompt_bundle.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,6 @@ export const getCyPromptBundle = async ({ cyPromptUrl, projectId, bundlePath }:
2626
'x-route-version': '1',
2727
'x-cypress-signature': PUBLIC_KEY_VERSION,
2828
...(projectId ? { 'x-cypress-project-slug': projectId } : {}),
29-
'x-cypress-cy-prompt-mount-version': '1',
3029
'x-os-name': os.platform(),
3130
'x-cypress-version': pkg.version,
3231
},

packages/server/lib/cloud/api/cy-prompt/post_cy_prompt_session.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@ export const postCyPromptSession = async ({ projectId }: PostCyPromptSessionOpti
2121
'x-os-name': os.platform(),
2222
'x-cypress-version': pkg.version,
2323
},
24-
body: JSON.stringify({ projectSlug: projectId, cyPromptMountVersion: 1 }),
24+
body: JSON.stringify({ projectSlug: projectId, cyPromptMountVersion: 2 }),
2525
})
2626
}, {
2727
maxAttempts: 3,

packages/server/test/unit/cloud/api/cy-prompt/get_cy_prompt_bundle_spec.ts

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -75,7 +75,6 @@ describe('getCyPromptBundle', () => {
7575
'x-route-version': '1',
7676
'x-cypress-signature': '1',
7777
'x-cypress-project-slug': '12345',
78-
'x-cypress-cy-prompt-mount-version': '1',
7978
'x-os-name': 'linux',
8079
'x-cypress-version': '1.2.3',
8180
},
@@ -121,7 +120,6 @@ describe('getCyPromptBundle', () => {
121120
'x-route-version': '1',
122121
'x-cypress-signature': '1',
123122
'x-cypress-project-slug': '12345',
124-
'x-cypress-cy-prompt-mount-version': '1',
125123
'x-os-name': 'linux',
126124
'x-cypress-version': '1.2.3',
127125
},
@@ -152,7 +150,6 @@ describe('getCyPromptBundle', () => {
152150
'x-route-version': '1',
153151
'x-cypress-signature': '1',
154152
'x-cypress-project-slug': '12345',
155-
'x-cypress-cy-prompt-mount-version': '1',
156153
'x-os-name': 'linux',
157154
'x-cypress-version': '1.2.3',
158155
},
@@ -177,7 +174,6 @@ describe('getCyPromptBundle', () => {
177174
'x-route-version': '1',
178175
'x-cypress-signature': '1',
179176
'x-cypress-project-slug': '12345',
180-
'x-cypress-cy-prompt-mount-version': '1',
181177
'x-os-name': 'linux',
182178
'x-cypress-version': '1.2.3',
183179
},
@@ -220,7 +216,6 @@ describe('getCyPromptBundle', () => {
220216
'x-route-version': '1',
221217
'x-cypress-signature': '1',
222218
'x-cypress-project-slug': '12345',
223-
'x-cypress-cy-prompt-mount-version': '1',
224219
'x-os-name': 'linux',
225220
'x-cypress-version': '1.2.3',
226221
},
@@ -255,7 +250,6 @@ describe('getCyPromptBundle', () => {
255250
'x-route-version': '1',
256251
'x-cypress-signature': '1',
257252
'x-cypress-project-slug': '12345',
258-
'x-cypress-cy-prompt-mount-version': '1',
259253
'x-os-name': 'linux',
260254
'x-cypress-version': '1.2.3',
261255
},
@@ -288,7 +282,6 @@ describe('getCyPromptBundle', () => {
288282
'x-route-version': '1',
289283
'x-cypress-signature': '1',
290284
'x-cypress-project-slug': '12345',
291-
'x-cypress-cy-prompt-mount-version': '1',
292285
'x-os-name': 'linux',
293286
'x-cypress-version': '1.2.3',
294287
},

packages/server/test/unit/cloud/api/cy-prompt/post_cy_prompt_session_spec.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,7 @@ describe('postCyPromptSession', () => {
4141
'x-os-name': os.platform(),
4242
'x-cypress-version': pkg.version,
4343
},
44-
body: JSON.stringify({ projectSlug: '12345', cyPromptMountVersion: 1 }),
44+
body: JSON.stringify({ projectSlug: '12345', cyPromptMountVersion: 2 }),
4545
},
4646
)
4747
})

0 commit comments

Comments
 (0)