Skip to content

Commit e9f5df0

Browse files
committed
chore: sync cloud validations after building packages as the network libs are needed
1 parent e625766 commit e9f5df0

File tree

2 files changed

+7
-7
lines changed

2 files changed

+7
-7
lines changed

.circleci/src/pipeline/@pipeline.yml

Lines changed: 4 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -195,17 +195,15 @@ commands:
195195
description: Save entire folder as artifact for other jobs to run without reinstalling
196196
steps:
197197
- run:
198-
name: Sync Cloud Validations
198+
name: Build packages
199199
command: |
200200
source ./scripts/ensure-node.sh
201-
yarn workspace @packages/network-tools build
202-
yarn workspace @packages/network build
203-
yarn gulp syncCloudValidations
201+
yarn build
204202
- run:
205-
name: Build packages
203+
name: Sync Cloud Validations
206204
command: |
207205
source ./scripts/ensure-node.sh
208-
yarn build
206+
yarn gulp syncCloudValidations
209207
- run:
210208
name: Generate v8 snapshot
211209
command: |

packages/server/test/unit/cloud/api/cloud_request_spec.ts

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,9 @@
11
import sinon from 'sinon'
22
import sinonChai from 'sinon-chai'
33
import chai, { expect } from 'chai'
4-
import agent, { strictAgent } from '@packages/network'
4+
// NOTE: having to import directly from the lib folder as we cannot test ES6 classes effectively with sinon.
5+
// Since this is a test, this is OK, but testing directly from lib in other modules is not a best practice.
6+
import agent, { strictAgent } from '@packages/network/lib/agent'
57
import axios, { CreateAxiosDefaults, AxiosInstance } from 'axios'
68
import debugLib from 'debug'
79
import stripAnsi from 'strip-ansi'

0 commit comments

Comments
 (0)