fix: No longer display tags on stderr data in component testing#33400
Draft
cacieprins wants to merge 9 commits intodevelopfrom
Draft
fix: No longer display tags on stderr data in component testing#33400cacieprins wants to merge 9 commits intodevelopfrom
stderr data in component testing#33400cacieprins wants to merge 9 commits intodevelopfrom
Conversation
stderr data in component testingstderr data in component testing
cypress
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| Project |
cypress
|
| Branch Review |
fix/ct-stderr-tags-in-prod
|
| Run status |
|
| Run duration | 19m 13s |
| Commit |
|
| Committer | Cacie Prins |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
|
|
2
|
|
|
9
|
|
|
1112
|
|
|
0
|
|
|
27174
|
| View all changes introduced in this branch ↗︎ | |
UI Coverage
62.34%
|
|
|---|---|
|
|
27
|
|
|
48
|
Accessibility
98.98%
|
|
|---|---|
|
|
0 critical
3 serious
1 moderate
0 minor
|
|
|
18
|
Tests for review
src/debug/DebugSpec.cy.tsx • 1 failed test • app-ct
| Test | Artifacts | |
|---|---|---|
| An uncaught error was detected outside of a test |
Test Replay
|
|
cypress/e2e/runner/reporter.command_errors.cy.ts • 1 failed test • app-e2e
| Test | Artifacts | |
|---|---|---|
| errors ui > assertion failures with new sourcemap root |
Test Replay
Screenshots
|
|
e2e/origin/config_env_expose.cy.ts • 1 flaky test • 5x-driver-electron
| Test | Artifacts | |
|---|---|---|
| cy.origin- Cypress.config() > serializable > overwrites different values in secondary if one exists in the primary |
Test Replay
|
|
issues/28527.cy.ts • 1 flaky test • 5x-driver-electron
| Test | Artifacts | |
|---|---|---|
| issue 28527 > fails and then retries and verifies about:blank is not displayed |
Test Replay
Screenshots
|
|
issues/28527.cy.ts • 1 flaky test • 5x-driver-chrome:beta
| Test | Artifacts | |
|---|---|---|
| issue 28527 > fails and then retries and verifies about:blank is not displayed |
Test Replay
Screenshots
|
|
commands/net_stubbing.cy.ts • 1 flaky test • 5x-driver-firefox
| Test | Artifacts | |||||||
|---|---|---|---|---|---|---|---|---|
| ... > stops waiting when an xhr request is canceled |
| |||||||
| Test | Artifacts | |
|---|---|---|
| src/cy/commands/files > #readFile > retries to read when ENOENT |
The first 5 flaky specs are shown, see all 9 specs in Cypress Cloud. | |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Additional details
When Cypress intentionally writes to
stderr, it tags the content so that it will be preserved and written to the top levelstderr. The@packages/stderr-filteringpackage takes care of tagging data and filtering the tags (and untagged data) from thestderrstream. This prevents benignstderrmessages from Electron from surfacing.In component testing
runmode with webpack 5, the out stream was getting tagged. Unfortunately, that entrypoint to the binary was not captured by the filtering part of@packages/stderr-filtering.This moves
filterstreaming from@packages/electronto the spawn logic in@packages/cli, ensuring it wraps the outermost process and filters any tags that come throughstderr.Steps to test
yarn binary-build(choose: overwrite)yarn binary-package [--skipSigning, if on osx]cypress-component-testing-apps: https://github.com/cypress-io/cypress-component-testing-apps/tree/main/react-webpack5-jsCYPRESS.STDERRtags in the output streamHow has the user experience changed?
PR Tasks
cypress-documentation?type definitions?