Merge pull request #176 from MikeMcC399/support-eslint-7-and-8

feat: support eslint v7 & v8 instead of ">= 3.2.1"

Author: jennifer-shehane

README.md

@@ -6,6 +6,8 @@ Note: If you installed ESLint globally then you must also install `eslint-plugin
 
 ## Installation
 
+Prerequisites: [ESLint](https://www.npmjs.com/package/eslint) `v7` or `v8`. ESLint `v9` is **not** supported yet.
+
 ```sh
 npm install eslint-plugin-cypress --save-dev
 ```
@@ -115,8 +117,6 @@ These rules enforce some of the [best practices recommended for using Cypress](h
 
 Rules with a check mark (✅) are enabled by default while using the `plugin:cypress/recommended` config.
 
-**NOTE**: These rules currently require eslint 5.0 or greater. If you would like support added for eslint 4.x, please 👍  [this issue](https://github.com/cypress-io/eslint-plugin-cypress/issues/14).
-
 |     | Rule ID                                                                    | Description                                                     |
 | :-- | :------------------------------------------------------------------------- | :-------------------------------------------------------------- |
 | ✅  | [no-assigning-return-values](./docs/rules/no-assigning-return-values.md)   | Prevent assigning return values of cy calls                     |

circle.yml

@@ -5,15 +5,13 @@ workflows:
   main:
     jobs:
       - lint
-      - test-v5
-      - test-v6
       - test-v7
+      - test-v8
       - release:
           requires:
             - lint
-            - test-v5
-            - test-v6
             - test-v7
+            - test-v8
           filters:
             branches:
               only:
@@ -32,22 +30,7 @@ jobs:
           name: Lint code
           command: npm run lint
 
-  test-v5:
-    docker:
-      - image: cimg/node:20.12.2
-    steps:
-      - checkout
-      - run:
-          name: Install dependencies
-          command: npm ci
-      - run:
-          name: Install ESLint 5
-          command: npm install eslint@5
-      - run:
-          name: Test ESLint 5
-          command: npm test
-
-  test-v6:
+  test-v7:
     docker:
       - image: cimg/node:20.12.2
     steps:
@@ -56,13 +39,13 @@ jobs:
           name: Install dependencies
           command: npm ci
       - run:
-          name: Install ESLint 6
-          command: npm install eslint@6
+          name: Install ESLint 7
+          command: npm install eslint@7
       - run:
-          name: Test ESLint 6
+          name: Test ESLint 7
           command: npm test
 
-  test-v7:
+  test-v8:
     docker:
       - image: cimg/node:20.12.2
     steps:
@@ -71,10 +54,10 @@ jobs:
           name: Install dependencies
           command: npm ci
       - run:
-          name: Install ESLint 7
-          command: npm install eslint@7
+          name: Install ESLint 8
+          command: npm install eslint@8
       - run:
-          name: Test ESLint 7
+          name: Test ESLint 8
           command: npm test
 
   release:

package-lock.json

@@ -19,7 +19,7 @@
   },
   "homepage": "https://github.com/cypress-io/eslint-plugin-cypress#readme",
   "peerDependencies": {
-    "eslint": ">= 3.2.1"
+    "eslint": ">=7 <9"
   },
   "dependencies": {
     "globals": "^13.20.0"
@@ -44,7 +44,6 @@
     "semantic-release": "semantic-release",
     "start": "yarn run test-watch",
     "test": "jest",
-    "test:v6": "npm i [email protected] && npm run test",
     "test-watch": "jest --watchAll",
     "prepare": "husky install"
   }