Final fixes and test fixes

Author: lukeapage

lib/rules/assertion-before-screenshot.js

@@ -11,6 +11,9 @@ const assertionCommands = [
   'and',
   'contains',
 
+  // retries until it gets something
+  'get',
+
   // not an assertion, but unlikely to require waiting for render
   'scrollIntoView',
   'scrollTo',

tests/lib/rules/assertion-before-screenshot.js

@@ -11,13 +11,14 @@ const parserOptions = { ecmaVersion: 6 }
 ruleTester.run('assertion-before-screenshot', rule, {
   valid: [
     { code: 'cy.get(".some-element"); cy.screenshot();', parserOptions },
-    { code: 'cy.get(".some-element").screenshot();', parserOptions },
-    { code: 'cy.get(".some-element").should("be.visible"); cy.screenshot();', parserOptions },
-    { code: 'cy.get(".some-element").screenshot().click()', parserOptions, errors },
-    { code: 'cy.get(".some-element"); if(true) cy.screenshot();', parserOptions },
-    { code: 'if(true) { cy.get(".some-element"); cy.screenshot(); }', parserOptions },
-    { code: 'cy.get(".some-element"); if(true) { cy.screenshot(); }', parserOptions },
-    { code: 'const a = () => { cy.get(".some-element"); cy.screenshot(); }', parserOptions, errors },
+    { code: 'cy.get(".some-element").should("exist").screenshot();', parserOptions },
+    { code: 'cy.get(".some-element").should("exist").screenshot().click()', parserOptions, errors },
+    { code: 'cy.get(".some-element").should("exist"); if(true) cy.screenshot();', parserOptions },
+    { code: 'if(true) { cy.get(".some-element").should("exist"); cy.screenshot(); }', parserOptions },
+    { code: 'cy.get(".some-element").should("exist"); if(true) { cy.screenshot(); }', parserOptions },
+    { code: 'const a = () => { cy.get(".some-element").should("exist"); cy.screenshot(); }', parserOptions, errors },
+    { code: 'cy.get(".some-element").should("exist").and("be.visible"); cy.screenshot();', parserOptions },
+    { code: 'cy.get(".some-element").contains("Text"); cy.screenshot();', parserOptions },
   ],
 
   invalid: [