fix: Unordered tables in postgresql_publication (#219)

* order publication tables

* Add missing space in the query

* Convert publication tables from TypeList to TypeSet

* Remove redundant error handling

Author: nguyenhoaibao

postgresql/resource_postgresql_publication.go

@@ -56,7 +56,7 @@ func resourcePostgreSQLPublication() *schema.Resource {
 				ValidateFunc: validation.StringIsNotEmpty,
 			},
 			pubTablesAttr: {
-				Type:          schema.TypeList,
+				Type:          schema.TypeSet,
 				Optional:      true,
 				Computed:      true,
 				ForceNew:      false,
@@ -174,8 +174,8 @@ func setPubTables(txn *sql.Tx, d *schema.ResourceData) error {
 	pubName := d.Get(pubNameAttr).(string)
 
 	oraw, nraw := d.GetChange(pubTablesAttr)
-	oldList := oraw.([]interface{})
-	newList := nraw.([]interface{})
+	oldList := oraw.(*schema.Set).List()
+	newList := nraw.(*schema.Set).List()
 	if elem, ok := isUniqueArr(newList); !ok {
 		return fmt.Errorf("'%s' is duplicated for attribute `%s`", elem.(string), pubTablesAttr)
 	}
@@ -372,13 +372,10 @@ func resourcePostgreSQLPublicationReadImpl(db *DBConnection, d *schema.ResourceD
 		}
 		tables = append(tables, table)
 	}
-
-	switch {
-	case err == sql.ErrNoRows:
-		log.Printf("[WARN] No PostgreSQL tables found for Publication %s", PublicationName)
-	case err != nil:
-		return fmt.Errorf("Error reading Publication tables: %w", err)
+	if err := rows.Err(); err != nil {
+		return fmt.Errorf("Got rows.Err: %w", err)
 	}
+
 	if pubinsert {
 		publishParams = append(publishParams, "insert")
 	}
@@ -449,7 +446,7 @@ func getDatabaseForPublication(d *schema.ResourceData, databaseName string) stri
 
 func getTablesForPublication(d *schema.ResourceData) (string, error) {
 	var tablesString string
-	tables, ok := d.GetOk(pubTablesAttr)
+	setTables, ok := d.GetOk(pubTablesAttr)
 	isAllTables, isAllOk := d.GetOk(pubAllTablesAttr)
 
 	if isAllOk {
@@ -458,11 +455,12 @@ func getTablesForPublication(d *schema.ResourceData) (string, error) {
 		}
 	}
 	if ok {
+		tables := setTables.(*schema.Set).List()
 		var tlist []string
-		if elem, ok := isUniqueArr(tables.([]interface{})); !ok {
+		if elem, ok := isUniqueArr(tables); !ok {
 			return tablesString, fmt.Errorf("'%s' is duplicated for attribute `%s`", elem.(string), pubTablesAttr)
 		}
-		for _, t := range tables.([]interface{}) {
+		for _, t := range tables {
 			tlist = append(tlist, t.(string))
 		}
 		tablesString = fmt.Sprintf("FOR TABLE %s", strings.Join(tlist, ", "))