postgresql_default_privileges_test: Add test for with_grant_option (#63)

Author: cyrilgdn

postgresql/resource_postgresql_default_privileges.go

@@ -97,6 +97,10 @@ func resourcePostgreSQLDefaultPrivilegesRead(db *DBConnection, d *schema.Resourc
 
 func resourcePostgreSQLDefaultPrivilegesCreate(db *DBConnection, d *schema.ResourceData) error {
 
+	if d.Get("with_grant_option").(bool) && strings.ToLower(d.Get("role").(string)) == "public" {
+		return fmt.Errorf("with_grant_option cannot be true for role 'public'")
+	}
+
 	if err := validatePrivileges(d); err != nil {
 		return err
 	}

postgresql/resource_postgresql_default_privileges_test.go

@@ -23,6 +23,10 @@ func TestAccPostgresqlDefaultPrivileges(t *testing.T) {
 	// Set default privileges to the test role then to public (i.e.: everyone)
 	for _, role := range []string{roleName, "public"} {
 		t.Run(role, func(t *testing.T) {
+			withGrant := true
+			if role == "public" {
+				withGrant = false
+			}
 
 			// We set PGUSER as owner as he will create the test table
 			var tfConfig = fmt.Sprintf(`
@@ -32,9 +36,10 @@ resource "postgresql_default_privileges" "test_ro" {
 	role        = "%s"
 	schema      = "test_schema"
 	object_type = "table"
+	with_grant_option = %t
 	privileges   = %%s
 }
-	`, dbName, config.Username, role)
+	`, dbName, config.Username, role, withGrant)
 
 			resource.Test(t, resource.TestCase{
 				PreCheck: func() {
@@ -56,6 +61,7 @@ resource "postgresql_default_privileges" "test_ro" {
 								return testCheckTablesPrivileges(t, dbName, roleName, tables, []string{"SELECT"})
 							},
 							resource.TestCheckResourceAttr("postgresql_default_privileges.test_ro", "object_type", "table"),
+							resource.TestCheckResourceAttr("postgresql_default_privileges.test_ro", "with_grant_option", fmt.Sprintf("%t", withGrant)),
 							resource.TestCheckResourceAttr("postgresql_default_privileges.test_ro", "privileges.#", "1"),
 							resource.TestCheckResourceAttr("postgresql_default_privileges.test_ro", "privileges.3138006342", "SELECT"),
 						),