postgresql_grant: in-place updates when objects change (table/sequence)#614
Open
nicks wants to merge 1 commit intocyrilgdn:mainfrom
Open
postgresql_grant: in-place updates when objects change (table/sequence)#614nicks wants to merge 1 commit intocyrilgdn:mainfrom
nicks wants to merge 1 commit intocyrilgdn:mainfrom
Conversation
Before this PR, when the 'objects' field changed, the grant resource was recreated. This has some downsides: - If the create fails, the existing grant is lost - There is a brief moment during the update where the role has no privileges. To support a transactional update in-place, the read function needs to be able to correctly read the state of existing objects and detect partial update failures. I only made this change for tables and sequences. Other object types will still do re-create. Fixes cyrilgdn#208 Signed-off-by: Nick Santos <nick.santos@docker.com>
|
@cyrilgdn Any chance you're able to take a look here? 🙏 This would help our usecases as well |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before this PR, when the 'objects' field changed,
the grant resource was recreated.
This has some downsides:
To support a transactional update in-place, the read function needs to be able to correctly read the state of existing objects and detect partial update failures.
I only made this change for tables and sequences. Other object types will still do re-create.
Fixes #208